Merge lp:~prsyahmi/audience/audience into lp:~audience-members/audience/trunk
Proposed by
Syahmi Azhar
on 2015-01-10
Status: | Work in progress |
---|---|
Proposed branch: | lp:~prsyahmi/audience/audience |
Merge into: | lp:~audience-members/audience/trunk |
Diff against target: |
136 lines (+13/-23) 2 files modified
src/Audience.vala (+9/-21) src/Widgets/VideoPlayer.vala (+4/-2) |
To merge this branch: | bzr merge lp:~prsyahmi/audience/audience |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Audience Members | 2015-01-10 | Pending | |
Review via email:
|
To post a comment you must log in.
Viko Adi Rahmawan (vikoadi) wrote : | # |
Syahmi Azhar (prsyahmi) wrote : | # |
> hello Syahmi,
> would it be better if instead of
>
> } else if (is_subtitle (filename)) {
> if (video_player.uri != null) {
> video_player.
> }
> }
>
> just do
>
> } else if (is_subtitle (filename) && video_player.uri != null) {
> video_player.
> }
>
> Thanks
Hi Viko Adi Rahmawan,
You are right. I'm not sure why I'm doing that in the first place, perhaps I'm doing multiple checks before committing. Thank you.
Regards.
hello Syahmi,
would it be better if instead of
} else if (is_subtitle (filename)) { player. set_subtitle_ uri (filename);
if (video_player.uri != null) {
video_
}
}
just do
} else if (is_subtitle (filename) && video_player.uri != null) { player. set_subtitle_ uri (filename);
video_
}
Thanks