Code review comment for lp:~prsyahmi/audience/audience

Revision history for this message
Syahmi Azhar (prsyahmi) wrote :

> hello Syahmi,
> would it be better if instead of
>
> } else if (is_subtitle (filename)) {
> if (video_player.uri != null) {
> video_player.set_subtitle_uri (filename);
> }
> }
>
> just do
>
> } else if (is_subtitle (filename) && video_player.uri != null) {
> video_player.set_subtitle_uri (filename);
> }
>
> Thanks

Hi Viko Adi Rahmawan,

You are right. I'm not sure why I'm doing that in the first place, perhaps I'm doing multiple checks before committing. Thank you.

Regards.

« Back to merge proposal