Merge ~powersj/cloud-init:cii-ssh-keyname into cloud-init:master

[Joshua Powers]

tests: rename test ssh keys to avoid appearance of leaking private keys.

While the generated ssh keys are throw away keys, generating SSH keys
with the default name (e.g. id_rsa) can trigger security scanners or
draw unnecessary attention.

The change here simply renames 'id_rsa' to 'cloud_init_rsa' to avoid
a false positive reported by a scanning tool.

[Server Team CI bot (server-team-bot)]

PASSED: Continuous integration, rev:792fa73d40d2058935deb67650167bfefe0085a8
https://jenkins.ubuntu.com/server/job/cloud-init-ci/675/
Executed test runs:
    SUCCESS: Checkout
    SUCCESS: Unit & Style Tests
    SUCCESS: Ubuntu LTS: Build
    SUCCESS: Ubuntu LTS: Integration
    SUCCESS: MAAS Compatability Testing
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/675/rebuild

review: Approve (continuous-integration)

[Scott Moser (smoser)]

So some tool just didn't like a file existing with the name 'id_rsa' ?
that seems overly simplistic and not entirely useful. I personally don't like files named "cubs-stink", but if some program creates them, I dont ask that program to change its behaviors.

Anyway..

Can we at least mention *what* was complaining rather than just "comply with a request".

[Joshua Powers (powersj)]

Updated commit message

[Scott Moser (smoser)]

review: Approve

diff --git a/tests/cloud_tests/platforms.yaml b/tests/cloud_tests/platforms.yaml
index cb1c904..448aa98 100644
--- a/tests/cloud_tests/platforms.yaml
+++ b/tests/cloud_tests/platforms.yaml
@@ -6,8 +6,8 @@ default_platform_config:
     get_image_timeout: 300
     # maximum time to create instance (before waiting for cloud-init)
     create_instance_timeout: 60
-    private_key: id_rsa
-    public_key: id_rsa.pub
+    private_key: cloud_init_rsa
+    public_key: cloud_init_rsa.pub
 platforms:
     ec2:
         enabled: true
diff --git a/tests/cloud_tests/platforms/platforms.py b/tests/cloud_tests/platforms/platforms.py
index d4e5c56..1542b3b 100644
--- a/tests/cloud_tests/platforms/platforms.py
+++ b/tests/cloud_tests/platforms/platforms.py
@@ -33,7 +33,7 @@ class Platform(object):
 
     def _generate_ssh_keys(self, data_dir):
         """Generate SSH keys to be used with image."""
-        filename = os.path.join(data_dir, 'id_rsa')
+        filename = os.path.join(data_dir, self.config['private_key'])
 
         if os.path.exists(filename):
             c_util.del_file(filename)