Merge ~powersj/cloud-init:unittest-add-timing into cloud-init:master

Proposed by Joshua Powers on 2017-09-01
Status: Merged
Merged at revision: 653c0b4cfc6325382a3fb93a2185ab74f9cee62a
Proposed branch: ~powersj/cloud-init:unittest-add-timing
Merge into: cloud-init:master
Diff against target: 22 lines (+7/-4)
1 file modified
tox.ini (+7/-4)
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Approve on 2017-09-01
Chad Smith 2017-09-01 Approve on 2017-09-01
Review via email: mp+330111@code.launchpad.net

Commit Message

tox: add nose timer output

This adds the output of the nose timer plugin to the py3
environment to tox. This will print out the 10 longest running
tests and automatically turn tests longer than 1 second "red"
after the coverage output.

To post a comment you must log in.
Joshua Powers (powersj) wrote :
Chad Smith (chad.smith) wrote :

+1 looks good to me!

review: Approve

FAILED: Continuous integration, rev:9412ec30b2f3e36124e696a08f7e09ab8aa99e45
https://jenkins.ubuntu.com/server/job/cloud-init-ci/252/
Executed test runs:
    SUCCESS: Checkout
    FAILED: Unit & Style Tests

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/252/rebuild

review: Needs Fixing (continuous-integration)
25fd8f8... by Joshua Powers on 2017-09-01

move to py3 env only

Chad Smith (chad.smith) wrote :

+1 Yep much better and limits it to our py3 env, which already does the extra work of coverage etc. It feels like that's a better home anyway (and avoids issues with other targets).

review: Approve

PASSED: Continuous integration, rev:25fd8f8b13f09a99e847d114719a8036faf6b020
https://jenkins.ubuntu.com/server/job/cloud-init-ci/253/
Executed test runs:
    SUCCESS: Checkout
    SUCCESS: Unit & Style Tests
    SUCCESS: Ubuntu LTS: Build
    SUCCESS: Ubuntu LTS: Integration
    SUCCESS: MAAS Compatability Testing
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/253/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tox.ini b/tox.ini
2index ec96e85..72de983 100644
3--- a/tox.ini
4+++ b/tox.ini
5@@ -30,10 +30,13 @@ commands = {envpython} -m pylint {posargs:cloudinit}
6
7 [testenv:py3]
8 basepython = python3
9-deps = -r{toxinidir}/test-requirements.txt
10-commands = {envpython} -m nose {posargs:--with-coverage \
11- --cover-erase --cover-branches --cover-inclusive \
12- --cover-package=cloudinit tests/unittests cloudinit}
13+deps =
14+ nose-timer
15+ -r{toxinidir}/test-requirements.txt
16+commands = {envpython} -m nose --with-timer --timer-top-n 10 \
17+ {posargs:--with-coverage --cover-erase --cover-branches \
18+ --cover-inclusive --cover-package=cloudinit \
19+ tests/unittests cloudinit}
20
21 [testenv:py27]
22 basepython = python2.7

Subscribers

People subscribed via source and target branches