Merge ~powersj/cloud-init:fix-integration-ntp into cloud-init:master
| Status: | Merged |
|---|---|
| Merged at revision: | 9fa17d4bc1ef2564e30ab655bf6de462296aecad |
| Proposed branch: | ~powersj/cloud-init:fix-integration-ntp |
| Merge into: | cloud-init:master |
| Diff against target: |
17 lines (+3/-3) 1 file modified
tests/cloud_tests/testcases/modules/ntp_servers.py (+3/-3) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Server Team CI bot | continuous-integration | Approve on 2017-05-22 | |
| Scott Moser | Needs Fixing on 2017-05-22 | ||
| Ryan Harper | 2017-05-22 | Approve on 2017-05-22 | |
|
Review via email:
|
|||
Commit Message
tests: Fix ntp integration test regression
LP: #1692686
PASSED: Continuous integration, rev:5375d9da344
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
Click here to trigger a rebuild:
https:/
| Scott Moser (smoser) wrote : | # |
I am pretty sure that you should change the docstring for 'test_ntp_entires'. Ie, you're changing 'ntp_conf_pools' to 'ntp_conf_servers' inside a function with a doc string "Test config pools entries".
And while you're there, you might as well spell entries right in the function name.
PASSED: Continuous integration, rev:9fa17d4bc1e
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
Click here to trigger a rebuild:
https:/


Thank you for finding/fixing my merge error.