Code review comment for ~pointhi/kicad:wx-python

Revision history for this message
Thomas Pointhuber (pointhi) wrote :

> It doesn't build on msys2 when python 3 is enabled. It finds the python 3
> interpreter without any issue but it fails finding the python3 library path.
> Here is the config error:
>
> -- Found PythonInterp: C:/msys64/mingw64/bin/python3.exe (found suitable
> version "3.7.1", minimum required is "3.3")
> -- Check for installed Python Interpreter -- found
> -- Python module install path: lib/python3.7/site-packages
> CMake Error at C:/msys64/mingw64/share/cmake-3.12/Modules/FindPackageHandleSta
> ndardArgs.cmake:137 (message):
> Could NOT find PythonLibs (missing: PYTHON_INCLUDE_DIRS) (Required is at
> least version "3.3")
> Call Stack (most recent call first):
> C:/msys64/mingw64/share/cmake-3.12/Modules/FindPackageHandleStandardArgs.cma
> ke:378 (_FPHSA_FAILURE_MESSAGE)
> CMakeModules/FindPythonLibs.cmake:233 (find_package_handle_standard_args)
> CMakeLists.txt:750 (find_package)
>
>
> -- Configuring incomplete, errors occurred!

That's weird because this patch should not change Python3 stuff. Can you verify this problem does not exist upstream?

« Back to merge proposal