Merge ~pointhi/kicad:wx-python into ~kicad-product-committers/kicad:master
Status: | Merged |
---|---|
Merge reported by: | Maciej Suminski |
Merged at revision: | 00511f2a7f7811e1fe8cfbbaa1664edaaba25d91 |
Proposed branch: | ~pointhi/kicad:wx-python |
Merge into: | ~kicad-product-committers/kicad:master |
Diff against target: |
274 lines (+95/-43) 6 files modified
CMakeLists.txt (+26/-2) Documentation/development/compiling.md (+5/-0) common/dialog_about/dialog_about.cpp (+7/-0) pcbnew/python/kicad_pyshell/__init__.py (+5/-0) pcbnew/swig/python_scripting.cpp (+47/-40) pcbnew/swig/python_scripting.h (+5/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Wayne Stambaugh | Approve | ||
Maciej Suminski | Approve | ||
Seth Hillbrand | Approve | ||
Review via email: mp+357605@code.launchpad.net |
Commit message
Add optional wxPhoenix support
Description of the change
Based on the work of @mmccoo:
* https:/
and this additional patchset to remove wxpy_api.h dependency:
* http://
It adds wxPhoenix support to KiCad while keeping support for the old wxPython binding. All known are resolved now. In my case testing took place with wx3.0.4+GTK3 on Python2+wxPython as well as Python3+wxPhoenix on Linux. It would be nice to get testing done on Windows as well as Mac at least with the old wxPython version to ensure nothing breaks. While there are currently some compiler problems to get wxPhoenix running on Windows, adding this would benefit especially Linux users on Python3 only systems to get shell support.
Windows build can be found here: https:/ /jenkins. simonrichter. eu/job/ windows- kicad-msys2- patch/171/