Code review comment for lp:~pkunal-parmar/ubuntu-calendar-app/today

Revision history for this message
Olivier Tilloy (osomon) wrote :

43 +// TODO: Following function is causing regression in monthview
44 +// It is affecting month view's layout and default date is select
45 +// Temporarily reverting changes
46 +//Date.prototype.midnight = function() {
47 +// var date = new Date(this)
48 +// date.setHours(0,0,0,0);
49 +// return date
50 +//}

You can’t just revert the function to its previous implementation, as it was buggy.
What regression exactly is it causing? Can’t it be addressed properly?

review: Needs Fixing

« Back to merge proposal