Merge lp:~pkunal-parmar/ubuntu-calendar-app/today into lp:ubuntu-calendar-app

[Kunal Parmar]

Jump to today, feature implemented

Jump to today, feature implemented

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:47
http://91.189.93.125:8080/job/ubuntu-calendar-app-ci/25/
Executed test runs:
    SUCCESS: http://91.189.93.125:8080/job/ubuntu-calendar-app-quantal-amd64-ci/10
    SUCCESS: http://91.189.93.125:8080/job/ubuntu-calendar-app-raring-amd64-ci/25

Click here to trigger a rebuild:
http://91.189.93.125:8080/job/ubuntu-calendar-app-ci/25/rebuild

review: Approve (continuous-integration)

[Olivier Tilloy (osomon)]

This doesn’t work if I’m looking at the same month next year (e.g. swipe left 12 times to browse to June 2014, and then click the Today button).

As a side note, this is typically the functionality that would greatly benefit from an associated autopilot test, do you think you could add one (that would cover the normal use cases as well as the "corner" cases like the one I’ve described above). If you need help writing autopilot tests, do not hesitate to ask Omer Akram (om26er on IRC) or myself. Cheers!

review: Needs Fixing

[Kunal Parmar (pkunal-parmar)]

> This doesn’t work if I’m looking at the same month next year (e.g. swipe left
> 12 times to browse to June 2014, and then click the Today button).
>
> As a side note, this is typically the functionality that would greatly benefit
> from an associated autopilot test, do you think you could add one (that would
> cover the normal use cases as well as the "corner" cases like the one I’ve
> described above). If you need help writing autopilot tests, do not hesitate to
> ask Omer Akram (om26er on IRC) or myself. Cheers!

Ahh, I never tested that test case, thought from code it was quite evident that it will not work for same month.

I fixed this, but I am yet to implement test case for it. Yes, I agree that test case will help greatly.

I checked code and looks like, current month view implementation does not allow user to browse more then 24 month in one direction. I guess we will need to make changes to allow browse as much as user wanted, and we will need test case that time.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:48
http://91.189.93.125:8080/job/ubuntu-calendar-app-ci/34/
Executed test runs:
    SUCCESS: http://91.189.93.125:8080/job/ubuntu-calendar-app-quantal-amd64-ci/19
    SUCCESS: http://91.189.93.125:8080/job/ubuntu-calendar-app-raring-amd64-ci/34

Click here to trigger a rebuild:
http://91.189.93.125:8080/job/ubuntu-calendar-app-ci/34/rebuild

review: Approve (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:49
http://91.189.93.125:8080/job/ubuntu-calendar-app-ci/35/
Executed test runs:
    SUCCESS: http://91.189.93.125:8080/job/ubuntu-calendar-app-quantal-amd64-ci/20
    SUCCESS: http://91.189.93.125:8080/job/ubuntu-calendar-app-raring-amd64-ci/35

Click here to trigger a rebuild:
http://91.189.93.125:8080/job/ubuntu-calendar-app-ci/35/rebuild

review: Approve (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:50
http://91.189.93.125:8080/job/ubuntu-calendar-app-ci/36/
Executed test runs:
    SUCCESS: http://91.189.93.125:8080/job/ubuntu-calendar-app-quantal-amd64-ci/21
    SUCCESS: http://91.189.93.125:8080/job/ubuntu-calendar-app-raring-amd64-ci/36

Click here to trigger a rebuild:
http://91.189.93.125:8080/job/ubuntu-calendar-app-ci/36/rebuild

review: Approve (continuous-integration)

[Kunal Parmar (pkunal-parmar)]

> > This doesn’t work if I’m looking at the same month next year (e.g. swipe
> left
> > 12 times to browse to June 2014, and then click the Today button).
> >
> > As a side note, this is typically the functionality that would greatly
> benefit
> > from an associated autopilot test, do you think you could add one (that
> would
> > cover the normal use cases as well as the "corner" cases like the one I’ve
> > described above). If you need help writing autopilot tests, do not hesitate
> to
> > ask Omer Akram (om26er on IRC) or myself. Cheers!
>
> Ahh, I never tested that test case, thought from code it was quite evident
> that it will not work for same month.
>
> I fixed this, but I am yet to implement test case for it. Yes, I agree that
> test case will help greatly.
>
> I checked code and looks like, current month view implementation does not
> allow user to browse more then 24 month in one direction. I guess we will need
> to make changes to allow browse as much as user wanted, and we will need test
> case that time.

There is some bug with AutoPilot system, which prevent testcase from getting any object property from QML.
like
readonly property var currentDayStart: intern.currentDayStart

Error I got is
AttributeError: Class 'MonthView' has no attribute 'currentDayStart'.

I talked with balloons and om26er and they will be trying to resolve the bug, but untill that is resolved, I am not able to create any meaning full test for this feature.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:51
http://91.189.93.125:8080/job/ubuntu-calendar-app-ci/37/
Executed test runs:
    SUCCESS: http://91.189.93.125:8080/job/ubuntu-calendar-app-quantal-amd64-ci/22
    SUCCESS: http://91.189.93.125:8080/job/ubuntu-calendar-app-raring-amd64-ci/37

Click here to trigger a rebuild:
http://91.189.93.125:8080/job/ubuntu-calendar-app-ci/37/rebuild

review: Approve (continuous-integration)

[Nicholas Skaggs (nskaggs)]

The bug is opened here: https://bugs.launchpad.net/autopilot-qt/+bug/1193397

[Michael Zanetti (mzanetti)]

80 + start_x = month_view.x + month_view.width * 0.85
81 + stop_x = month_view.x + month_view.width * 0.15

This fails on screens with different resolutions because the mouse tries to move to a half pixel which it can't and gets stuck trying. Needs to be truncated/rounded to be an integer.

review: Needs Fixing

[Michael Zanetti (mzanetti)]

> There is some bug with AutoPilot system, which prevent testcase from getting
> any object property from QML.
> like
> readonly property var currentDayStart: intern.currentDayStart
>
> Error I got is
> AttributeError: Class 'MonthView' has no attribute 'currentDayStart'.
>
> I talked with balloons and om26er and they will be trying to resolve the bug,
> but untill that is resolved, I am not able to create any meaning full test for
> this feature.

Well, its not really a bug. More like a limitation because we are mixing C++ and python through a D-Bus interface and there is no straigt forward conversion between a QDateTime, through an integer and then to a python datetime. I'm exploring into solution for this though, maybe we can prefix it somehow internally to make python-autopilot recognize it as a datetime and automaticaly convert it.

Anyways, to still write some tests in the meantime you can use things like this:

QtObject {
  id: intern
  property monthStart: monthView.monthStart.valueOf()
}

That would give you a monthStart property containing an integer (unix timestamp) which you can convert back to a datetime object in python.

[Michael Zanetti (mzanetti)]

Please try this autopilot-qt branch. That should allow you to introspect your Date properties:

lp:~mzanetti/autopilot-qt/add-date-time-introspection

In the autopilot test, you will get Date as an integer (seconds since 1970-01-01T00:00:00). You can convert them back to a datetime object in python by using for example

time.ctime(self.main_window.get_month_view().monthStart)

Please let me know how it works.

[Omer Akram (om26er)]

I tried your branch and seems now currentDayStart is indeed being exposed.

[Kunal Parmar (pkunal-parmar)]

> Please try this autopilot-qt branch. That should allow you to introspect your
> Date properties:
>
> lp:~mzanetti/autopilot-qt/add-date-time-introspection
>
> In the autopilot test, you will get Date as an integer (seconds since
> 1970-01-01T00:00:00). You can convert them back to a datetime object in python
> by using for example
>
> time.ctime(self.main_window.get_month_view().monthStart)
>
> Please let me know how it works.

Hi, Thanks for support, I will check and update test case accordingly.

[Kunal Parmar (pkunal-parmar)]

> > Please try this autopilot-qt branch. That should allow you to introspect
> your
> > Date properties:
> >
> > lp:~mzanetti/autopilot-qt/add-date-time-introspection
> >
> > In the autopilot test, you will get Date as an integer (seconds since
> > 1970-01-01T00:00:00). You can convert them back to a datetime object in
> python
> > by using for example
> >
> > time.ctime(self.main_window.get_month_view().monthStart)
> >
> > Please let me know how it works.
>
> Hi, Thanks for support, I will check and update test case accordingly.

Hi, I checked the autopilot fix, and it works great. Thanks :)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:53
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/43/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-ci/43
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/43

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/43/rebuild

review: Approve (continuous-integration)

[Olivier Tilloy (osomon)]

The functionality seems to work nicely now, good job!
However the autopilot tests are failing with the following error:

    AttributeError: Class 'MonthView' has no attribute 'currentDayStart'.

This is the issue discussed above, but we cannot merge as is before the fix lands in autopilot-qt.
In order to get the functionality merged ASAP, one thing you could do is skip temporarily the tests, and re-enable them once the fix lands in autopilot-qt. You can skip a specific test method by decorating it like this:

    @unittest.skip("message to explain why we are skipping this test")
    def test_monthview_today_next_month(self):
        …

[Olivier Tilloy (osomon)]

Some general remarks on the newly added autopilot tests:

 - it would be good to split them into a separate python file, so that each file contains a set of related tests (autopilot takes care of discovering all the tests even if they are spread over several files)

 - in changeMonth(…), I’d rather make direction an integer (with value=-1 for previous month, and 1 for next month), or rename the boolean to 'goToNextMonth' or something like that, that will make the code easier to understand
   as a bonus, if you use an integer, you won’t need conditional code to compute start_x and stop_x, just use the value as a multiplier

 - in changeMonth(…), "y_line = month_view.y + 300" this won’t work on all devices, you should probably do something like that:
        y_line = int(month_view.y + month_view.height / 2)

[Michael Zanetti (mzanetti)]

> The functionality seems to work nicely now, good job!
> However the autopilot tests are failing with the following error:
>
> AttributeError: Class 'MonthView' has no attribute 'currentDayStart'.
>
> This is the issue discussed above, but we cannot merge as is before the fix
> lands in autopilot-qt.
> In order to get the functionality merged ASAP, one thing you could do is skip
> temporarily the tests, and re-enable them once the fix lands in autopilot-qt.
> You can skip a specific test method by decorating it like this:
>
> @unittest.skip("message to explain why we are skipping this test")
> def test_monthview_today_next_month(self):
> …

The fixed autopilot version should appear in saucy repositories tomorrow.

[Olivier Tilloy (osomon)]

> The fixed autopilot version should appear in saucy repositories tomorrow.

Oh, that’s great news! In that case, Kunal please forget about my suggestion to skip the tests. However please consider my second comment to improve the implementation of the tests.

[Kunal Parmar (pkunal-parmar)]

> > The fixed autopilot version should appear in saucy repositories tomorrow.
>
> Oh, that’s great news! In that case, Kunal please forget about my suggestion
> to skip the tests. However please consider my second comment to improve the
> implementation of the tests.

Sure, Thanks

[Kunal Parmar (pkunal-parmar)]

> Some general remarks on the newly added autopilot tests:
>
> - it would be good to split them into a separate python file, so that each
> file contains a set of related tests (autopilot takes care of discovering all
> the tests even if they are spread over several files)
>
> - in changeMonth(…), I’d rather make direction an integer (with value=-1 for
> previous month, and 1 for next month), or rename the boolean to
> 'goToNextMonth' or something like that, that will make the code easier to
> understand
> as a bonus, if you use an integer, you won’t need conditional code to
> compute start_x and stop_x, just use the value as a multiplier
>
> - in changeMonth(…), "y_line = month_view.y + 300" this won’t work on all
> devices, you should probably do something like that:
> y_line = int(month_view.y + month_view.height / 2)

addressed above comment

review: Needs Resubmitting

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:56
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/48/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-ci/48
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/48

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/48/rebuild

review: Needs Fixing (continuous-integration)

[Olivier Tilloy (osomon)]

> - in changeMonth(…), I’d rather make direction an integer (with value=-1 for
> previous month, and 1 for next month), or rename the boolean to
> 'goToNextMonth' or something like that, that will make the code easier to
> understand
> as a bonus, if you use an integer, you won’t need conditional code to
> compute start_x and stop_x, just use the value as a multiplier

You added a comment "direction 1 for next month, -1 for previous month", but then the parameter remains a boolean (and was renamed goToNextMonth). This is confusing, could you please clarify?

[Olivier Tilloy (osomon)]

In changeMonth, why does the value of count defaults to -1? Wouldn’t it be easier to default to 0? You wouldn’t need any special handling of the value, as range(0, 0) generates an empty list.

[Olivier Tilloy (osomon)]

Python nitpick: no need for range(0, count): range(count) is enough.

[Olivier Tilloy (osomon)]

In changeMonth, the multipliers used for the swipe gesture are not symmetrical (should be 0.15 and 0.85, or 0.25 and 0.75), is that on purpose?

[Kunal Parmar (pkunal-parmar)]

> In changeMonth, the multipliers used for the swipe gesture are not symmetrical
> (should be 0.15 and 0.85, or 0.25 and 0.75), is that on purpose?

I see consistent value in both IF ELSE, can you explain what you are suggesting?

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:57
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/49/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-ci/49
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/49

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/49/rebuild

review: Needs Fixing (continuous-integration)

[Olivier Tilloy (osomon)]

> > In changeMonth, the multipliers used for the swipe gesture are not
> symmetrical
> > (should be 0.15 and 0.85, or 0.25 and 0.75), is that on purpose?
>
> I see consistent value in both IF ELSE, can you explain what you are
> suggesting?

Yes, the values are consistent, but they are not symmetrical. The center of the view being at (month_view.x + month_view.width * 0.5), it feels incorrect that the start position and the stop position of the swipe gesture are not symmetrical relative to the center:

    >>> abs(0.5 - 0.85)
    0.35
    >>> abs(0.5 - 0.25)
    0.25

[Olivier Tilloy (osomon)]

You could simplify the code further by completely getting rid of the 'goToNextMonth' parameter, using the sign of 'count' as a multiplier (to get the sign of count, just use cmp(count, 0)).

That’s only a suggestion though, feel free to ignore.

[Kunal Parmar (pkunal-parmar)]

> > > In changeMonth, the multipliers used for the swipe gesture are not
> > symmetrical
> > > (should be 0.15 and 0.85, or 0.25 and 0.75), is that on purpose?
> >
> > I see consistent value in both IF ELSE, can you explain what you are
> > suggesting?
>
> Yes, the values are consistent, but they are not symmetrical. The center of
> the view being at (month_view.x + month_view.width * 0.5), it feels incorrect
> that the start position and the stop position of the swipe gesture are not
> symmetrical relative to the center:
>
> >>> abs(0.5 - 0.85)
> 0.35
> >>> abs(0.5 - 0.25)
> 0.25

ok, I understand it now. Changed the values now and made it symmetrical.

[Kunal Parmar (pkunal-parmar)]

> You could simplify the code further by completely getting rid of the
> 'goToNextMonth' parameter, using the sign of 'count' as a multiplier (to get
> the sign of count, just use cmp(count, 0)).
>
> That’s only a suggestion though, feel free to ignore.

This i will try some other time

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:58
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/50/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-ci/50
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/50

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/50/rebuild

review: Needs Fixing (continuous-integration)

[Olivier Tilloy (osomon)]

Due to the latest changes in trunk, there are now conflicts when merging this branch. Can you please resolve them (by merging trunk back into your branch)?

[Kunal Parmar (pkunal-parmar)]

> Due to the latest changes in trunk, there are now conflicts when merging this
> branch. Can you please resolve them (by merging trunk back into your branch)?
Yes, I also realized that I need to get latest code from trunk. I will update code and notify you

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:60
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/53/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests/95
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-ci/2
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-ci/53
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/53
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/2

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/53/rebuild

review: Needs Fixing (continuous-integration)

[Kunal Parmar (pkunal-parmar)]

Hi Olivier,

I resolved the merge conflict and also made some other related changes.

But "UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests/95" jenkins is still complaining, with AttributeError: Class 'MonthView' has no attribute 'currentDayStart' error.

Do i need to do anything for this ?

review: Needs Resubmitting

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:61
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/54/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests/96
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-ci/3
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-ci/54
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/54
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/3

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/54/rebuild

review: Needs Fixing (continuous-integration)

[Olivier Tilloy (osomon)]

In changeMonth(…), instead of adding self.ubuntusdk.get_qml_view().x and self.ubuntusdk.get_qml_view().y to all the coordinates, you should do something like that:

    x, y, w, h = self.main_window.get_month_view().globalRect
    y_line = int(y + h / 2)
    …
    start_x = int(x + w * 0.85)
    …

review: Needs Fixing

[Olivier Tilloy (osomon)]

43 +// TODO: Following function is causing regression in monthview
44 +// It is affecting month view's layout and default date is select
45 +// Temporarily reverting changes
46 +//Date.prototype.midnight = function() {
47 +// var date = new Date(this)
48 +// date.setHours(0,0,0,0);
49 +// return date
50 +//}

You can’t just revert the function to its previous implementation, as it was buggy.
What regression exactly is it causing? Can’t it be addressed properly?

review: Needs Fixing

[Olivier Tilloy (osomon)]

> Hi Olivier,
>
> I resolved the merge conflict and also made some other related changes.
>
> But "UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests/95" jenkins
> is still complaining, with AttributeError: Class 'MonthView' has no attribute
> 'currentDayStart' error.
>
> Do i need to do anything for this ?

I’m guessing that the latest version of autopilot-qt is not installed on the builder. Not much you can do about it, try pinging mzanetti on IRC.

[Kunal Parmar (pkunal-parmar)]

> 43 +// TODO: Following function is causing regression in monthview
> 44 +// It is affecting month view's layout and default date is select
> 45 +// Temporarily reverting changes
> 46 +//Date.prototype.midnight = function() {
> 47 +// var date = new Date(this)
> 48 +// date.setHours(0,0,0,0);
> 49 +// return date
> 50 +//}
>
> You can’t just revert the function to its previous implementation, as it was
> buggy.
> What regression exactly is it causing? Can’t it be addressed properly?

That will need some time.

but the commented out code is affecting monthview's algorithm to calculate num of days and first day of month and like wise.

So in this case, person who made fixed should have make necessary changes in MonthView as well or should have left code as it is.

Following is snaps of problem
http://ubuntuone.com/7O0UlY3RAT4wvSxOctDpq4
http://ubuntuone.com/3CWSpaxJ15IynbOIACPJ6V
http://ubuntuone.com/5DVRYl8nhT8xuWc6n3nrXw

This is affecting my test case as well, as I am not able to check if month is changed or not after swiping.
As now sometimes after changing month start date is coming as 31 instead of 1.

[Olivier Tilloy (osomon)]

> > Hi Olivier,
> >
> > I resolved the merge conflict and also made some other related changes.
> >
> > But "UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests/95" jenkins
> > is still complaining, with AttributeError: Class 'MonthView' has no
> attribute
> > 'currentDayStart' error.
> >
> > Do i need to do anything for this ?
>
> I’m guessing that the latest version of autopilot-qt is not installed on the
> builder. Not much you can do about it, try pinging mzanetti on IRC.

I’ve had a look at the logs of the CI run (http://91.189.93.70:8080/job/generic-mediumtests/96/console), and it appears the job is running on raring, and autopilot-qt must be pre-installed on the builder because it doesn’t appear anywhere in the logs. Which would explain why it’s not picking up the latest version that your branch requires.

[Olivier Tilloy (osomon)]

> > 43 +// TODO: Following function is causing regression in monthview
> > 44 +// It is affecting month view's layout and default date is select
> > 45 +// Temporarily reverting changes
> > 46 +//Date.prototype.midnight = function() {
> > 47 +// var date = new Date(this)
> > 48 +// date.setHours(0,0,0,0);
> > 49 +// return date
> > 50 +//}
> >
> > You can’t just revert the function to its previous implementation, as it was
> > buggy.
> > What regression exactly is it causing? Can’t it be addressed properly?
>
> That will need some time.
>
> but the commented out code is affecting monthview's algorithm to calculate num
> of days and first day of month and like wise.
>
> So in this case, person who made fixed should have make necessary changes in
> MonthView as well or should have left code as it is.
>
> Following is snaps of problem
> http://ubuntuone.com/7O0UlY3RAT4wvSxOctDpq4
> http://ubuntuone.com/3CWSpaxJ15IynbOIACPJ6V
> http://ubuntuone.com/5DVRYl8nhT8xuWc6n3nrXw

Ah, got it, I’m now seeing the issue. In fact it exists in the latest trunk, so it should be fixed there, not worked around in your branch. I filed bug #1202366 to track the issue, I’m gonna look into it right away.

[Olivier Tilloy (osomon)]

> > > 43 +// TODO: Following function is causing regression in monthview
> > > 44 +// It is affecting month view's layout and default date is select
> > > 45 +// Temporarily reverting changes
> > > 46 +//Date.prototype.midnight = function() {
> > > 47 +// var date = new Date(this)
> > > 48 +// date.setHours(0,0,0,0);
> > > 49 +// return date
> > > 50 +//}
> > >
> > > You can’t just revert the function to its previous implementation, as it
> was
> > > buggy.
> > > What regression exactly is it causing? Can’t it be addressed properly?
> >
> > That will need some time.
> >
> > but the commented out code is affecting monthview's algorithm to calculate
> num
> > of days and first day of month and like wise.
> >
> > So in this case, person who made fixed should have make necessary changes in
> > MonthView as well or should have left code as it is.
> >
> > Following is snaps of problem
> > http://ubuntuone.com/7O0UlY3RAT4wvSxOctDpq4
> > http://ubuntuone.com/3CWSpaxJ15IynbOIACPJ6V
> > http://ubuntuone.com/5DVRYl8nhT8xuWc6n3nrXw
>
> Ah, got it, I’m now seeing the issue. In fact it exists in the latest trunk,
> so it should be fixed there, not worked around in your branch. I filed bug
> #1202366 to track the issue, I’m gonna look into it right away.

Fixed by https://code.launchpad.net/~osomon/ubuntu-calendar-app/all-dates-local/+merge/175398.
Please review, so that we can merge it prior to your branch (and once it’s done, revert your changes to the midnight() function).

[Michael Zanetti (mzanetti)]

> I’m guessing that the latest version of autopilot-qt is not installed on the
> builder. Not much you can do about it, try pinging mzanetti on IRC.

Not sure who exactly maintains the community app jenkins jobs. I think fginther should be able to help in keeping them up to date.

> I’ve had a look at the logs of the CI run (http://91.189.93.70:8080/job/generic-mediumtests/96/console), and it
> appears the job is running on raring, and autopilot-qt must be pre-installed on the builder because it doesn’t
> appear anywhere in the logs. Which would explain why it’s not picking up the latest version that your branch
> requires.

I guess you could also depend on libautopilot-qt >= 1.3daily13.06.25. Not sure if that's a good thing with the daily releases tho... Maybe I should have bumped the version manually when adding a feature. Anyways, I think the builders should be on Saucy anyways by now? Please ask fginther about that too.

[David Planella (dpm)]

Al 18/07/13 14:53, En/na Michael Zanetti ha escrit:
>> I’m guessing that the latest version of autopilot-qt is not installed on the
>> builder. Not much you can do about it, try pinging mzanetti on IRC.
>
> Not sure who exactly maintains the community app jenkins jobs. I think fginther should be able to help in keeping them up to date.
>

Yep, Francis is the maintainer, so he's the best person to ping.

[Kunal Parmar (pkunal-parmar)]

> > > > 43 +// TODO: Following function is causing regression in monthview
> > > > 44 +// It is affecting month view's layout and default date is
> select
> > > > 45 +// Temporarily reverting changes
> > > > 46 +//Date.prototype.midnight = function() {
> > > > 47 +// var date = new Date(this)
> > > > 48 +// date.setHours(0,0,0,0);
> > > > 49 +// return date
> > > > 50 +//}
> > > >
> > > > You can’t just revert the function to its previous implementation, as it
> > was
> > > > buggy.
> > > > What regression exactly is it causing? Can’t it be addressed properly?
> > >
> > > That will need some time.
> > >
> > > but the commented out code is affecting monthview's algorithm to calculate
> > num
> > > of days and first day of month and like wise.
> > >
> > > So in this case, person who made fixed should have make necessary changes
> in
> > > MonthView as well or should have left code as it is.
> > >
> > > Following is snaps of problem
> > > http://ubuntuone.com/7O0UlY3RAT4wvSxOctDpq4
> > > http://ubuntuone.com/3CWSpaxJ15IynbOIACPJ6V
> > > http://ubuntuone.com/5DVRYl8nhT8xuWc6n3nrXw
> >
> > Ah, got it, I’m now seeing the issue. In fact it exists in the latest trunk,
> > so it should be fixed there, not worked around in your branch. I filed bug
> > #1202366 to track the issue, I’m gonna look into it right away.
>
> Fixed by https://code.launchpad.net/~osomon/ubuntu-calendar-app/all-dates-
> local/+merge/175398.
> Please review, so that we can merge it prior to your branch (and once it’s
> done, revert your changes to the midnight() function).

Hi, Thanks for fix, I reverted my changes and my test case are working fine now with fix.
Let me know if anything else is required,

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:64
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/57/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests/111/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-ci/6/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-ci/57/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/57/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/6/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/57/rebuild

review: Needs Fixing (continuous-integration)

[Olivier Tilloy (osomon)]

It’s unclear to me whether the CI fails because of this or for another reason, but the logs report a number of errors and warnings when running pep8 on the python code (the autopilot tests). Can you please run it locally, ensure you fix all the errors and warnings reported, and push an update?

[Kunal Parmar (pkunal-parmar)]

> It’s unclear to me whether the CI fails because of this or for another reason,
> but the logs report a number of errors and warnings when running pep8 on the
> python code (the autopilot tests). Can you please run it locally, ensure you
> fix all the errors and warnings reported, and push an update?

ran pep8 locally and make changes accordingly, I hope it works

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:65
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/61/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests/121/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-ci/10/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-ci/61/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/61/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/10/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/61/rebuild

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:66
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/62/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests/122/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-ci/11/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-ci/62/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/62/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/11/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/62/rebuild

review: Needs Fixing (continuous-integration)

[Olivier Tilloy (osomon)]

There’s a remaining pyflake warning that needs addressing:

./tests/autopilot/calendar_app/tests/test_monthview.py:17: 'time' imported but unused

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:67
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/65/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests/131
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-ci/14
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-ci/65
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/65
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/14

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/65/rebuild

review: Needs Fixing (continuous-integration)

[Francis Ginther (fginther)]

Found an issue with the PPA that supplies libautopilot-qt. It was missing the most recent updates. I've pushed over the new packages and should have this restarted shortly.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:67
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/66/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests/133
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-ci/15
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-ci/66
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/66
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/15

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/66/rebuild

review: Approve (continuous-integration)

[Olivier Tilloy (osomon)]

165 + if goToNextMonth is True:
166 + self.assertThat(dayAfterMonthChange.month,
167 + (Equals(startDay.month + count)))
168 + else:
169 + self.assertThat(dayAfterMonthChange.month,
170 + (Equals(startDay.month - count)))

This currently works because we’re in July, but when you run the tests in December they’re gonna start failing because 12 + n > 12 (for n being an integer > 0).
If you want to see it for yourself without changing your current date, add the following test:

    def test_monthview_change_month_fail(self):
        self.test_monthview_change_month(True, 9)

review: Needs Fixing

[Olivier Tilloy (osomon)]

test_monthview_today(…) and test_monthview_change_month(…) need to be renamed (remove the "test_" prefix) so that autopilot doesn’t consider them standalone test methods.

review: Needs Fixing

[Olivier Tilloy (osomon)]

119 + self.ubuntusdk.click_toolbar_button("Today")

153 + self.ubuntusdk.click_toolbar_button("Today")

Those shouldn’t be needed, as when the application starts the selected day is today by default, right?

review: Needs Information

[Kunal Parmar (pkunal-parmar)]

> 119 + self.ubuntusdk.click_toolbar_button("Today")
>
> 153 + self.ubuntusdk.click_toolbar_button("Today")
>
> Those shouldn’t be needed, as when the application starts the selected day is
> today by default, right?

When application starts then default date is today, but does autopilot start application for each test case or it reuses the application ?

[Kunal Parmar (pkunal-parmar)]

> 165 + if goToNextMonth is True:
> 166 + self.assertThat(dayAfterMonthChange.month,
> 167 + (Equals(startDay.month + count)))
> 168 + else:
> 169 + self.assertThat(dayAfterMonthChange.month,
> 170 + (Equals(startDay.month - count)))
>
> This currently works because we’re in July, but when you run the tests in
> December they’re gonna start failing because 12 + n > 12 (for n being an
> integer > 0).
> If you want to see it for yourself without changing your current date, add the
> following test:
>
> def test_monthview_change_month_fail(self):
> self.test_monthview_change_month(True, 9)

ok, not only month it also affect year, I fixed that as well. Now I am not trying to calculate month by arithmetic but by using python-dateutil.

testDate = startDay + relativedelta( months = +count )

I added dependency for python-dateutil under Package: calendar-app-autopilot, is that correct ?

I also added dependency

[Kunal Parmar (pkunal-parmar)]

> test_monthview_today(…) and test_monthview_change_month(…) need to be renamed
> (remove the "test_" prefix) so that autopilot doesn’t consider them standalone
> test methods.

removed prefix

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:71
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/69/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests/150/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-ci/18/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-ci/69/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/69/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/18/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/69/rebuild

review: Needs Fixing (continuous-integration)

[Olivier Tilloy (osomon)]

> > 119 + self.ubuntusdk.click_toolbar_button("Today")
> >
> > 153 + self.ubuntusdk.click_toolbar_button("Today")
> >
> > Those shouldn’t be needed, as when the application starts the selected day
> is
> > today by default, right?
>
> When application starts then default date is today, but does autopilot start
> application for each test case or it reuses the application ?

Yes, autopilot starts the application afresh for each test case, so it is safe to assume the initial state is clean.

[Olivier Tilloy (osomon)]

> > 165 + if goToNextMonth is True:
> > 166 + self.assertThat(dayAfterMonthChange.month,
> > 167 + (Equals(startDay.month + count)))
> > 168 + else:
> > 169 + self.assertThat(dayAfterMonthChange.month,
> > 170 + (Equals(startDay.month - count)))
> >
> > This currently works because we’re in July, but when you run the tests in
> > December they’re gonna start failing because 12 + n > 12 (for n being an
> > integer > 0).
> > If you want to see it for yourself without changing your current date, add
> the
> > following test:
> >
> > def test_monthview_change_month_fail(self):
> > self.test_monthview_change_month(True, 9)
>
> ok, not only month it also affect year, I fixed that as well. Now I am not
> trying to calculate month by arithmetic but by using python-dateutil.
>
> testDate = startDay + relativedelta( months = +count )
>
> I added dependency for python-dateutil under Package: calendar-app-autopilot,
> is that correct ?
>
> I also added dependency

Yes, that’s correct.

[Olivier Tilloy (osomon)]

144 + self.assertThat(dayAfterMonthChange.day, (Equals(startDay.day)))
145 + self.assertThat(dayAfterMonthChange.month, (Equals(startDay.month)))
146 + self.assertThat(dayAfterMonthChange.year, (Equals(startDay.year)))

There are extra parentheses around the Equals statements that can be safely removed.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:73
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/70/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests/151
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-ci/19
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-ci/70
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/70
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/19

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/70/rebuild

review: Approve (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:74
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/71/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests/152
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-ci/20
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-ci/71
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/71
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/20

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/71/rebuild

review: Approve (continuous-integration)

[Olivier Tilloy (osomon)]

Looks good now, thanks!

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/12/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests/157/console
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-autolanding/7
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-autolanding/11
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-autolanding/11
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-autolanding/7

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/13/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests/158/console
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-autolanding/8
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-autolanding/12
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-autolanding/12
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-autolanding/8

review: Needs Fixing (continuous-integration)

[Olivier Tilloy (osomon)]

Looks like the builder is out of space:

    dpkg-source: error: cannot create directory calendar-app-0.4: No space left on device

I’ll ping an admin to get this resolved.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/14/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests/160/console
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-autolanding/9
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-autolanding/13
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-autolanding/13
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-autolanding/9

review: Needs Fixing (continuous-integration)

[Francis Ginther (fginther)]

The generic-mediumtests issue has been resolved. reapproving.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

review: Approve (continuous-integration)

=== modified file 'MonthView.qml'
--- MonthView.qml	2013-07-10 10:07:59 +0000
+++ MonthView.qml	2013-07-23 16:09:23 +0000
@@ -82,6 +82,12 @@
         else intern.currentDayStart = dayStart
     }
 
+    function goToToday() {
+        var today = (new Date()).midnight();
+        intern.currentDayStart = today
+        currentIndex= intern.monthIndex0
+    }
+
     focus: true
     Keys.onLeftPressed: decrementCurrentDay()
     Keys.onRightPressed: incrementCurrentDay()

=== modified file 'calendar.qml'
--- calendar.qml	2013-07-12 16:38:49 +0000
+++ calendar.qml	2013-07-23 16:09:23 +0000
@@ -52,6 +52,13 @@
                     }
                 }
                 Action {
+                    iconSource: Qt.resolvedUrl("avatar.png");
+                    text: i18n.tr("Today");
+                    onTriggered: {
+                        monthView.goToToday();
+                    }
+                }
+                Action {
                     iconSource: Qt.resolvedUrl("avatar.png")
                     text: i18n.tr("Year view")
                     onTriggered: pageStack.push(yearView);

=== modified file 'debian/control'
--- debian/control	2013-06-17 11:22:34 +0000
+++ debian/control	2013-07-23 16:09:23 +0000
@@ -28,6 +28,7 @@
 Depends: libautopilot-qt,
          libqt5test5,
          calendar-app (= ${source:Version}),
+         python-dateutil,
 Description: Autopilot tests for Ubuntu Calendar Application
  This package contains autopilot tests for the Ubuntu Calendar application.
 

=== modified file 'tests/autopilot/calendar_app/emulators/main_window.py'
--- tests/autopilot/calendar_app/emulators/main_window.py	2013-07-12 16:38:49 +0000
+++ tests/autopilot/calendar_app/emulators/main_window.py	2013-07-23 16:09:23 +0000
@@ -18,3 +18,6 @@
 
     def get_event_view(self):
         return self.app.select_single("EventView")
+
+    def get_month_view(self):
+        return self.app.select_single("MonthView")

=== added file 'tests/autopilot/calendar_app/tests/test_monthview.py'
--- tests/autopilot/calendar_app/tests/test_monthview.py	1970-01-01 00:00:00 +0000
+++ tests/autopilot/calendar_app/tests/test_monthview.py	2013-07-23 16:09:23 +0000
@@ -0,0 +1,121 @@
+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
+# Copyright 2013 Canonical
+#
+# This program is free software: you can redistribute it and/or modify it
+# under the terms of the GNU General Public License version 3, as published
+# by the Free Software Foundation.
+
+"""Calendar app autopilot tests."""
+
+from __future__ import absolute_import
+
+from autopilot.matchers import Eventually
+from testtools.matchers import Equals
+
+from calendar_app.tests import CalendarTestCase
+
+from datetime import datetime
+from dateutil.relativedelta import relativedelta
+
+
+class TestMainWindow(CalendarTestCase):
+
+    def setUp(self):
+        super(TestMainWindow, self).setUp()
+        self.assertThat(
+            self.ubuntusdk.get_qml_view().visible, Eventually(Equals(True)))
+
+    def tearDown(self):
+        super(TestMainWindow, self).tearDown()
+
+    # goToNextMonth True for next month, False for previous month
+    def changeMonth(self, goToNextMonth=True, count=0):
+
+        month_view = self.main_window.get_month_view()
+        y_line = int(self.ubuntusdk.get_qml_view().y
+                     + month_view.y + (month_view.height / 2))
+
+        for i in range(count):
+            if goToNextMonth is True:
+                start_x = int(self.ubuntusdk.get_qml_view().x
+                              + month_view.x + (month_view.width * 0.85))
+                stop_x = int(self.ubuntusdk.get_qml_view().x
+                             + month_view.x + (month_view.width * 0.15))
+            else:
+                start_x = int(self.ubuntusdk.get_qml_view().x
+                              + month_view.x + (month_view.width * 0.15))
+                stop_x = int(self.ubuntusdk.get_qml_view().x
+                             + month_view.x + (month_view.width * 0.85))
+
+            self.pointing_device.drag(start_x, y_line, stop_x, y_line)
+
+    def test_monthview_today_next_month(self):
+        self.monthview_today(True, 1)
+
+    def test_monthview_today_prev_month(self):
+        self.monthview_today(False, 1)
+
+    def test_monthview_today_next_month_multi(self):
+        self.monthview_today(True, 12)
+
+    def test_monthview_today_prev_month_multi(self):
+        self.monthview_today(False, 12)
+
+    # goToNextMonth True for next month, False for previous month
+    def monthview_today(self, goToNextMonth=True, count=-1):
+
+        if count == -1:
+            return
+
+        month_view = self.main_window.get_month_view()
+
+        startDay = datetime.fromtimestamp(month_view.currentDayStart)
+
+        self.changeMonth(goToNextMonth, count)
+
+        self.ubuntusdk.click_toolbar_button("Today")
+        dayAfterMonthChange = datetime.fromtimestamp(month_view
+                                                     .currentDayStart)
+
+        self.assertThat(dayAfterMonthChange.day, Equals(startDay.day))
+        self.assertThat(dayAfterMonthChange.month, Equals(startDay.month))
+        self.assertThat(dayAfterMonthChange.year, Equals(startDay.year))
+
+    def test_monthview_change_month_next(self):
+        self.monthview_change_month(True, 1)
+
+    def test_monthview_change_month_next_multiple(self):
+        self.monthview_change_month(True, 3)
+
+    def test_monthview_change_month_prev(self):
+        self.monthview_change_month(False, 1)
+
+    def test_monthview_change_month_prev_multiple(self):
+        self.monthview_change_month(False, 3)
+
+    # goToNextMonth True for next month, False for previous month
+    def monthview_change_month(self, goToNextMonth=True, count=-1):
+
+        if count == -1:
+            return
+
+        month_view = self.main_window.get_month_view()
+
+        startDay = datetime.fromtimestamp(month_view.currentDayStart)
+
+        self.changeMonth(goToNextMonth, count)
+
+        dayAfterMonthChange = datetime.fromtimestamp(month_view
+                                                     .currentDayStart)
+
+        self.assertThat(dayAfterMonthChange.day, Equals(1))
+        if goToNextMonth is True:
+            testDate = startDay + relativedelta(months=+count)
+            self.assertThat(dayAfterMonthChange.month,
+                            Equals(testDate.month))
+            self.assertThat(dayAfterMonthChange.year, Equals(testDate.year))
+        else:
+            testDate = startDay + relativedelta(months=-count)
+            self.assertThat(dayAfterMonthChange.month,
+                            Equals(testDate.month))
+            self.assertThat(dayAfterMonthChange.year, Equals(testDate.year))