Code review comment for lp:~pkunal-parmar/ubuntu-calendar-app/today

Revision history for this message
Olivier Tilloy (osomon) wrote :

> > In changeMonth, the multipliers used for the swipe gesture are not
> symmetrical
> > (should be 0.15 and 0.85, or 0.25 and 0.75), is that on purpose?
>
> I see consistent value in both IF ELSE, can you explain what you are
> suggesting?

Yes, the values are consistent, but they are not symmetrical. The center of the view being at (month_view.x + month_view.width * 0.5), it feels incorrect that the start position and the stop position of the swipe gesture are not symmetrical relative to the center:

    >>> abs(0.5 - 0.85)
    0.35
    >>> abs(0.5 - 0.25)
    0.25

« Back to merge proposal