Code review comment for lp:~pkunal-parmar/ubuntu-calendar-app/today
Revision history for this message
| Kunal Parmar (pkunal-parmar) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
> This doesn’t work if I’m looking at the same month next year (e.g. swipe left
> 12 times to browse to June 2014, and then click the Today button).
>
> As a side note, this is typically the functionality that would greatly benefit
> from an associated autopilot test, do you think you could add one (that would
> cover the normal use cases as well as the "corner" cases like the one I’ve
> described above). If you need help writing autopilot tests, do not hesitate to
> ask Omer Akram (om26er on IRC) or myself. Cheers!
Ahh, I never tested that test case, thought from code it was quite evident that it will not work for same month.
I fixed this, but I am yet to implement test case for it. Yes, I agree that test case will help greatly.
I checked code and looks like, current month view implementation does not allow user to browse more then 24 month in one direction. I guess we will need to make changes to allow browse as much as user wanted, and we will need test case that time.