Merge lp:~pitti/ubufox/default-homepage-override into lp:ubufox

Proposed by Martin Pitt
Status: Merged
Merged at revision: 237
Proposed branch: lp:~pitti/ubufox/default-homepage-override
Merge into: lp:ubufox
Diff against target: 18 lines (+7/-1)
1 file modified
components/aboutStartpage.js (+7/-1)
To merge this branch: bzr merge lp:~pitti/ubufox/default-homepage-override
Reviewer Review Type Date Requested Status
Chris Coulson Approve
Review via email: mp+63121@code.launchpad.net

Description of the change

Allow defaults packages to set their own homepage in distribution.ini

To post a comment you must log in.
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Thanks, will merge this now

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'components/aboutStartpage.js'
--- components/aboutStartpage.js 2011-04-08 18:50:30 +0000
+++ components/aboutStartpage.js 2011-06-01 14:31:07 +0000
@@ -123,7 +123,13 @@
123 if (!getIsOffline()) {123 if (!getIsOffline()) {
124 let searchEngineName = getCurrentSearchEngineName();124 let searchEngineName = getCurrentSearchEngineName();
125 let release = Services.prefs.getCharPref("extensions.ubufox@ubuntu.com.release");125 let release = Services.prefs.getCharPref("extensions.ubufox@ubuntu.com.release");
126 let uri = HOMEPAGE_ONLINE_PREFIX + release + "/" + searchEngineName + "/";126 var uri;
127 // allow defaults packages to overwrite the homepage
128 try {
129 uri = Services.prefs.getCharPref("extensions.ubufox@ubuntu.com.custom_homepage");
130 } catch(e) {
131 uri = HOMEPAGE_ONLINE_PREFIX + release + "/" + searchEngineName + "/";
132 }
127 let channel = ios.newChannel(uri, null, null);133 let channel = ios.newChannel(uri, null, null);
128 channel.originalURI = aURI;134 channel.originalURI = aURI;
129 channel.owner = principal;135 channel.owner = principal;

Subscribers

People subscribed via source and target branches