Code review comment for lp:~pieq/checkbox/fix-1561821-new-input_id-parameter-for-input-jobs

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

The idea was good but...

I see two problems:

1 - It increases the amount of data generated from the udev resource job as every input-like devices will get this additional field and we really need a fix for two input jobs.

2 - Adding the input kernel id to each job will give us two distinct jobs, one before unplugging the mouse and a second after re-plug and resuming/bootstrapping the session.

I diff'ed the two input jobs and what differs between both is indeed located in the job.parameters (the path property). To mitigate/work around the problem I'd would keep the change to the job definitions (in all cases they have to be updated) but rather modify how templates work to instantiate new units with only the parameters they need (i.e without the changing udev path).

See https://code.launchpad.net/~sylvain-pineau/checkbox/fix-1561821

review: Disapprove

« Back to merge proposal