Merge lp:~phill-ridout/openlp/foil_fixes into lp:openlp

Proposed by Phill
Status: Superseded
Proposed branch: lp:~phill-ridout/openlp/foil_fixes
Merge into: lp:openlp
Diff against target: 41 lines (+16/-8)
1 file modified
openlp/plugins/songs/lib/foilpresenterimport.py (+16/-8)
To merge this branch: bzr merge lp:~phill-ridout/openlp/foil_fixes
Reviewer Review Type Date Requested Status
Tim Bentley Needs Fixing
Review via email: mp+115000@code.launchpad.net

This proposal has been superseded by a proposal from 2012-07-15.

To post a comment you must log in.
Revision history for this message
Tim Bentley (trb143) wrote :

line 35 is a bit confusing ;-)

review: Needs Fixing
lp:~phill-ridout/openlp/foil_fixes updated
2035. By Phill

A real fix this time!

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'openlp/plugins/songs/lib/foilpresenterimport.py'
--- openlp/plugins/songs/lib/foilpresenterimport.py 2012-06-22 14:14:53 +0000
+++ openlp/plugins/songs/lib/foilpresenterimport.py 2012-07-15 08:06:19 +0000
@@ -483,8 +483,11 @@
483 # Process verse order483 # Process verse order
484 verse_order = []484 verse_order = []
485 verse_strophenr = []485 verse_strophenr = []
486 for strophennummer in foilpresenterfolie.reihenfolge.strophennummer:486 try:
487 verse_strophenr.append(strophennummer)487 for strophennummer in foilpresenterfolie.reihenfolge.strophennummer:
488 verse_strophenr.append(strophennummer)
489 except AttributeError:
490 pass
488 # Currently we do not support different "parts"!491 # Currently we do not support different "parts"!
489 if u'0' in temp_verse_order:492 if u'0' in temp_verse_order:
490 for vers in temp_verse_order_backup:493 for vers in temp_verse_order_backup:
@@ -538,12 +541,17 @@
538 ``song``541 ``song``
539 The song object.542 The song object.
540 """543 """
541 for title_string in foilpresenterfolie.titel.titelstring:544 try:
542 if not song.title:545 for title_string in foilpresenterfolie.titel.titelstring:
543 song.title = self._child(title_string)546 if not song.title:
544 song.alternate_title = u''547 song.title = self._child(title_string)
545 else:548 song.alternate_title = u''
546 song.alternate_title = self._child(title_string)549 else:
550 song.alternate_title = self._child(title_string)
551 except AttributeError:
552 # Use first line of first verse
553 first_line = self._child(foilpresenterfolie.strophen.strophe.text_)
554 song.title = first_line.split('\n')[0]
547555
548 def _process_topics(self, foilpresenterfolie, song):556 def _process_topics(self, foilpresenterfolie, song):
549 """557 """