Merge lp:~phill-ridout/openlp/foil_fixes into lp:openlp

Proposed by Phill
Status: Superseded
Proposed branch: lp:~phill-ridout/openlp/foil_fixes
Merge into: lp:openlp
Diff against target: 41 lines (+16/-8)
1 file modified
openlp/plugins/songs/lib/foilpresenterimport.py (+16/-8)
To merge this branch: bzr merge lp:~phill-ridout/openlp/foil_fixes
Reviewer Review Type Date Requested Status
Tim Bentley Needs Fixing
Review via email: mp+115000@code.launchpad.net

This proposal has been superseded by a proposal from 2012-07-15.

To post a comment you must log in.
Revision history for this message
Tim Bentley (trb143) wrote :

line 35 is a bit confusing ;-)

review: Needs Fixing
lp:~phill-ridout/openlp/foil_fixes updated
2035. By Phill

A real fix this time!

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openlp/plugins/songs/lib/foilpresenterimport.py'
2--- openlp/plugins/songs/lib/foilpresenterimport.py 2012-06-22 14:14:53 +0000
3+++ openlp/plugins/songs/lib/foilpresenterimport.py 2012-07-15 08:06:19 +0000
4@@ -483,8 +483,11 @@
5 # Process verse order
6 verse_order = []
7 verse_strophenr = []
8- for strophennummer in foilpresenterfolie.reihenfolge.strophennummer:
9- verse_strophenr.append(strophennummer)
10+ try:
11+ for strophennummer in foilpresenterfolie.reihenfolge.strophennummer:
12+ verse_strophenr.append(strophennummer)
13+ except AttributeError:
14+ pass
15 # Currently we do not support different "parts"!
16 if u'0' in temp_verse_order:
17 for vers in temp_verse_order_backup:
18@@ -538,12 +541,17 @@
19 ``song``
20 The song object.
21 """
22- for title_string in foilpresenterfolie.titel.titelstring:
23- if not song.title:
24- song.title = self._child(title_string)
25- song.alternate_title = u''
26- else:
27- song.alternate_title = self._child(title_string)
28+ try:
29+ for title_string in foilpresenterfolie.titel.titelstring:
30+ if not song.title:
31+ song.title = self._child(title_string)
32+ song.alternate_title = u''
33+ else:
34+ song.alternate_title = self._child(title_string)
35+ except AttributeError:
36+ # Use first line of first verse
37+ first_line = self._child(foilpresenterfolie.strophen.strophe.text_)
38+ song.title = first_line.split('\n')[0]
39
40 def _process_topics(self, foilpresenterfolie, song):
41 """