Code review comment for ~pfsmorigo/review-tools:pfsmorigo/core24

Revision history for this message
Alex Murray (alexmurray) wrote :

> r/overrides.py:1038:
> func_base_state_files_snaps_overrides = {"core22": "20220421"}
> Do I need to do a state files overrride for core24 too?
>

This state files override exists so that as soon as that date passes, we consider the contents of the snap to be stable and from that point onwards will run the stateful checks - since we don't know the exact release date of 24.04 this is a bit tricky, but perhaps set this as 20240430 for now since it should definitely be released not too long before that date.

> r/store.py:46:
> I use "undefined" for snap_to_release. Is that ok?
>

We know this will be NN - so how about nanimal for now (as this kind of nomenclature has been used before)?

> r/t/test_store.py:2121:
> There is this test and to add one for core24 I need the release name right?
> test_check_get_ubuntu_release_from_manifest_os_release_neon_bionic_core22

You could use nanimal again here if you want.

review: Needs Fixing

« Back to merge proposal