Merge lp:~percona-dev/percona-xtrabackup/mysql-5-5-8-cmake into lp:percona-xtrabackup/2.0

Proposed by Ignacio Nin
Status: Merged
Approved by: Vadim Tkachenko
Approved revision: no longer in the source branch.
Merged at revision: 209
Proposed branch: lp:~percona-dev/percona-xtrabackup/mysql-5-5-8-cmake
Merge into: lp:percona-xtrabackup/2.0
Diff against target: 63 lines (+12/-10)
3 files modified
Makefile (+3/-2)
utils/build.sh (+7/-8)
xtrabackup.c (+2/-0)
To merge this branch: bzr merge lp:~percona-dev/percona-xtrabackup/mysql-5-5-8-cmake
Reviewer Review Type Date Requested Status
Vadim Tkachenko Approve
Alexey Kopytov (community) Approve
Review via email: mp+44709@code.launchpad.net

Description of the change

Allows xtrabackup to build MySQL 5.5.8, which uses cmake as build system instead of autotools.

To post a comment you must log in.
Revision history for this message
Alexey Kopytov (akopytov) wrote :

Looks good to me.

review: Approve
Revision history for this message
Vadim Tkachenko (vadim-tk) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Makefile'
--- Makefile 2010-11-24 08:32:10 +0000
+++ Makefile 2010-12-26 18:44:52 +0000
@@ -5,6 +5,7 @@
5#5#
6# Default is xtradb - to build XtraBackup for Percona Server6# Default is xtradb - to build XtraBackup for Percona Server
7# 5.1 - XtraBackup for MySQL versions 5.1.* with plugin innobase7# 5.1 - XtraBackup for MySQL versions 5.1.* with plugin innobase
8# 5.5 - XtraBackup for MySQL versions 5.5.8 and up with plugin innobase
8# plugin - XtraBackup for MySQL versions 5.1.* with plugin innodb_plugin9# plugin - XtraBackup for MySQL versions 5.1.* with plugin innodb_plugin
910
10LIBS = -lpthread11LIBS = -lpthread
@@ -62,9 +63,9 @@
6263
63# XtraBackup for MySQL 5.564# XtraBackup for MySQL 5.5
645.5: INC = -I. -I.. -I./../include -I./../../include -I./../../../include655.5: INC = -I. -I.. -I./../include -I./../../include -I./../../../include
655.5: INNODBOBJS = ../libinnobase_a-btr0btr.o ../libinnobase_a-btr0cur.o ../libinnobase_a-btr0pcur.o ../libinnobase_a-btr0sea.o ../libinnobase_a-buf0buddy.o ../libinnobase_a-buf0buf.o ../libinnobase_a-buf0flu.o ../libinnobase_a-buf0lru.o ../libinnobase_a-buf0rea.o ../libinnobase_a-data0data.o ../libinnobase_a-data0type.o ../libinnobase_a-dict0boot.o ../libinnobase_a-dict0crea.o ../libinnobase_a-dict0dict.o ../libinnobase_a-dict0load.o ../libinnobase_a-dict0mem.o ../libinnobase_a-dyn0dyn.o ../libinnobase_a-eval0eval.o ../libinnobase_a-eval0proc.o ../libinnobase_a-fil0fil.o ../libinnobase_a-fsp0fsp.o ../libinnobase_a-fut0fut.o ../libinnobase_a-fut0lst.o ../libinnobase_a-ha0ha.o ../libinnobase_a-ha0storage.o ../libinnobase_a-hash0hash.o ../libinnobase_a-ibuf0ibuf.o ../libinnobase_a-lock0iter.o ../libinnobase_a-lock0lock.o ../libinnobase_a-log0log.o ../libinnobase_a-log0recv.o ../libinnobase_a-mach0data.o ../libinnobase_a-mem0mem.o ../libinnobase_a-mem0pool.o ../libinnobase_a-mtr0log.o ../libinnobase_a-mtr0mtr.o ../libinnobase_a-os0file.o ../libinnobase_a-os0proc.o ../libinnobase_a-os0sync.o ../libinnobase_a-os0thread.o ../libinnobase_a-page0cur.o ../libinnobase_a-page0page.o ../libinnobase_a-page0zip.o ../libinnobase_a-lexyy.o ../libinnobase_a-pars0grm.o ../libinnobase_a-pars0opt.o ../libinnobase_a-pars0pars.o ../libinnobase_a-pars0sym.o ../libinnobase_a-que0que.o ../libinnobase_a-read0read.o ../libinnobase_a-rem0cmp.o ../libinnobase_a-rem0rec.o ../libinnobase_a-row0ext.o ../libinnobase_a-row0ins.o ../libinnobase_a-row0merge.o ../libinnobase_a-row0mysql.o ../libinnobase_a-row0purge.o ../libinnobase_a-row0row.o ../libinnobase_a-row0sel.o ../libinnobase_a-row0uins.o ../libinnobase_a-row0umod.o ../libinnobase_a-row0undo.o ../libinnobase_a-row0upd.o ../libinnobase_a-row0vers.o ../libinnobase_a-srv0srv.o ../libinnobase_a-srv0start.o ../libinnobase_a-sync0arr.o ../libinnobase_a-sync0rw.o ../libinnobase_a-sync0sync.o ../libinnobase_a-thr0loc.o ../libinnobase_a-trx0purge.o ../libinnobase_a-trx0rec.o ../libinnobase_a-trx0roll.o ../libinnobase_a-trx0rseg.o ../libinnobase_a-trx0sys.o ../libinnobase_a-trx0trx.o ../libinnobase_a-trx0undo.o ../libinnobase_a-usr0sess.o ../libinnobase_a-ut0byte.o ../libinnobase_a-ut0dbg.o ../libinnobase_a-ut0list.o ../libinnobase_a-ut0mem.o ../libinnobase_a-ut0rnd.o ../libinnobase_a-ut0ut.o ../libinnobase_a-ut0vec.o ../libinnobase_a-ut0wqueue.o ../libinnobase_a-ut0rbt.o665.5: INNODBOBJS= ../libinnobase.a
6667
675.5: MYSQLOBJS= ../../../mysys/libmysys.a ../../../strings/libmystrings.a ../../../zlib/.libs/libzlt.a685.5: MYSQLOBJS= ../../../mysys/libmysys.a ../../../strings/libstrings.a ../../../zlib/libzlib.a
685.5: LIBS += -laio695.5: LIBS += -laio
695.5: TARGET := xtrabackup_55705.5: TARGET := xtrabackup_55
705.5: $(TARGET)715.5: $(TARGET)
7172
=== modified file 'utils/build.sh'
--- utils/build.sh 2010-12-19 17:36:46 +0000
+++ utils/build.sh 2010-12-26 18:44:52 +0000
@@ -110,15 +110,14 @@
110110
111 echo "Compile MySQL"111 echo "Compile MySQL"
112 cd $top_dir/mysql-$mysql_version112 cd $top_dir/mysql-$mysql_version
113 # We do not support CMake at the moment
114 export HAVE_CMAKE=no
115 # We need to build with partitioning due to MySQL bug #58632113 # We need to build with partitioning due to MySQL bug #58632
116 ./configure --enable-local-infile \114 cmake . \
117 --enable-thread-safe-client \115 -DENABLED_LOCAL_INFILE=ON \
118 --with-plugins=innobase,partition \116 -DWITH_INNOBASE_STORAGE_ENGINE=ON \
119 --with-zlib-dir=bundled \117 -DWITH_PARTITION_STORAGE_ENGINE=ON \
120 --enable-shared \118 -DWITH_ZLIB=BUNDLED \
121 --with-extra-charsets=complex --disable-dtrace119 -DWITH_EXTRA_CHARSETS=complex \
120 -DENABLE_DTRACE=OFF
122 $MAKE_CMD all121 $MAKE_CMD all
123 122
124 echo "Compile XtraBackup"123 echo "Compile XtraBackup"
125124
=== modified file 'xtrabackup.c'
--- xtrabackup.c 2010-12-02 18:59:42 +0000
+++ xtrabackup.c 2010-12-26 18:44:52 +0000
@@ -4223,6 +4223,8 @@
4223 if (dict_table_get_first_index(table)) {4223 if (dict_table_get_first_index(table)) {
4224#ifdef XTRADB_BASED4224#ifdef XTRADB_BASED
4225 dict_update_statistics_low(table, TRUE, FALSE);4225 dict_update_statistics_low(table, TRUE, FALSE);
4226#elif MYSQL_VERSION_ID >= 50508
4227 dict_update_statistics(table, TRUE);
4226#else4228#else
4227 dict_update_statistics_low(table, TRUE);4229 dict_update_statistics_low(table, TRUE);
4228#endif4230#endif

Subscribers

People subscribed via source and target branches