Percona XtraBackup moved to https://jira.percona.com/projects/PXB

Merge lp:~percona-dev/percona-xtrabackup/mysql-5-5-8-cmake into lp:percona-xtrabackup/2.0

  1. mysql-5-5-8-cmake
  2. Merge into 2.0
Proposed by Ignacio Nin
Status: Merged
Approved by: Vadim Tkachenko
Approved revision: no longer in the source branch.
Merged at revision: 209
Proposed branch: lp:~percona-dev/percona-xtrabackup/mysql-5-5-8-cmake
Merge into: lp:percona-xtrabackup/2.0
Diff against target: 63 lines (+12/-10)
3 files modified
Makefile (+3/-2)
utils/build.sh (+7/-8)
xtrabackup.c (+2/-0)
To merge this branch: bzr merge lp:~percona-dev/percona-xtrabackup/mysql-5-5-8-cmake
Reviewer Review Type Date Requested Status
Vadim Tkachenko Approve
Alexey Kopytov (community) Approve
Review via email: mp+44709@code.launchpad.net

Description of the change

Allows xtrabackup to build MySQL 5.5.8, which uses cmake as build system instead of autotools.

To post a comment you must log in.
Revision history for this message
Alexey Kopytov (akopytov) wrote :

Looks good to me.

review: Approve
Revision history for this message
Vadim Tkachenko (vadim-tk) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2010-11-24 08:32:10 +0000
3+++ Makefile 2010-12-26 18:44:52 +0000
4@@ -5,6 +5,7 @@
5 #
6 # Default is xtradb - to build XtraBackup for Percona Server
7 # 5.1 - XtraBackup for MySQL versions 5.1.* with plugin innobase
8+# 5.5 - XtraBackup for MySQL versions 5.5.8 and up with plugin innobase
9 # plugin - XtraBackup for MySQL versions 5.1.* with plugin innodb_plugin
10
11 LIBS = -lpthread
12@@ -62,9 +63,9 @@
13
14 # XtraBackup for MySQL 5.5
15 5.5: INC = -I. -I.. -I./../include -I./../../include -I./../../../include
16-5.5: INNODBOBJS = ../libinnobase_a-btr0btr.o ../libinnobase_a-btr0cur.o ../libinnobase_a-btr0pcur.o ../libinnobase_a-btr0sea.o ../libinnobase_a-buf0buddy.o ../libinnobase_a-buf0buf.o ../libinnobase_a-buf0flu.o ../libinnobase_a-buf0lru.o ../libinnobase_a-buf0rea.o ../libinnobase_a-data0data.o ../libinnobase_a-data0type.o ../libinnobase_a-dict0boot.o ../libinnobase_a-dict0crea.o ../libinnobase_a-dict0dict.o ../libinnobase_a-dict0load.o ../libinnobase_a-dict0mem.o ../libinnobase_a-dyn0dyn.o ../libinnobase_a-eval0eval.o ../libinnobase_a-eval0proc.o ../libinnobase_a-fil0fil.o ../libinnobase_a-fsp0fsp.o ../libinnobase_a-fut0fut.o ../libinnobase_a-fut0lst.o ../libinnobase_a-ha0ha.o ../libinnobase_a-ha0storage.o ../libinnobase_a-hash0hash.o ../libinnobase_a-ibuf0ibuf.o ../libinnobase_a-lock0iter.o ../libinnobase_a-lock0lock.o ../libinnobase_a-log0log.o ../libinnobase_a-log0recv.o ../libinnobase_a-mach0data.o ../libinnobase_a-mem0mem.o ../libinnobase_a-mem0pool.o ../libinnobase_a-mtr0log.o ../libinnobase_a-mtr0mtr.o ../libinnobase_a-os0file.o ../libinnobase_a-os0proc.o ../libinnobase_a-os0sync.o ../libinnobase_a-os0thread.o ../libinnobase_a-page0cur.o ../libinnobase_a-page0page.o ../libinnobase_a-page0zip.o ../libinnobase_a-lexyy.o ../libinnobase_a-pars0grm.o ../libinnobase_a-pars0opt.o ../libinnobase_a-pars0pars.o ../libinnobase_a-pars0sym.o ../libinnobase_a-que0que.o ../libinnobase_a-read0read.o ../libinnobase_a-rem0cmp.o ../libinnobase_a-rem0rec.o ../libinnobase_a-row0ext.o ../libinnobase_a-row0ins.o ../libinnobase_a-row0merge.o ../libinnobase_a-row0mysql.o ../libinnobase_a-row0purge.o ../libinnobase_a-row0row.o ../libinnobase_a-row0sel.o ../libinnobase_a-row0uins.o ../libinnobase_a-row0umod.o ../libinnobase_a-row0undo.o ../libinnobase_a-row0upd.o ../libinnobase_a-row0vers.o ../libinnobase_a-srv0srv.o ../libinnobase_a-srv0start.o ../libinnobase_a-sync0arr.o ../libinnobase_a-sync0rw.o ../libinnobase_a-sync0sync.o ../libinnobase_a-thr0loc.o ../libinnobase_a-trx0purge.o ../libinnobase_a-trx0rec.o ../libinnobase_a-trx0roll.o ../libinnobase_a-trx0rseg.o ../libinnobase_a-trx0sys.o ../libinnobase_a-trx0trx.o ../libinnobase_a-trx0undo.o ../libinnobase_a-usr0sess.o ../libinnobase_a-ut0byte.o ../libinnobase_a-ut0dbg.o ../libinnobase_a-ut0list.o ../libinnobase_a-ut0mem.o ../libinnobase_a-ut0rnd.o ../libinnobase_a-ut0ut.o ../libinnobase_a-ut0vec.o ../libinnobase_a-ut0wqueue.o ../libinnobase_a-ut0rbt.o
17+5.5: INNODBOBJS= ../libinnobase.a
18
19-5.5: MYSQLOBJS= ../../../mysys/libmysys.a ../../../strings/libmystrings.a ../../../zlib/.libs/libzlt.a
20+5.5: MYSQLOBJS= ../../../mysys/libmysys.a ../../../strings/libstrings.a ../../../zlib/libzlib.a
21 5.5: LIBS += -laio
22 5.5: TARGET := xtrabackup_55
23 5.5: $(TARGET)
24
25=== modified file 'utils/build.sh'
26--- utils/build.sh 2010-12-19 17:36:46 +0000
27+++ utils/build.sh 2010-12-26 18:44:52 +0000
28@@ -110,15 +110,14 @@
29
30 echo "Compile MySQL"
31 cd $top_dir/mysql-$mysql_version
32- # We do not support CMake at the moment
33- export HAVE_CMAKE=no
34 # We need to build with partitioning due to MySQL bug #58632
35- ./configure --enable-local-infile \
36- --enable-thread-safe-client \
37- --with-plugins=innobase,partition \
38- --with-zlib-dir=bundled \
39- --enable-shared \
40- --with-extra-charsets=complex --disable-dtrace
41+ cmake . \
42+ -DENABLED_LOCAL_INFILE=ON \
43+ -DWITH_INNOBASE_STORAGE_ENGINE=ON \
44+ -DWITH_PARTITION_STORAGE_ENGINE=ON \
45+ -DWITH_ZLIB=BUNDLED \
46+ -DWITH_EXTRA_CHARSETS=complex \
47+ -DENABLE_DTRACE=OFF
48 $MAKE_CMD all
49
50 echo "Compile XtraBackup"
51
52=== modified file 'xtrabackup.c'
53--- xtrabackup.c 2010-12-02 18:59:42 +0000
54+++ xtrabackup.c 2010-12-26 18:44:52 +0000
55@@ -4223,6 +4223,8 @@
56 if (dict_table_get_first_index(table)) {
57 #ifdef XTRADB_BASED
58 dict_update_statistics_low(table, TRUE, FALSE);
59+#elif MYSQL_VERSION_ID >= 50508
60+ dict_update_statistics(table, TRUE);
61 #else
62 dict_update_statistics_low(table, TRUE);
63 #endif

Subscribers

People subscribed via source and target branches