Merge lp:~pendulum/summit/665589-launchpad-request-retries into lp:summit

[Penelope Stowe]

try-catching the launchpad requests with 5 retries

try-catching the launchpad requests with 5 retries

[James Westby (james-w)]

Hi Penelope,

Thanks for the branch, it will be a useful feature.

18 + trycounter = 0
19 + retrytotal = 5

The trycounter line needs an extra space at the front to line up.

26 + print "Error while calling the launchpad API"

It would be useful to see the error that came back from launchpad here
when debugging. You can do this by changing

23 + except urllib2.HTTPError:

to be

23 + except urllib2.HTTPError, e:

and then putting "+ str(e)" at the end of the print line, adjusting the current
error message to have ": " at the end to stop the two parts running in to each
other.

Thanks,

James

review: Needs Fixing

[lp:~pendulum/summit/665589-launchpad-request-retries]

118. By Penelope Stowe on 2011-06-10

Fixed formatting and added error information

119. By Penelope Stowe on 2011-06-10

More format fixing.

120. By Penelope Stowe on 2011-06-10

Got the error message to actually display

[Nigel Babu (nigelbabu)]

Thanks so much for your patience in fixing the small small things. This now looks good to go :-)

review: Approve

[James Westby (james-w)]

Looks great! Thanks for the fix.

James

review: Approve

=== modified file 'summit/schedule/models/summitmodel.py'
--- summit/schedule/models/summitmodel.py	2011-04-29 16:04:00 +0000
+++ summit/schedule/models/summitmodel.py	2011-06-10 12:23:41 +0000
@@ -15,6 +15,8 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 import pytz
+import sys
+import time
 import urllib2
 
 from datetime import datetime
@@ -160,7 +162,20 @@
         """Update from Launchpad data."""
         url = ("https://launchpad.net/sprints/%s/+temp-meeting-export"
                % self.name)
-        export = urllib2.urlopen(url)
+        trycounter = 0
+        retrytotal = 5
+        while trycounter <= retrytotal:
+            try:
+                 export = urllib2.urlopen(url)
+            except urllib2.HTTPError, e:
+                trycounter += 1
+                if trycounter >= retrytotal:
+                    print "Error while calling the launchpad API: " + str(e)
+                    sys.exit(1)
+                else: 
+                    time.sleep(2)
+            else:
+                break
         tree = ElementTree.parse(export)
 
         for elem in tree.find("attendees").findall("person"):