Code review comment for lp:~pedro.baeza/banking-addons/7.0-bank-statement-reconcile-prof_parsing

Revision history for this message
Laurent Mignon (Acsone) (lmi) wrote :

I'm a little bit uneasy with the proposed merge since part of the profile information is spend to the parser factory (import_type) and the profile itself to the parse method. We can imagine use cases where information from the profile could be required to initialize the parser. I would prefer to spent the profile object at the earlier to the parser.
It's just my point of view ...

Regards

> I have made it in this way to make little changes, but that can be another
> solution. What do you prefer?
>
> Regards.

« Back to merge proposal