Merge lp:~pedro.baeza/banking-addons/7.0-bank-statement-reconcile-prof_parsing into lp:banking-addons/bank-statement-reconcile-70

[Pedro Manuel Baeza]

[IMP] account_statement_base_import: Allow to use profile data for customizing parsing

Simple improvement on the account_statement_base_import module to have profile data on parse method to use it to customize parsing with, for example, a parameter introduced on profiles.

There is no need to do it anything more, because parse method already contains *args and **kwargs. You can access profile data with args[0] in parse method.

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Next time someone review this module, he will wander why prof is passed to parser and why it is unused.

You should at least add a comment if you don't want it to be removed. Otherwise you should create a hook.

review: Needs Fixing

[lp:~pedro.baeza/banking-addons/7.0-bank-statement-reconcile-prof_parsing]

142. By Pedro Manuel Baeza on 2014-05-05

[IMP] account_statement_base_import: Comment for prof variable.

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Yannick,

I have added a comment to explain the purpose of prof variable.

Thanks for you review.

Regards.

[Laurent Mignon (Acsone) (lmi)]

Hi,

Why not spend the profile to the parser factory in place of to the parse method?

Regards,

lmi

[Pedro Manuel Baeza (pedro.baeza)]

I have made it in this way to make little changes, but that can be another solution. What do you prefer?

Regards.

[Laurent Mignon (Acsone) (lmi)]

I'm a little bit uneasy with the proposed merge since part of the profile information is spend to the parser factory (import_type) and the profile itself to the parse method. We can imagine use cases where information from the profile could be required to initialize the parser. I would prefer to spent the profile object at the earlier to the parser.
It's just my point of view ...

Regards

> I have made it in this way to make little changes, but that can be another
> solution. What do you prefer?
>
> Regards.

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

Hi Pedro,

Thanks for the contrib. After thinking about, I must admit I'm in favor of Laurent's suggestion here. Can you make the changes please ?

Regards,

review: Approve (code review, no tests)

[lp:~pedro.baeza/banking-addons/7.0-bank-statement-reconcile-prof_parsing]

143. By Pedro Manuel Baeza on 2014-05-09

[IMP] account_statement_base_import: Profile passed and stored on parser initialisation instead of an argument for parse method

144. By Pedro Manuel Baeza on 2014-05-12

Docstring and change in parser factory params

145. By Pedro Manuel Baeza on 2014-05-12

Change account_statement_transactionid_import and account_statement_ofx_import accordingly.

Unmerged revisions

145. By Pedro Manuel Baeza on 2014-05-12

Change account_statement_transactionid_import and account_statement_ofx_import accordingly.

144. By Pedro Manuel Baeza on 2014-05-12

Docstring and change in parser factory params

143. By Pedro Manuel Baeza on 2014-05-09

[IMP] account_statement_base_import: Profile passed and stored on parser initialisation instead of an argument for parse method

142. By Pedro Manuel Baeza on 2014-05-05

[IMP] account_statement_base_import: Comment for prof variable.

141. By Pedro Manuel Baeza on 2014-04-05

[IMP] account_statement_base_import: Allow to use profile data for customizing parsing

=== modified file 'account_statement_base_import/parser/parser.py'
--- account_statement_base_import/parser/parser.py	2014-02-28 13:02:35 +0000
+++ account_statement_base_import/parser/parser.py	2014-05-09 13:46:22 +0000
@@ -42,7 +42,7 @@
     from the FileParser instead.
     """
 
-    def __init__(self, parser_name, *args, **kwargs):
+    def __init__(self, parser_name, profile, *args, **kwargs):
         # The name of the parser as it will be called
         self.parser_name = parser_name
         # The result as a list of row. One row per line of data in the file, but
@@ -50,6 +50,8 @@
         self.result_row_list = None
         # The file buffer on which to work on
         self.filebuffer = None
+        # The profile record to access its parameters in any parser method
+        self.profile = profile
         self.balance_start = None
         self.balance_end = None
         self.statement_name = None
@@ -210,7 +212,7 @@
                 yield sub
 
 
-def new_bank_statement_parser(parser_name, *args, **kwargs):
+def new_bank_statement_parser(parser_name, profile, *args, **kwargs):
     """
     Return an instance of the good parser class base on the providen name
     :param char: parser_name
@@ -218,5 +220,5 @@
     """
     for cls in itersubclasses(BankStatementImportParser):
         if cls.parser_for(parser_name):
-            return cls(parser_name, *args, **kwargs)
+            return cls(parser_name, profile, *args, **kwargs)
     raise ValueError

=== modified file 'account_statement_base_import/statement.py'
--- account_statement_base_import/statement.py	2014-05-07 08:50:38 +0000
+++ account_statement_base_import/statement.py	2014-05-09 13:46:22 +0000
@@ -156,7 +156,7 @@
                                  _("You must provide a valid profile to import a bank statement!"))
         prof = prof_obj.browse(cr, uid, profile_id, context=context)
 
-        parser = new_bank_statement_parser(prof.import_type, ftype=ftype)
+        parser = new_bank_statement_parser(prof, ftype=ftype)
         result_row_list = parser.parse(file_stream)
         # Check all key are present in account.bank.statement.line!!
         if not result_row_list: