Code review comment for lp:~pearce/terminator/gtk3-new-tab-dir

Revision history for this message
Stephen Boddy (stephen-j-boddy) wrote :

I didn't see this merge request before I fixed the issue myself. As far as I can see the get_current_directory_uri is completely broken (at least in Python). It only ever returns a None for me, causing tabs to fail, and splits to not inherit the primary terminals directory. I reverted to the trunk method, which while kind of ugly, at least works reliably. See http://bazaar.launchpad.net/~gnome-terminator/terminator/gtk3/revision/1538

Thanks for the contributions.

review: Disapprove

« Back to merge proposal