Merge lp:~pearce/terminator/gtk3-new-tab-dir into lp:terminator/gtk3
Proposed by
judgedreads
Status: | Rejected |
---|---|
Rejected by: | Stephen Boddy |
Proposed branch: | lp:~pearce/terminator/gtk3-new-tab-dir |
Merge into: | lp:terminator/gtk3 |
Diff against target: |
24 lines (+6/-1) 1 file modified
terminatorlib/terminal.py (+6/-1) |
To merge this branch: | bzr merge lp:~pearce/terminator/gtk3-new-tab-dir |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stephen Boddy | Disapprove | ||
Review via email: mp+254498@code.launchpad.net |
Description of the change
I added a default directory for new tabs in case the vte method fails to get the cwd.
To post a comment you must log in.
Unmerged revisions
- 1530. By judgedreads <email address hidden>
-
set a default directory for new tabs
I didn't see this merge request before I fixed the issue myself. As far as I can see the get_current_ directory_ uri is completely broken (at least in Python). It only ever returns a None for me, causing tabs to fail, and splits to not inherit the primary terminals directory. I reverted to the trunk method, which while kind of ugly, at least works reliably. See http:// bazaar. launchpad. net/~gnome- terminator/ terminator/ gtk3/revision/ 1538
Thanks for the contributions.