Code review comment for lp:~paul-mccullagh/maria/pbxt-1.0.11

Kristian Nielsen <email address hidden> writes:

> Paul McCullagh <email address hidden> writes:

>> All tests in the PBXT suite run through on Mac and Linux, except for one error under Linux, which is a bit weird (see below).
>
>> ------------------
>>
>> pbxt.select_safe [ fail ]
>> Test ended at 2010-05-06 17:19:13
>>
>> CURRENT_TEST: pbxt.select_safe
>> mysqltest: At line 19: query 'select 1 from t1,t1 as t2,t1 as t3' failed: 1104: The SELECT would examine more than MAX_JOIN_SIZE rows; check your WHERE and use SET SQL_BIG_SELECTS=1 or SET SQL_MAX_JOIN_SIZE=# if the SELECT is okay
>>
>> The result from queries just before the failure was:
>> drop table if exists t1;
>> SET SQL_SAFE_UPDATES=1,SQL_SELECT_LIMIT=4, SQL_MAX_JOIN_SIZE=9;
>> create table t1 (a int auto_increment primary key, b char(20));
>> insert into t1 values(1,"test");
>> SELECT SQL_BUFFER_RESULT * from t1;
>> a b
>> 1 test
>> update t1 set b="a" whe
>
> Yes, looks wierd. I did not get this test failure on my Linux build.
>
> We fixed some regressions after merging with MySQL 5.1.46, maybe those also
> fixed this case. Or maybe it is a random failure, and Buildbot will have more
> to say on the issue.

Hm, I can repeat it in a --valgrind run, but not in a normal run (which is
also wierd). I will take a look.

 - Kristian.