Code review comment for lp:~parthm/bzr/376388-dot-bazaar-ownership-regression-2.2
Revision history for this message
| Vincent Ladeuil (vila) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> Well, shouldn't we use the *ownership* it already has?
Keep in mind that only root can change ownership, this code is targeted as usages under sudo, we may want to try being more fancy here like respecting the current owner if the file owner is not root nor the containing directory owner but that sounds weird.
We are talking of the user config files here and I can't see a good reason to have different owners for the config file and its containing directory.
Anyway, if we want to explore these scenarios, we need to write the corresponding tests, hence bug #608216.