Code review comment for ~paride/ubuntu/+source/strongswan:merge-5.9.4-1-JAMMY

Revision history for this message
Paride Legovini (paride) wrote (last edit ):

Merge 5.9.4-1 from Debian. Test PPA:

https://launchpad.net/~paride/+archive/ubuntu/strongswan-merge-5.9.4-1

I verified that the two security patches released in 5.9.1-1ubuntu3.1 are part of the new upstream version. No conflicts to resolve in the merge process.

I recovered the rich git history from the previous merge MP as the importer doesn't have it due to empty directories.

# Lintian

Note: the Debian package updated the lintian-overrides to work with the new lintian versions. This means that lintian 2.104.0ubuntu3 (currently in Jammy -release) is going to issue some error tags. Testing with lintian 2.111.0ubuntu1 (currently in jammy-proposed) tests clean.

# Autopkgtest results:

autopkgtest [15:53:10]: @@@@@@@@@@@@@@@@@@@@ summary
admin-strongswan-charon PASS
admin-strongswan-starter PASS
daemon PASS
plugins PASS

# OpenSSL 3.0

By looking at the upstream commit history I expected this merge to also fix the OpenSSL 3.0 FTBFS (LP: #1946213). The build stage indeed succeeds, but the upstream test suite then fails, so overall the package still FTBFS. There is an upstream issue about the failure, to which I commented:

https://github.com/strongswan/strongswan/issues/753

« Back to merge proposal