Merge ~pappacena/turnip:paginated-check-refs-permissions into turnip:master
Proposed by
Thiago F. Pappacena
Status: | Rejected |
---|---|
Rejected by: | Thiago F. Pappacena |
Proposed branch: | ~pappacena/turnip:paginated-check-refs-permissions |
Merge into: | turnip:master |
Diff against target: |
172 lines (+77/-12) 4 files modified
requirements.txt (+1/-0) setup.py (+1/-0) turnip/pack/hooks/hook.py (+25/-9) turnip/pack/tests/test_hooks.py (+50/-3) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Colin Watson (community) | Needs Information | ||
Review via email: mp+384593@code.launchpad.net |
Commit message
Adding better error reporting and paginating the requests to check_ref_
Description of the change
Ideally, when a user pushes a lot of branches at once, we should parallelize (in a thread pool executor, for example) the permissions checks in batches (instead of checking one batch after another).
But such change would require a bit more refactoring to create different sockets, so this goes in a future MP.
To post a comment you must log in.
This branch uses mock package for python 2. So, it depends on https:/ /code.launchpad .net/~pappacena /turnip/ +git/turnip- dependencies/ +merge/ 384592.