Code review comment for lp:~paolo-de-rosa/charms/trusty/percona-cluster/innodb_flush_log

Revision history for this message
Mario Splivalo (mariosplivalo) wrote :

This is fine, there are situations where one doesn't need percona to issue fsync() on innodb redo logs after each commit.

I'd just shorten the description of the option, just explaining what possible options are and then perhaps add URL link that points to percona/mysql documentation.

There is one issue I'd like to see fixed before this merge is approved by me - comments are inline.

review: Needs Fixing

« Back to merge proposal