Merge lp:~paolo-de-rosa/charms/trusty/percona-cluster/innodb_flush_log into lp:~openstack-charmers-archive/charms/trusty/percona-cluster/next

[Paolo de Rosa]

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #5704 percona-cluster-next for paolo-de-rosa mp263534
    LINT FAIL: lint-test failed

LINT Results (max last 2 lines):
make: *** [lint] Error 1
ERROR:root:Make target returned non-zero.

Full lint test output: http://paste.ubuntu.com/11805556/
Build: http://10.245.162.77:8080/job/charm_lint_check/5704/

[uosci-testing-bot (uosci-testing-bot)]

charm_unit_test #5336 percona-cluster-next for paolo-de-rosa mp263534
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/5336/

[uosci-testing-bot (uosci-testing-bot)]

charm_amulet_test #4892 percona-cluster-next for paolo-de-rosa mp263534
    AMULET FAIL: amulet-test missing

AMULET Results (max last 2 lines):
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full amulet test output: http://paste.ubuntu.com/11805574/
Build: http://10.245.162.77:8080/job/charm_amulet_test/4892/

[Mario Splivalo (mariosplivalo)]

This is fine, there are situations where one doesn't need percona to issue fsync() on innodb redo logs after each commit.

I'd just shorten the description of the option, just explaining what possible options are and then perhaps add URL link that points to percona/mysql documentation.

There is one issue I'd like to see fixed before this merge is approved by me - comments are inline.

review: Needs Fixing

[lp:~paolo-de-rosa/charms/trusty/percona-cluster/innodb_flush_log]

67. By Paolo de Rosa on 2015-07-02

As 'innodb-flush-log-at-trx-commit' has default set to '1' it is always present in config so there is no need for an 'if' here.

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #5728 percona-cluster-next for paolo-de-rosa mp263534
    LINT FAIL: lint-test failed

LINT Results (max last 2 lines):
make: *** [lint] Error 1
ERROR:root:Make target returned non-zero.

Full lint test output: http://paste.ubuntu.com/11811106/
Build: http://10.245.162.77:8080/job/charm_lint_check/5728/

[uosci-testing-bot (uosci-testing-bot)]

charm_unit_test #5360 percona-cluster-next for paolo-de-rosa mp263534
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/5360/

[uosci-testing-bot (uosci-testing-bot)]

charm_amulet_test #4920 percona-cluster-next for paolo-de-rosa mp263534
    AMULET FAIL: amulet-test missing

AMULET Results (max last 2 lines):
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full amulet test output: http://paste.ubuntu.com/11811119/
Build: http://10.245.162.77:8080/job/charm_amulet_test/4920/

[Mario Splivalo (mariosplivalo)]

This now looks fine to me.

review: Approve

[lp:~paolo-de-rosa/charms/trusty/percona-cluster/innodb_flush_log]

68. By Paolo de Rosa on 2015-07-22

synced /next

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #6632 percona-cluster-next for paolo-de-rosa mp263534
    LINT FAIL: lint-test failed

LINT Results (max last 2 lines):
make: *** [lint] Error 1
ERROR:root:Make target returned non-zero.

Full lint test output: http://paste.ubuntu.com/11921247/
Build: http://10.245.162.77:8080/job/charm_lint_check/6632/

[uosci-testing-bot (uosci-testing-bot)]

charm_unit_test #6259 percona-cluster-next for paolo-de-rosa mp263534
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/6259/

[uosci-testing-bot (uosci-testing-bot)]

charm_amulet_test #5262 percona-cluster-next for paolo-de-rosa mp263534
    AMULET FAIL: amulet-test missing

AMULET Results (max last 2 lines):
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full amulet test output: http://paste.ubuntu.com/11921802/
Build: http://10.245.162.77:8080/job/charm_amulet_test/5262/

[Ryan Beisner (1chb1n)]

The percona-cluster/next amulet tests are now known to be passing. Can this proposed branch be rebased to pull in those test updates?

[lp:~paolo-de-rosa/charms/trusty/percona-cluster/innodb_flush_log]

69. By Paolo de Rosa on 2015-07-23

synced /next

[uosci-testing-bot (uosci-testing-bot)]

charm_unit_test #6359 percona-cluster-next for paolo-de-rosa mp263534
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/6359/

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #6732 percona-cluster-next for paolo-de-rosa mp263534
    LINT FAIL: lint-test failed
    LINT FAIL: charm-proof failed

LINT Results (max last 2 lines):
make: *** [lint] Error 200
ERROR:root:Make target returned non-zero.

Full lint test output: http://paste.ubuntu.com/11925356/
Build: http://10.245.162.77:8080/job/charm_lint_check/6732/

[uosci-testing-bot (uosci-testing-bot)]

charm_amulet_test #5274 percona-cluster-next for paolo-de-rosa mp263534
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/11925380/
Build: http://10.245.162.77:8080/job/charm_amulet_test/5274/

[Ryan Beisner (1chb1n)]

Please take note of the failed charm proof (lint) test re: innodb-flush-log-at-trx-commit, which appears to also be causing the amulet test to fail. Thanks!

review: Needs Fixing

[lp:~paolo-de-rosa/charms/trusty/percona-cluster/innodb_flush_log]

70. By Paolo de Rosa on 2015-07-24

fixed option type

[uosci-testing-bot (uosci-testing-bot)]

charm_unit_test #6412 percona-cluster-next for paolo-de-rosa mp263534
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/6412/

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #6885 percona-cluster-next for paolo-de-rosa mp263534
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/6885/

[uosci-testing-bot (uosci-testing-bot)]

charm_amulet_test #5327 percona-cluster-next for paolo-de-rosa mp263534
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/5327/

[Billy Olsen (billy-olsen)]

Paolo, I have a nit with the config description and would like to see that flushed out a bit more. There's a lot more information on the setting itself upstream which isn't included here. I don't think we should include it here specifically but instead should possibly reference the upstream documentation in addition to a basic discussion.

review: Needs Fixing

[lp:~paolo-de-rosa/charms/trusty/percona-cluster/innodb_flush_log]

71. By Paolo de Rosa on 2015-09-02

Update description of innodb_flush_log_at_trx_commit option

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #9229 percona-cluster-next for paolo-de-rosa mp263534
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/9229/

[uosci-testing-bot (uosci-testing-bot)]

charm_unit_test #8530 percona-cluster-next for paolo-de-rosa mp263534
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/8530/

[uosci-testing-bot (uosci-testing-bot)]

charm_amulet_test #6191 percona-cluster-next for paolo-de-rosa mp263534
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/6191/

[James Page (james-page)]

Hi Paola

Currently showing a merge conflict - please could you rebase and then I think this is good to be landed once OSCI has re-tested.

review: Needs Fixing

Unmerged revisions

71. By Paolo de Rosa on 2015-09-02

Update description of innodb_flush_log_at_trx_commit option

70. By Paolo de Rosa on 2015-07-24

fixed option type

69. By Paolo de Rosa on 2015-07-23

synced /next

68. By Paolo de Rosa on 2015-07-22

synced /next

67. By Paolo de Rosa on 2015-07-02

As 'innodb-flush-log-at-trx-commit' has default set to '1' it is always present in config so there is no need for an 'if' here.

66. By Paolo de Rosa on 2015-07-01

Added InnoDB flush log variable

=== modified file 'config.yaml'
--- config.yaml	2015-07-27 09:44:19 +0000
+++ config.yaml	2015-09-02 10:30:50 +0000
@@ -140,8 +140,38 @@
       If you're running multiple environments with the same services in them
       this allows you to differentiate between them.
   nagios_servicegroups:
+<<<<<<< TREE
     type: string
     default: ''
     description: |
       A comma-separated list of nagios servicegroups. If left empty, the
       nagios_context will be used as the servicegroup.
+=======
+    default: ""
+    type: string
+    description: |
+        A comma-separated list of nagios servicegroups.
+        If left empty, the nagios_context will be used as the servicegroup
+  innodb-buffer-pool-size:
+    default:
+    type: string
+    description: |
+      By default this value will be set according to the 50% of system total memory
+      but also can be set to any specific value for the system.
+      Suffix this value with 'K','M','G', or 'T' to get the relevant kilo/mega/etc. bytes.
+      If suffixed with %, one will get that percentage of system total memory devoted.
+  innodb-flush-log-at-trx-commit:
+    type: int
+    default: 1
+    description: |
+      This option determines how often are written the redo logs when data is committed.
+      This setting is very important to improve performances or security when you run
+      mysql on hardware without a battery backed write cache.
+      More info http://dev.mysql.com/doc/refman/5.1/en/innodb-parameters.html
+  min-cluster-size:
+    type: int
+    default:
+    description: |
+      Minimum number of units expected to exist before charm will attempt to
+      bootstrap percona cluster. If no value is provided this setting is ignored.
+>>>>>>> MERGE-SOURCE

=== modified file 'templates/my.cnf'
--- templates/my.cnf	2015-06-04 14:40:54 +0000
+++ templates/my.cnf	2015-09-02 10:30:50 +0000
@@ -74,6 +74,8 @@
 # query cache is not supported with Active/Active configuration
 innodb_buffer_pool_size = {{ innodb_buffer_pool_size }}
 
+innodb_flush_log_at_trx_commit = {{ innodb_flush_log_at_trx_commit }}
+
 {% if ipv6 -%}
 [sst]
 sockopt=,pf=ip6