Code review comment for ~panfaust/kubuntu-packaging/+git/libksane:work

Thank you for your reply Philip,

> So the idea is ok, but the versions for the breaks are wrong
>
> libkf5sane5 (<= 16.04.3-0ubuntu1~ubuntu16.10~ppa50),
> should be
> libkf5sane5 (<= 16.04.3~),
>
> libksane-data (<= 16.04.3-0ubuntu1~ubuntu16.10~ppa50)
> should be
> libksane-data (<= 4:16.04.3~)

Indeed I missed the epoch in libksane-data, that has to be corrected. However I think it's very arguably that the version of libkf5sane5 is wrong, because it depends on what you understand as "wrong": if I'm not mistaken the version you suggest would break dist-upgrades in the staging ppa; if you don't want to support that, then OK, but I used that version working on the assumption that you might want to support dist-upgrades with the staging ppa and you would include this request and you would upload the version with the ~ppa51 suffix to staging.

Anyway I will push a commit using the versions you said.

> and is $(overridden_command) not a thing for dh_gencontrol?

Well, in this case there won't be any difference in the final command to be executed, but I agree it's better to use $(overridden_command). It was done that way because I got the idea from other package not using dhmk.