Merge ~panfaust/kubuntu-packaging/+git/libksane:work into ~kubuntu-packagers/kubuntu-packaging/+git/libksane:kubuntu_yakkety_archive
Status: | Merged |
---|---|
Merged at revision: | a3d5a8047534b4793e957fdf6c93eb431fa3118e |
Proposed branch: | ~panfaust/kubuntu-packaging/+git/libksane:work |
Merge into: | ~kubuntu-packagers/kubuntu-packaging/+git/libksane:kubuntu_yakkety_archive |
Diff against target: |
81 lines (+30/-4) 5 files modified
debian/changelog (+7/-1) debian/control (+19/-0) debian/libkf5sane-data.install (+1/-0) debian/libkf5sane5.install (+0/-1) debian/rules (+3/-2) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Rik Mills | Approve | ||
Philip Muškovac | Needs Fixing | ||
Review via email: mp+302979@code.launchpad.net |
Description of the change
This merge request contains 2 commits, the first one corrects a problem similar to this one:
https:/
Here in libksane are the misplaced files are
usr/share/
So in addition to the problems already mentioned in the libpiki merge request (violates a 'must' policy, contradicts the lib packaging guide, makes the upgrades unneccesarily difficult), here in libksane also the misplaced files can break the multiarch installation because the files have the same name for any architecture so libkf5ksane5 couldn't be installed, for instance, for both amd64 and i386 in the same system.
So I moved the files in question to a libkf5ksane-data package. That's the name of the package in debian's git master. In xenial there is already 'libksane-data', version '4:15.08.
root@xdu-
Reading package lists... Done
Building dependency tree
Reading state information... Done
Calculating upgrade... Done
The following packages were automatically installed and are no longer required:
[snip]
Use 'sudo apt autoremove' to remove them.
The following packages have been kept back:
gir1.
0 upgraded, 0 newly installed, 0 to remove and 3 not upgraded.
The change I made in the first commit in the debian/rules file is to add the epoch to the libksane-data dummy package and ONLY to that package; this way we don't have to add an epoch to the other packages so once yakkety is released we could remove both this change in the rules file and the dummy transitional package.
The change I made in the second commit is just removing the exclusion of 'kde-runtime' when calling dh_shlibdeps, this exclusion was there to avoid undesired dependencies when libksane was still based on kdelibs 4; note that the libkdecore5 symbols file from kde4libs injects a dependency on kde-runtime. So now that libksane is based on KDE Frameworks that exclusion is no longer needed.
So the idea is ok, but the versions for the breaks are wrong
libkf5sane5 (<= 16.04.3- 0ubuntu1~ ubuntu16. 10~ppa50) ,
should be
libkf5sane5 (<= 16.04.3~),
libksane-data (<= 16.04.3- 0ubuntu1~ ubuntu16. 10~ppa50)
should be
libksane-data (<= 4:16.04.3~)
and is $(overridden_ command) not a thing for dh_gencontrol?