Code review comment for ~panfaust/kubuntu-packaging/+git/libksane:work

Revision history for this message
Philip Muškovac (yofel) wrote :

So the idea is ok, but the versions for the breaks are wrong

libkf5sane5 (<= 16.04.3-0ubuntu1~ubuntu16.10~ppa50),
should be
libkf5sane5 (<= 16.04.3~),

libksane-data (<= 16.04.3-0ubuntu1~ubuntu16.10~ppa50)
should be
libksane-data (<= 4:16.04.3~)

and is $(overridden_command) not a thing for dh_gencontrol?

review: Needs Fixing

« Back to merge proposal