Code review comment for ~paelzer/ubuntu/+source/spice:eoan-go-to-0.14.2

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

Looks like Build-Depends for this package should have:

libspice-protocol-dev (>= 0.14.0),

orelse you might get:

----
configure:11599: $PKG_CONFIG --exists --print-errors "spice-protocol >= $SPICE_PROTOCOL_MIN_VER"
Package spice-protocol was not found in the pkg-config search path.
Perhaps you should add the directory containing `spice-protocol.pc'
to the PKG_CONFIG_PATH environment variable
No package 'spice-protocol' found
configure:11602: $? = 1
configure:11616: result: no
No package 'spice-protocol' found
configure:11632: error: Package requirements (spice-protocol >= 0.14.0) were not met:

No package 'spice-protocol' found

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Alternatively, you may set the environment variables SPICE_PROTOCOL_CFLAGS
and SPICE_PROTOCOL_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.
----

even after satisfying build-dep needs, during dh_autoreconf phase.

####

After fixing it, when trying to satisfy the needs (without having 0.14.0 in the archive):

----
The following packages have unmet dependencies:
 builddeps:. : Depends: libspice-protocol-dev (>= 0.14.0) but 0.12.14-1 is to be installed
E: Unable to correct problems, you have held broken packages.
----

and after installing it manually:

----
$ apt-get build-dep .
Note, using directory '.' to get the build dependencies
Reading package lists... Done
Building dependency tree
Reading state information... Done
Starting pkgProblemResolver with broken count: 0
Starting 2 pkgProblemResolver with broken count: 0
Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
----

And dh_autoreconf phase works correctly.

review: Needs Fixing

« Back to merge proposal