Merge ~paelzer/ubuntu/+source/spice:eoan-go-to-0.14.2 into ubuntu/+source/spice:ubuntu/eoan-devel

[Christian Ehrhardt ]

[Christian Ehrhardt  (paelzer)]

Analyzing reverse dependencies of spice as it is a lib (although with a narrow focus).

$ reverse-depends src:spice-protocol -r eoan
Reverse-Depends
===============
* libspice-client-glib-2.0-dev (for libspice-protocol-dev)
* libspice-server-dev [amd64 arm64 armhf i386 ppc64el] (for libspice-protocol-dev)

The latter is src:spice which we upload anyway.

$ reverse-depends --build-depends src:spice-protocol -r eoan
Reverse-Build-Depends
=====================
* looking-glass (for libspice-protocol-dev)
* qemu (for libspice-protocol-dev)
* remmina (for libspice-protocol-dev)
* spice (for libspice-protocol-dev)
* spice-gtk (for libspice-protocol-dev)
* spice-vdagent (for libspice-protocol-dev)
* xserver-xorg-video-qxl (for libspice-protocol-dev)

$ reverse-depends src:spice -r eoan
Reverse-Depends
===============
* qemu-system-arm (for libspice-server1)
* qemu-system-mips (for libspice-server1)
* qemu-system-misc (for libspice-server1)
* qemu-system-ppc (for libspice-server1)
* qemu-system-s390x (for libspice-server1)
* qemu-system-sparc (for libspice-server1)
* qemu-system-x86 (for libspice-server1)
* xserver-xspice [amd64] (for libspice-server1)

$ reverse-depends --build-depends src:spice -r eoan
Reverse-Build-Depends
=====================
* qemu (for libspice-server-dev)
* xserver-xorg-video-qxl (for libspice-server-dev)

Most only depend on headers and only qemu and xorg driver have runtiem deps.

[Christian Ehrhardt  (paelzer)]

Dependency versions are:
qemu*
  libspice-server1 (>= 0.13.1)
xserver-xorg-video-qxl
  libspice-server1 (>= 0.13.2)

Does the rebuild pick up anything newer?
=> No it stays at this dependency which we already have fulfilled.
No need for explicit rebuilds.

[Christian Ehrhardt  (paelzer)]

I checked rebuilds (in he PPA) of the reverse dependencies to be sure.
=> https://launchpad.net/~paelzer/+archive/ubuntu/eoan-merge-spice-0.14.2/+packages

The one thing we need is spice-gtk which would become a FTBFS for a rebuild due to changes in the headers.
So overall we need:
1. spice-protocol
2. spice
3. spice-gtk

Note: I have imported spice-gtk into my own trees to create MPs for now.

[Christian Ehrhardt  (paelzer)]

Did some tests on the PPA which pulled in the set of:
Get:1 http://archive.ubuntu.com/ubuntu eoan/main amd64 gir1.2-gstreamer-1.0 amd64 1.16.0-1 [72.1 kB]
spice-client-glib-usb-acl-helper amd64 0.37-0ubuntu1~ppa2 [14.5 kB]
libspice-client-glib-2.0-8 amd64 0.37-0ubuntu1~ppa2 [299 kB]
libspice-client-gtk-3.0-5 amd64 0.37-0ubuntu1~ppa2 [55.4 kB]
gir1.2-spiceclientgtk-3.0 amd64 0.37-0ubuntu1~ppa2 [10.9 kB]
gir1.2-spiceclientglib-2.0 amd64 0.37-0ubuntu1~ppa2 [18.3 kB]
libspice-server1 amd64 0.14.2-0ubuntu1~ppa5 [347 kB]

Testing connection to a local qemu with (and some I/O on the console)
- virt-manager
- virt-viewer
- spice-client-gtk (spice)

All were ok.

Further I tried to install a desktop in guest to have qxl drivers from the guest running.

Note: I stripped the vnc config off a guest to see if all can connect with only spice using the new libs. That all worked well in my tests.

[Rafael David Tinoco (rafaeldtinoco)]

Looks like Build-Depends for this package should have:

libspice-protocol-dev (>= 0.14.0),

orelse you might get:

----
configure:11599: $PKG_CONFIG --exists --print-errors "spice-protocol >= $SPICE_PROTOCOL_MIN_VER"
Package spice-protocol was not found in the pkg-config search path.
Perhaps you should add the directory containing `spice-protocol.pc'
to the PKG_CONFIG_PATH environment variable
No package 'spice-protocol' found
configure:11602: $? = 1
configure:11616: result: no
No package 'spice-protocol' found
configure:11632: error: Package requirements (spice-protocol >= 0.14.0) were not met:

No package 'spice-protocol' found

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Alternatively, you may set the environment variables SPICE_PROTOCOL_CFLAGS
and SPICE_PROTOCOL_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.
----

even after satisfying build-dep needs, during dh_autoreconf phase.

####

After fixing it, when trying to satisfy the needs (without having 0.14.0 in the archive):

----
The following packages have unmet dependencies:
 builddeps:. : Depends: libspice-protocol-dev (>= 0.14.0) but 0.12.14-1 is to be installed
E: Unable to correct problems, you have held broken packages.
----

and after installing it manually:

----
$ apt-get build-dep .
Note, using directory '.' to get the build dependencies
Reading package lists... Done
Building dependency tree
Reading state information... Done
Starting pkgProblemResolver with broken count: 0
Starting 2 pkgProblemResolver with broken count: 0
Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
----

And dh_autoreconf phase works correctly.

review: Needs Fixing

[Rafael David Tinoco (rafaeldtinoco)]

* this is super minor

I asked for some help of @ahasenack to identify where the test-listen failure was coming from. My initial doubt was if, before the merge was done, the automated tests were running in a jenkins or somewhere. He explained to me about dh_auto_test and I realized that Makefile "check" would dive into test execution from server/tests directory during compilation time.

After that, it was clear to me what you mentioned, but, during this conversation we realized that there was an upstream commit removing the "--enable-automated-tests" option from configure:

commit 6517ea5cbb07b1480319b51a834cfbe9cfc71e69
Author: Frediano Ziglio <email address hidden>
Date: Sun Sep 3 07:08:04 2017

    test-display-base: Always compile with AUTOMATED_TESTS enabled

    There's no need to not compile this feature, it just enable
    a parameters which must be passed in order to change test
    behaviour.

    Signed-off-by: Frediano Ziglio <email address hidden>
    Acked-by: Christophe Fergeau <email address hidden>

so, inside file debian/tests/automated-tests, the option:

"--enable-automated-tests"

can be dropped (but I guess this would come have to come from Debian as well, and it is really tiny).

[Rafael David Tinoco (rafaeldtinoco)]

Despite previous commits, I have compiled the source package and tested against EOAN qemu-kvm and it worked well, including the other (to be reviewed together) package spice-client-gtk.

I'm +1 after, at least, the build-depends fix.

[Christian Ehrhardt  (paelzer)]

ack on the build-depends - added

[Christian Ehrhardt  (paelzer)]

FYI: To build against a PPA (for cases like that needing multiple packages together) I recommend (if you use sbuild) something like:

DEB_BUILD_OPTIONS=3 sbuild -Adcosmic-amd64 --extra-repository="deb [trusted=yes] http://ppa.launchpad.net/paelzer/eoan-merge-spice-0.14.2/ubuntu eoan main" spice-gtk_0.37-0ubuntu1~ppa2.dsc

[Christian Ehrhardt  (paelzer)]

re-added the canonical-server slot

[Christian Ehrhardt  (paelzer)]

requested changes done, thanks for catching the Bdep
Settign to approved

[Christian Ehrhardt  (paelzer)]

review: Approve

diff --git a/.tarball-version b/.tarball-version
index a803cc2..e867cc2 100644
--- a/.tarball-version
+++ b/.tarball-version
@@ -1 +1 @@
-0.14.0
+0.14.2
diff --git a/.version b/.version
index bdfb04f..e867cc2 100644
--- a/.version
+++ b/.version
@@ -1 +1 @@
-0.13.91
+0.14.2
diff --git a/AUTHORS b/AUTHORS
index 99f6c18..43bdf2a 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -27,6 +27,7 @@ Patches also contributed by
     Axel Lin <[e-mail]>
     소병철 <[e-mail]>
     Cédric Bosdonnat <[e-mail]>
+    Changqing Li <[e-mail]>
     Christian Ruppert <[e-mail]>
     Christophe de Dinechin <[e-mail]>
     Cole Robinson <[e-mail]>
@@ -47,6 +48,7 @@ Patches also contributed by
     Jürg Billeter <[e-mail]>
     Li Zhijian <[e-mail]>
     Liang Guo <[e-mail]>
+    Lukáš Hrázký <[e-mail]>
     Lukas Venhoda <[e-mail]>
     Michal Privoznik <[e-mail]>
     Michael Tokarev <[e-mail]>
@@ -64,5 +66,9 @@ Patches also contributed by
     Wang Qiang <[e-mail]>
     Yann E. MORIN <[e-mail]>
     Zeeshan Ali (Khattak) <[e-mail]>
+    Douglas Paul <[e-mail]>
+    谢 昆明 <[e-mail]>
+    Benjamin Tissoires <[e-mail]>
+    Olivier Fourdan <[e-mail]>
 
    ....send patches to get your name here...
diff --git a/ChangeLog b/ChangeLog
index 8c26339..5e6bd43 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,3906 @@
[phone]  Frediano Ziglio  <[e-mail]>
+
+	build: Prepare for 0.14.2 release
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Benjamin Tissoires  <[e-mail]>
+
+	inputs-channel: Attempt to have a reliable led state
+	We can not consider the qemu led state to be reliable. It by default has
+	50ms of delay, so if we want to achieve something reliable, this won't do.
+
+	We need to keep our own internal state, and consider it as reliable.
+	We update it immediately after receiving the key presses, meaning that this
+	is now the future state of the guest.
+
+	When we receive a keymap event, we check against this 'ideal' state and
+	only update the guest if we 'counted' that it won't have the correct state.
+
+	When the guest notifies its change, the modifiers_watch is supposed to
+	fix any wrong state.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	Update spice-protocol version
+	We require version after 0.12.15 which was released as 0.14.0.
+	Check against a valid released instead of checking for a non existing one.
+
+	Acked-by: Victor Toso <[e-mail]>
+
+	meson: Bump libcacard requirement to 2.5.1
+	This had already been done for Meson in commit
+	afb2ec312bde342b8538451c6ae15a7f3bdd494f.
+
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Francois Gouget  <[e-mail]>
+
+	video-stream: use the dcc local variable
+	In update_client_playback_delay()
+
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	Fix meson build importing spice-common fix
+	This brings in the following changes:
+
+	Eduardo Lima (Etrunko) (1):
+	      meson: Make targets list store dictionaries instead of lists
+
+	Frediano Ziglio (2):
+	      meson: Fix dependency of generated files
+	      meson: Do not build generated files twice
+
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	Update spice-common submodule
+	This brings in the following changes:
+
+	Christophe Fergeau (8):
+	      canvas_base: Fix variable shadowing warning
+	      backtrace: Add missing include
+	      lz: Don't try to print uninitialized variable
+	      build: Add missing G_GNUC_PRINTF annotations
+	      build: Update verify.h to latest version
+	      test-marshallers: Fix header guard
+	      quic: Fix QUIC_VERSION definition
+	      log: Let gcc know about the logging macros which abort
+
+	Frediano Ziglio (13):
+	      codegen: Rename --prefix parameter to --suffix
+	      ci: Remove dependencies from copr build
+	      build: Remove snd_codec.h from EXTRA_DIST
+	      test-ssl-verify: Improve subject_to_x509_name coverage
+	      meson: Remove some useless checks
+	      codegen: Factor out a function to write output file
+	      codegen: Generate headers while generating code
+	      codegen: Allows to generate C declarations automatically
+	      Allow to generate C declarations for spice.proto
+	      Generate automatically most C message declarations
+	      recorder: Update
+	      build: Add new check for recorder library
+	      proto: Fix typo in message name
+
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	red-worker: Remove unused definitions
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	red-worker: Use bool for driver_cap_monitors_config
+	Easier to understand.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	red-channel: Small comment on "core" field
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	display-channel: Inline red_migrate_display function
+	The only caller only called that function.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	Move image_compression field from RedWorker to DisplayChannel
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	Check image compression value earlier
+	Do not check it after assigning to reds->config->image_compression,
+	check the value as soon as possible.
+	This prevent potential invalid settings.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	red-worker: Remove only assigned fields
+	DisplayChannelClient get them directly from reds (they are changed
+	only during initialisation so they can be read freely from any
+	thread).
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
[phone]  Jonathon Jongsma  <[e-mail]>
+
+	Make channel client callbacks virtual functions
+	Rather than having an API to register client callbacks for each channel
+	type, make them vfuncs.
+
+	Since the client callbacks are registered identically for each channel
+	of the same type, it doesn't make sense for to require these to be
+	registered separately for each object.  It's cleaner to have these be
+	per-class properties, so they've been converted to virtual functions.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	Check running state in red_qxl_set_client_capabilities
+	No reasons to expose red_qxl_is_running, this was used to not
+	send capability is the state was not running.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	Move DisplayChannel callbacks from RedWorker to DisplayChannel
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
[phone]  Jonathon Jongsma  <[e-mail]>
+
+	Save running property in QXLState
+	This is a preparatory patch that states the running property in QXLState
+	and provides accessor functions that allows us to check whether the QXL
+	device is running from different threads.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	Move thread/dispatching handling to RedChannel
+	Currently channel threading/handling is spread between RedQxl,
+	RedWorker and RedChannel.
+	Move more to RedChannel simplify RedQxl and RedWorker.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	dispatcher: Allows to manage messages without registering them
+	The only way to add new message to Dispatcher was to register
+	using a number. These numbers corresponded to array indexes.
+	This is good if the list of messages is allocated statically
+	and contiguously, on the contrary this method is not that
+	flexible.
+	Writing a header of 4 or 16 bytes using system call does not
+	make much difference so pass all message information in the
+	payload header.
+	A new dispatcher_send_message_custom function allows to send
+	a message passing all message information, including the
+	pointer to the handler.
+	This will allow for instance a Dispatcher associate to a given
+	thread to be reused by different classes.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	docs: Fix typo
+	Acked-by: Uri Lublin <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	build: Clean a generated file
+	Acked-by: Eduardo Lima (Etrunko) <[e-mail]>
+
[phone]  谢 昆明  <[e-mail]>
+
+	Remove a duplicated line
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Francois Gouget  <[e-mail]>
+
+	Consistently check if drm_dma_buf_fd is greater or lower than zero
+	Based on a patch by Frediano Ziglio.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	dcc: Remove a redundant NULL pointer check in dcc_create_surface()
+	dcc_create_surface() already returns immediately if dcc is NULL.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	worker: Fix potential sprintf overflow
+	If worker->qxl->id is bigger than 0x7ffffff (in other words, it's a
+	negative signed int) then
+	printf(worker_str, "display[%d]", worker->qxl->id);
+	will need:
+
+	"display[]" -> 9 bytes
+	%d -> 11 bytes
+
+	The trailing \0 will thus overflow our 20 bytes destination.
+	As QXLInstance::id should be an unsigned int, this commit changes the
+	format string to use %u. This also switches to snprintf.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	red-worker: Use mnemonic for statistic buffer
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	main-dispatcher: Use reds as opaque for dispatcher
+	No reason to pass through MainDispatcher, the purpose of
+	MainDispatcher is to call reds functions from the right thread.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	main-dispatcher: Inline main_dispatcher_self_handle_channel_event
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	dispatcher: Use NULL for pointer check
+	handler is a pointer, check for NULL, not 0.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	reds: Check we don't register a channel twice in reds_register_channel
+	To avoid potential regressions, check it only if extra checks are
+	enabled.
+	This allows to check previous "Move channel registration to constructed
+	vfunc" commit.
+
+	Acked-by: Snir Sheriber <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	test-stream-device: Remove interface before next loop
+	We should not reuse the same interface twice as doing so will
+	cause dangling pointers.
+	Unregister it at every iteration.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	Remove support for 64 bit pointers on protocol
+	Import "codegen: Remove support for --ptrsize" change from spice-common
+	and update code accordingly.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	Update spice-common submodule
+	This brings in the following changes:
+
+	Frediano Ziglio (11):
+	      codegen: Document ptr_array attribute
+	      codegen: Use a better type for pointer converted to integer
+	      codegen: Reduce indentation
+	      codegen: Fix c_type result for TypeAlias
+	      codegen: Check wrong attribute
+	      codegen: Add a test for attribute combination
+	      mem: Fix compile error if alignment-checks option is used
+	      log: Remove useless includes
+	      proto: Remove obsolete TunnelChannel
+	      protocol: Add a dummy TunnelChannel
+	      messages: Remove fields not used by the protocol
+
+	Marc-André Lureau (1):
+	      docs: add spice URI scheme
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	syntax-check: Add missing contributors names to AUTHORS
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Douglas Paul  <[e-mail]>
+
+	video-stream: prevent crash on stream reattach
+	I experienced some crashes with qemu 3.1.0 compiled with libspice-server
+	0.14.0 on Gentoo.
+
+	The problem reproduced reliably with a guest running Ubuntu 18.04.2 LTS.
+	If I connect a viewer at system startup, I would get a crash just after
+	the fade-in of the login prompt in GDM.
+
+	Interestingly, I usually was unable to reproduce the issue if I waited
+	to connect until after the greeter was fully displayed.
+
+	The patch I used to correct the issue for me applies to the master
+	branch cleanly, so I suspect the problem may still exist.
+
+	The only other references to this issue I could find were two abrt
+	reports in CentOS:
+	https://bugs.centos.org/view.php?id=15171
+	https://bugs.centos.org/view.php?id=15441
+
+	I'm not sure if the agent->video_encoder is supposed to be guaranteed to
+	exist when this function is called.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Jonathon Jongsma  <[e-mail]>
+
+	Move channel registration to constructed vfunc
+	For the Display Channel and the Cursor channel, move the call to
+	reds_register_channel() to the _constructed() vfunc rather than calling
+	it explicitly from RedWorker. This matches what other channels do.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Victor Toso  <[e-mail]>
+
+	display-channel: monitors config debug: add head number
+	The difference is subtle but compared to what client receives, this
+	could help identify values set to the wrong head, e.g:
+
+	First we received:
+	 | display-channel.c:180:monitors_config_debug: monitors config count:2 max:4
+	 | display-channel.c:184:monitors_config_debug: +0+0 1015x805
+	 | display-channel.c:184:monitors_config_debug: +1015+0 1024x740
+
+	And then:
+	 | display-channel.c:180:monitors_config_debug: monitors config count:3 max:4
+	 | display-channel.c:184:monitors_config_debug: +0+0 1015x805
+	 | display-channel.c:184:monitors_config_debug: +0+0 0x0
+	 | display-channel.c:184:monitors_config_debug: +1015+0 1024x740
+
+	In the first debug it would be helpful to have "head 0" and "head 1",
+	to point out the temporary error in monitor's config message.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Jonathon Jongsma  <[e-mail]>
+
+	Switch some boolean fields to 'bool' type
+	For coding style consistency, use 'bool' when we want to represent a
+	boolean value.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	Only send device display info to supported agents
+	Only send the graphics device display info to agents that advertise the
+	VD_AGENT_CAP_GRAPHICS_DEVICE_INFO capability
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	Refactor agent_adjust_capabilities() function
+	Make this a RedsState member function rather than a standalone function.
+	This means that we simply pass RedsState* as an argument rather than the
+	internal member variables of RedsState. This enables the following
+	commit which handles the VD_AGENT_CAP_GRAPHICS_DEVICE_INFO capability to
+	avoid sending graphics device info to agents that do not support it.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	test-stat: Adjust delay checks
+	usleep under Windows does not seem to have the required precision.
+	Use milliseconds and adjust check times according.
+
+	Reviewed-by: Marc-André Lureau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	Use proper format strings for spice_log
+	Formatting string should be compatible with GLib.
+	GLib uses formatting types compatible with GNU.
+	For Linux this is not an issue as both systems (like a printf) and
+	GLib one uses the same formatting type.  However on Windows they
+	differs potentially causing issues.
+	This is also make worse as GLib 2.58 changed format attribute from
+	__printf__ to gnu_printf (Microsoft compatibility formats like %I64d
+	are still supported but you'll get warnings using GCC/Clang
+	compilers).
+
+	Reviewed-by: Marc-André Lureau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	red-pipe-item: Removed some not necessary headers inclusions
+	RedPipeItem is not using the Ring structures anymore.
+	Also is not using GLib functionality.
+	Just include base headers.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	reds: Check QXL ID registering interface
+	Avoid to register multiple interface with the same ID.
+	This would result in issues as 2 channels would have the same
+	(channel_type, channel_id) which must be unique.
+	Qemu always allocates QXL interface with IDs starting from 0.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	reds: Reuse agent_dev local variable
+	The field is only assigned in do_spice_init, surely won't change
+	in the meanwhile.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	reds: Use proper enumeration for read_state field
+	Allows the compiler to catch some additional errors.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Eduardo Lima (Etrunko)  <[e-mail]>
+
+	meson: switch smartcard option to auto feature
+	Make it compatible with spice-common.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	meson: Bump libcacard requirement to 2.5.1
+	This had already been done for autotools in spice-common commit
+	924f47a653bd87fbd50229ee34b58d7b9a3f1ec8.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	meson: Use gnu_symbol_visibility keyword introduced in meson 0.48
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	Remove core parameter from main_dispatcher_new
+	This was added in bd8771adbcf3ff34d14333cf874191e8d105f612.
+	There's no reason to not use reds function instead.
+	MainDispatcher needs to listen in the main thread that is the
+	one provided by reds_core_* functions.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	test-stream-device: Check monitor ID messages
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	reds: Factor out a function to marshal VDAgentGraphicsDeviceInfo message
+	Instead of scanning the monitor twice (one to compute the size
+	and another to build the message) use a single function to
+	marshal the message.
+	This also fixes big endian machines (which are not supported).
+	Marshal function is exported to make easier to test (see following
+	patch).
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	agent-msg-filter: Simplify code
+	Most of the time result is set to AGENT_MSG_FILTER_OK, set at
+	the beginning and change if necessary.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	reds: Fix typo in comment
+
+	reds: Fix typos in comments
+	Acked-by: Eduardo Lima (Etrunko) <[e-mail]>
+
+	agent-msg-filter: Add some comments to AgentMsgFilter structure
+	Acked-by: Eduardo Lima (Etrunko) <[e-mail]>
+
+	smartcard-channel-client: Update usage of GObject private structures
+	This finished the work of 90ff154b36b3ab80350cb4a4d391db330bed2a76
+	(cfr "Update usage of GObject private structures").
+	Removes last call to g_type_class_add_private.
+
+	Acked-by: Eduardo Lima (Etrunko) <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	smartcard: Improve on_message_from_device readability
+	This removes a not really useful switch/case, and changes the function
+	to exit early on error cases, rather than exiting early in the nominal
+	case.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	smartcard: Rework smartcard_get_vsc_msg_item a bit
+	This renames the method to smartcard_new_vsc_msg_item as this creates a
+	new object. This also removes the creation of a temporary VHeader which
+	is then going to be duplicated.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	smartcard: Remove redundant test in smartcard_char_device_on_message_from_device()
+	The function returns NULL if vheader->type is VSC_Init so no need to
+	check it a second time.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	smartcard: Remove unused smartcard_get_vsc_msg_item argument
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	char-device: Make send_tokens_to_client() optional
+	Only RedCharDeviceVDIPortClass implements this vfunc, rather than
+	forcing every classes deriving from RedCharDeviceClass to implement it,
+	red_char_device_send_tokens_to_client() can deal with it.
+
+	Acked-by: Uri Lublin <[e-mail]>
+
+	doc: Document G_MESSAGES_DEBUG use
+	Explain how to get more verbose logs out of spice-server
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Eduardo Lima (Etrunko)  <[e-mail]>
+
+	Update usage of GObject private structures
+	New functions and macros have been added in glib 2.38 to better handle
+	this case.
+
+	https://gitlab.gnome.org/GNOME/glib/blob/c8de2b11bbbf5705ee20bf68d0c11e455b441312/NEWS
+
+	G_TYPE_INSTANCE_GET_PRIVATE will be deprecated in GLib 2.58.
+
+	https://gitlab.gnome.org/GNOME/glib/merge_requests/7/commits
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	ssl: Dump OpenSSL error stack on errors
+	Bugs such as https://bugzilla.redhat.com/show_bug.cgi?id=1651882 can be
+	quite tricky to figure out without the detailed OpenSSL error. This
+	commit adds a detailed dump of the OpenSSL error stack when an OpenSSL
+	failure happens.
+
+	In the bug above, this would have displayed:
+	(process:13154): Spice-WARNING **: 05:43:10.139: reds.c:2816:reds_init_ssl: Could not load certificates from /etc/pki/libvirt-spice/server-cert.pem
+
+	(process:13154): Spice-WARNING **: 05:43:10.140: error:140AB18F:SSL routines:SSL_CTX_use_certificate:ee key too small
+
+	Acked-by: Uri Lublin <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	memslot: Fix off-by-one error in group/slot boundary check
+	RedMemSlotInfo keeps an array of groups, and each group contains an
+	array of slots. Unfortunately, these checks are off by 1, they check
+	that the index is greater or equal to the number of elements in the
+	array, while these arrays are 0 based. The check should only check for
+	strictly greater than the number of elements.
+
+	For the group array, this is not a big issue, as these memslot groups
+	are created by spice-server users (eg QEMU), and the group ids used to
+	index that array are also generated by the spice-server user, so it
+	should not be possible for the guest to set them to arbitrary values.
+
+	The slot id is more problematic, as it's calculated from a QXLPHYSICAL
+	address, and such addresses are usually set by the guest QXL driver, so
+	the guest can set these to arbitrary values, including malicious values,
+	which are probably easy to build from the guest PCI configuration.
+
+	This patch fixes the arrays bound check, and adds a test case for this.
+	This fixes CVE-2019-3813.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	build-sys: Raise glib requirement to 2.38
+	meson is already using 2.38, and most distros have a newer version:
+	    - Fedora 28 has 2.56
+	    - CentOS 7 has 2.46
+	    - Debian 9 has 2.50
+
+	This also matches what spice-common requires.
+
+	Acked-by: Eduardo Lima (Etrunko) <[e-mail]>
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	red-stream-device: Constify stream_device_get_device_display_info result
+	There should be no reason for the caller to modify the internal
+	structure.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Eduardo Lima (Etrunko)  <[e-mail]>
+
+	meson: Use underscorify() instead of split()
+
+	m4: Remove repeated warnings suppression
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	event-loop: Port to Windows
+	Use g_io_channel_win32_new_socket instead of g_io_channel_unix_new
+
+	Reviewed-by: Marc-André Lureau <[e-mail]>
+
+	replay: Port to Windows
+	Client process termination did not work for Windows, used Win32
+	APIs.
+
+	Reviewed-by: Marc-André Lureau <[e-mail]>
+
+	test-listen: Exclude Unix sockets part under Windows
+	Windows does not support Unix sockets.
+
+	Reviewed-by: Marc-André Lureau <[e-mail]>
+
+	reds: Explicitly include inttypes.h
+	MingW does not include this header while including stdint.h so
+	on Windows you need to include it.
+
+	Reviewed-by: Marc-André Lureau <[e-mail]>
+
+	windows: Do not include headers not available on Windows
+	This is a preparatory patch for next portability patches
+
+	Reviewed-by: Marc-André Lureau <[e-mail]>
+
+	red-qxl: Use proper formatting string for size_t
+	Avoids issues with LLP64 systems.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	display-channel: Remove unused includes
+	display-channel.h is not using any of the definition from
+	these headers.
+	Adding a missing include to red-worker.c.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	red-stream-device: Fix "make syntax-check"
+	Avoid using strncpy, considered not secure.
+	In this case a simple memcpy is used, we are going to terminate
+	the string in any case on the next line.
+
+	Acked-by: Lukáš Hrázký <[e-mail]>
+
+	image-encoders: Initialize Zlib lazily
+	Zlib structure take up more than 1MB and it is rarely used nowadays
+	as it is not much effective.
+	Initialise it only when necessary saving some memory in the normal
+	case.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Uri Lublin  <[e-mail]>
+
+	smartcard: do not keep weak ref when device is NULL
+	When a client disconnects, smartcard_channel_client_set_char_device
+	is called with a NULL "device" argument. In that case there is
+	no need to take a weak reference to the device.
+
+	Without this patch the server complains:
+	  g_object_add_weak_pointer: assertion 'G_IS_OBJECT (object)' failed
+
+	and aborts when a second client attempts to connect.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Lukáš Hrázký  <[e-mail]>
+
+	Send the graphics device info from streaming agent to the vd_agent
+	Adds the graphics device info from the streaming device(s) to the
+	VDAgentGraphicsDeviceInfo message sent to the vd_agent.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	Receive the GraphicsDeviceInfo message from the streaming agent
+	Receives the GraphicsDeviceInfo message from the streaming agent and
+	stores the data in a list on the streaming device.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	Send the graphics device info to the vd_agent
+	Sends the device address and device display IDs to the vdagent. The
+	message is sent either in reaction to the SPICE_MSGC_MAIN_AGENT_START
+	message or when the graphics device info changes.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
[phone]  Lukáš Hrázký  <[e-mail]>
+
+	QXL interface: improve the spice_qxl_set_device_info documentation
+	Instead of one unsupported example, present two real world examples.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
[phone]  Lukáš Hrázký  <[e-mail]>
+
+	QXL interface: deprecate spice_qxl_set_max_monitors
+	Replace it by spice_qxl_set_device_info. Note we can't use
+	monitors_count for what's stored in max_monitors, because monitors_count
+	denotes the length of the device_display_ids array, which
+	spice_qxl_set_max_monitors doesn't touch.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	QXL interface: add a function to identify monitors in the guest
+	Adds a function to let QEMU provide information to identify graphics
+	devices and their monitors in the guest. The function
+	(spice_qxl_set_device_info) sets the device address (e.g. a PCI path)
+	and monitor ID -> device display ID mapping of displays exposed by given
+	QXL interface.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	red-worker: Remove obsolete type definition
+	AsyncCommand was removed in eb6c8ba025.
+
+	Acked-by: Victor Toso <[e-mail]>
+
+	ci: Remove dependencies from copr build
+	Acked-by: Eduardo Lima (Etrunko) <[e-mail]>
+
+	Trace streaming device data using recorder
+	Trace when data is received from the guest and when is sent
+	to the client.
+
+	Acked-by: Victor Toso <[e-mail]>
+
+	Allows to enable recorder integration
+	recorder library will be used to collect some statistics during
+	development.
+
+	Acked-by: Victor Toso <[e-mail]>
+
+	Update spice-common submodule
+	This brings in the following changes:
+
+	Frediano Ziglio (11):
+	      Update --enable-celt051 help string
+	      test-marshaller: Make test_overflow static
+	      test-marshaller: Make main declaration easier
+	      test-region: Add missing dependencies
+	      ci: Run tests on Windows using wine
+	      Use a single copy of subject string
+	      log: Use proper format attribute for spice_log
+	      marshaller: Provide spice_marshaller_fill_iovec for Windows
+	      test: Add a test for subject_to_x509_name function
+	      lz: Avoid buffer reading overflow checking for image type
+	      lz: More checks on image sizes
+
+	Jonathon Jongsma (1):
+	      Fix some additional typos
+
+	Marc-André Lureau (5):
+	      Bump libcacard requirement to 2.5.1
+	      Add a .gitpublish
+	      build-sys: improve asciidoc rules to allow multiple targets
+	      quic: fix sign-compare warning
+	      meson: fix building for big-endian host
+
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	Reuse SPICE_UPCAST instead of SPICE_CONTAINEROF where possible
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	sasl: Simplify red_stream_write_u32_le call with '0' serveroutlen
+	Instead of
+	if (serveroutlen) {
+	...
+	} else {
+	    red_stream_write_u32_le(stream, serveroutlen);
+	}
+
+	use 'red_stream_write_u32_le(stream, 0);' in the else block as it's
+	slightly more obvious.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	red-replay-qxl: Use PRIxPTR constant for string formatting
+	These constants are meant to be used in format string for pointers
+	types. Use them for portability.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	test-display-base: Remove error from "make syntax-check"
+	Due to previous commit "make syntax-check" command reports:
+
+	prohibit_signal_without_use
+	server/tests/test-display-base.c
+	maint.mk: the above files include signal.h but don't use it
+	make: *** [maint.mk:639: sc_prohibit_signal_without_use] Error 1
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	test-display-base: Port to Windows
+	Use GLib function to launch and wait process exit.
+
+	Reviewed-by: Marc-André Lureau <[e-mail]>
+
+	replay: Force binary mode on input on Windows
+	If input contains the binary record we can't have it modified
+	during read.
+
+	Reviewed-by: Marc-André Lureau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	test-playback: Simplify wave generation formulae
+	Split level computation, make clear is a sine wave on both channels.
+
+	Acked-by: Uri Lublin <[e-mail]>
+
+	test-playback: Remove obsolete debug
+	Acked-by: Uri Lublin <[e-mail]>
+
+	test-playback: Update misleading comments
+	We are waiting for a client connection, channel is already there
+
+	Acked-by: Uri Lublin <[e-mail]>
+
+	test-playback: Remove useless check for "frame"
+	We just fill it up, can't be NULL.
+
+	Acked-by: Uri Lublin <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	reds_stat: Use EXIT_SUCCESS/EXIT_FAILURE for program result
+	-1 is not much portable and standard.
+
+	Acked-by: Snir Sheriber <[e-mail]>
+
+	reds_stat: Print errors on standard error, not standard output
+	Acked-by: Snir Sheriber <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	tests/pki: Use CA/certificate valid until 2048 and with 2048 bits
+	This changes tests/pki/server-cert.pem and tests/pki/ca-cert.pem to have
+	2048 bits. These certificates were generated using the
+	instructions on https://www.spice-space.org/spice-user-manual.html
+	The -subj args were omitted, and the defaults suggested by openssl used.
+	The -days parameter was changed to -days 10950, the bits to 2048.
+
+	This fixes https://gitlab.freedesktop.org/spice/spice/issues/27.
+
+	Some distros are starting to use stricter settings for their openssl
+	configuration, which forbids 1024 bit keys, and causes test suite
+	failures.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	qxl: Release QXL resources in red_put_surface_cmd
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	display-channel: Store full RedSurfaceCmd, not just QXLReleaseInfoExt
+	Now that we have a refcounted RedSurfaceCmd, we can store the command
+	itself in DisplayChannel rather than copying QXLReleaseInfoExt. This
+	will let us move the release of the QXL guest resources in red-parse-qxl
+	in the next commit.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	qxl: Add red_surface_cmd_{new, ref, unref} helpers
+	Currently, RedWorker is using stack-allocated variables for RedSurfaceCmd.
+	Surface commands are rare enough that we can dynamically allocate them
+	instead, and make the API in red-parse-qxl.h consistent with how other
+	QXL commands are handled.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	qxl: Add red_update_cmd_{new, ref, unref} helpers
+	Currently, RedUpdateCmd are allocated on the stack, and then
+	initialized/uninitialized with red_{get,put}_update_cmd
+	This makes the API inconsistent with what is being done for RedDrawable,
+	RedCursor and RedMessage. QXLUpdateCmd are not occurring very often,
+	we can dynamically allocate them instead, and get a consistent API.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	qxl: Release QXL resources in red_put_update_cmd
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	qxl: Add red_message_{new, ref, unref} helpers
+	Currently, RedMessage are allocated on the stack, and then
+	initialized/uninitialized with red_{get,put}_message
+	This makes the API inconsistent with what is being done for RedDrawable
+	and RedCursor. Since QXLMessage is just a (mostly unused/unsecure) debugging tool,
+	we can dynamically allocate it instead, and get a consistent API.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	qxl: Release QXL resource in red_put_message
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	qxl: Add red_cursor_cmd_{new, ref, unref} helpers
+	Currently, the cursor channel is allocating RedCursorCmd instances itself, and then
+	calling into red-parse-qxl.h to initialize it, and doing something
+	similar when releasing the data. This commit moves this common code to
+	red-parse-qxl.[ch]
+	The ref/unref are not strictly needed, red_cursor_cmd_free() would
+	currently be enough, but this makes the API consistent with
+	red_drawable_{new,ref,unref}.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	qxl: Fix guest resources release in red_put_drawable()
+	At the moment, we'll unconditionally release the guest QXL resources in
+	red_put_drawable() even if red_get_drawable() failed and did not
+	initialize drawable->release_info_ext properly.
+	This commit only sets RedDrawable::qxl once the guest resource have been
+	successfully retrieved, and only free the guest QXL resources when
+	RedDrawable::qxl is set.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	qxl: Make red_{get, put}_drawable static
+	Rather than needing to call red_drawable_new() and then initialize it
+	with red_get_drawable(), we can improve slightly red_drawable new so
+	that red_drawable_{new,ref,unref} is all which is used by code out of
+	red-parse-qxl.c.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	qxl: Move red_drawable_unref/red_drawable_new
+	RedDrawable really is a RedDrawCmd which is parsed by red-parse-qxl.h
+	Moreover, red_drawable_ref() is already defined inline in
+	red-parse-qxl.h, and red_drawable_unref() is declared there too even if
+	its code is still in red-worker.c
+	This commit moves them close to the other functions creating/unref'ing
+	QXL commands parsed by red-parse-qxl.h.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	tests: Use g_assert_(non)null instead of g_assert
+	Just a style change, on more recent GLib would print a more
+	friendly error report.
+
+	Acked-by: Uri Lublin <[e-mail]>
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Marc-André Lureau  <[e-mail]>
+
+	smartcard: set char device state
+	Follow all other char devices implementation (spicevmc, agent,
+	stream-device) and set the char device state when
+	connected/disconnected. This allows qemu to discard writes, optimize a
+	bit the source polling, and will trigger HUP events.
+
+	See related qemu "char/spice: discard write() if backend is
+	disconnected".
+
+	Note: sif->state() should probably be handled at the char-device
+	level. I am not sure what the smartcard channel really brings over
+	plain spicevmc...
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	dcc: Add debug log when setting compression
+	Without this it's not obvious that a compression setting took effect.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	tests: Add a small test for red_record_ APIs
+	Acked-by: Eduardo Lima (Etrunko) <[e-mail]>
+
+	test-leaks: Avoid clashing with test-display-base ports
+	Is possible that port 5913 is already in use as tests that uses
+	test_new will attempt to use ports from 5912 to 5921 so use a port
+	not in that range.
+
+	Acked-by: Eduardo Lima (Etrunko) <[e-mail]>
+
+	test-display-base: Fix warning message avoidance
+	test_new function attempts to detect attempts to listen to tcp ports
+	already in listening state detecting some messages during
+	spice_server_init. However the check is wrong (broken in recent
+	34a44d3e940bcc "test-display-base: Avoid spurious errors due to listen
+	failures") and incomplete (missing message).
+
+	To better test this conditions put some of the ports in listening
+	state (like with a "nc -l 5912 & nc -l 5913 &" command) and run
+	tests in parallel (like with a "make check -j" command).
+
+	Acked-by: Eduardo Lima (Etrunko) <[e-mail]>
+
+	ci: Ignore leak from GnuTLS p11 call
+	Fix Fedora 29 one-time leak.
+
+	Acked-by: Eduardo Lima (Etrunko) <[e-mail]>
+
+	ci: Merge new glib.supp file
+	Merge from GLib master repository.
+
+	Acked-by: Eduardo Lima (Etrunko) <[e-mail]>
+
+	red-replay-qxl: Remove useless end of line
+	Spice log functions already add an end of line.
+
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	test-display-base: Avoid spurious errors due to listen failures
+	To set up a listening socket usually you call in sequence:
+	- socket;
+	- bind;
+	- listen.
+	If you try to bind() to a port when another socket is already
+	listening on that port, the bind() will fail.
+	However, it is possible that the bind() may succeed and the listen()
+	will fail, as demonstrated in the following sequence:
+	- socket() create socket 1;
+	- bind() to port N on socket 1;
+	- socket() create socket 2;
+	- bind() to port N on socket 2;
+	- listen() on socket 1;
+	- listen() on socket 2 <-- failure.
+
+	When running tests (especially multiple tests running in parallel), it
+	may sometimes happen that there are other tests already listening on
+	the port that we are trying to use. In this case, we want to ignore
+	this error and simply try to listen on a different port. We already
+	attempted to handle this scenario, but we were only ignoring bind()
+	errors and not listen() errors. So in the scenario mentioned above,
+	the listen() error was causing the entire test to fail instead of
+	allowing us to try to listen on another port.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	ci: Do not try to downgrade asciidoc anymore
+	Is not more necessary to downgrade asciidoc, the issue was fixed
+	in Fedora 29, now used by CI.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	char-device: Remove initial underscores from __red_char_device_write_buffer_get
+	Just cosmetic changes, the static function had underscores to
+	distinguish from the exported one which was recently renamed.
+
+	Acked-by: Lukáš Hrázký <[e-mail]>
+
[phone]  Lukáš Hrázký  <[e-mail]>
+
+	reds: move vdagent write buffer creation into a function
+	Adds a function to create a write buffer for sending a message to
+	vdagent from the server to prevent code duplication.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	char-device: separate functions to get write buffer for client and server
+	Instead of having a single red_char_device_write_buffer_get function to
+	get both client and server buffers and decide by testing client == NULL,
+	have separate function for a client and for a server. The situation
+	should always be clear (you're either on the client or on the server
+	side) and you shouldn't need to parametrize that.
+
+	For the server case, add a use_token parameter instead of a separate
+	red_char_device_write_buffer_get_server_no_token function, as you may
+	want to parametrize that.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	reds: Use monotonic time for ticket expiration
+	Avoid time adjustment issues.
+	For instance ticket validity can change when daylight time changes.
+
+	Acked-by: Lukáš Hrázký <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	Use new common demarshallers.h
+	Avoids mismatching duplicate declarations causing potentially
+	ABI incompatibilities.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	utils: Get monotonic time in a coherent way
+	Use a single function to get monotonic time.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	display-channel: Remove useless parenthesis
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	red-stream: Propagate RedStreamSslStatus type
+	Do not convert RedStreamSslStatus enumeration type back to int.
+	This allows compilers to perform some more type safe checks.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	utils: Remove spice_get_monotonic_time_ms
+	This is a thin wrapper over g_get_monotonic_time_ms, and is called only
+	once, so we can call directly g_get_monotonic_time_ms instead.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	ci: Use release build with Meson
+	Some compiler warnings are triggered only if optimisations are
+	turned on. By default with debug build optimisations are disabled.
+
+	Acked-by: Eduardo Lima (Etrunko) <[e-mail]>
+
[phone]  Eduardo Lima (Etrunko)  <[e-mail]>
+
+	Bump meson requirement to 0.47.2
+	This new version ships the fix for the issue where 'check' keyword could
+	not be used in project definition, so we had to run that command again
+	only to check if it succeeded.
+
+	https://github.com/mesonbuild/meson/issues/3944
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Lukáš Hrázký  <[e-mail]>
+
+	red-qxl: remove an unnecessary level of indirection in create/destroy surface
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Lukáš Hrázký  <[e-mail]>
+
+	Count display channels for tablet mode check
+	Having a single QXL interface is not enough, there can be other (e.g.
+	streaming) display channels that make the tablet unusable. Add a check for the
+	number of display channels also being equal to 1. We still need the check for
+	QXL interaces, because the tablet only works with QXL.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	syntax-check: Add missing contributors names to AUTHORS
+	Acked-by: Eduardo Lima (Etrunko) <[e-mail]>
+
[phone]  Changqing Li  <[e-mail]>
+
+	spice: fix compile error
+	fix below compile error:
+	format '%d' expects argument of type 'int', but argument 6 has
+	type 'long unsigned int' [-Werror=format=]
+
+	spice compile failed on 32bit system, since upstream commit
+	9541cd2fe change %ld to %PRIdPTR, %PRIdPTR is %d, but argument
+	strm.total_out is uLong.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Eduardo Lima (Etrunko)  <[e-mail]>
+
+	meson: Fix usage of add_project_arguments()
+	This function does accept a list of arguments, so there is no need to
+	iterate over it.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Eduardo Lima (Etrunko)  <[e-mail]>
+
+	ci: Workaround asciidoc failure
+	Since commit e5a93d7a30f71f01052392d13e33e0373bccee8f asciidoc has been
+	failing. Frediano noticed that there is no such problem with Fedora 27,
+	and it looks like asciidoc version 8.6.10 in Fedora 28 is causing
+	the problem. Downgrading it to 8.6.8 seems to fix it while we don't
+	find the definite solution.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Eduardo Lima (Etrunko)  <[e-mail]>
+
+	Update gitlab-ci to use meson
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	Add support for building with meson/ninja
+	In a comparison with current autotools build system, meson/ninja
+	provides a huge improvement in build speed, while keeping the same
+	functionalities currently available and being considered more user
+	friendly.
+
+	The new system coexists within the same repository with the current one,
+	so we can do more extensive testing of its functionality before deciding
+	if the old system can be removed, or for some reason, has to stay for
+	good.
+
+	- Meson: https://mesonbuild.com
+
+	  This is the equivalent of autogen/configure step in autotools. It
+	  generates the files that will be used by ninja to actually build the
+	  source code.
+
+	  The project has received lots of traction recently, with many GNOME
+	  projects willing to move to this new build system. The following wiki
+	  page has more details of the status of the many projects being ported:
+
+	    https://wiki.gnome.org/Initiatives/GnomeGoals/MesonPorting
+
+	  Meson has a python-like syntax, easy to read, and the documentation
+	  on the project is very complete, with a dedicated page on how to port
+	  from autotools, explaining how most common use cases can be
+	  implemented using meson.
+
+	    http://mesonbuild.com/Porting-from-autotools.html
+
+	  Other important sources of information:
+
+	    http://mesonbuild.com/howtox.html
+	    http://mesonbuild.com/Syntax.html
+	    http://mesonbuild.com/Reference-manual.html
+
+	- Ninja: https://ninja-build.org
+
+	  Ninja is the equivalent of make in an autotools setup, which actually
+	  builds the source code. It has being used by large and complex
+	  projects such as Google Chrome, Android and LLVM. There is not much to
+	  say about ninja (other than it is much faster than make) because we
+	  won't interact directly with it as much, as meson does the middle man
+	  job here. The reasoning for creating ninja in the first place is
+	  explained on the following post:
+
+	    http://neugierig.org/software/chromium/notes/2011/02/ninja.html
+
+	  Also its manual provides more in-depth information about the design
+	  principles:
+
+	    https://ninja-build.org/manual.html
+
+	- Basic workflow:
+
+	  Meson package is available for most if not all distros, so, taking
+	  Fedora as an example, we only need to run:
+
+	    # dnf -y install meson ninja-build.
+
+	  With Meson, building in-tree is not possible at all, so we need to
+	  pass a directory as argument to meson where we want the build to be
+	  done. This has the advantage of creating builds with different options
+	  under the same parent directory, e.g.:
+
+	    $ meson ./build --prefix=/usr
+	    $ meson ./build-extra -Dextra-checks=true -Dalignment-checks=true
+
+	  After configuration is done, we call ninja to actually do the build.
+
+	    $ ninja -C ./build
+	    $ ninja -C ./build install
+
+	  Ninja defaults to parallel builds, and this can be changed with the -j
+	  flag.
+
+	    $ ninja -j 10 -C ./build
+
+	- Hacking:
+
+	  * meson.build: Mandatory for the project root and usually found under
+	                 each directory you want something to be built.
+
+	  * meson_options.txt: Options that can interfere with the result of the
+	                       build.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Snir Sheriber  <[e-mail]>
+
+	Support h265 in stream-channel
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	build: Prepare for 0.14.1 release
+
+	Revert "Support h265 in stream-channel"
+	This commit needs an unreleased version of spice-protocol.
+	The revert is temporary in order to get the spice-server 0.14.1 release
+	out.
+
+	This reverts commit 9f5859c3ba5e1885dec78f131f96c93bbc37bc80.
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	docs: Add documentation for the streaming device
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	Update spice-common submodule
+	This brings in the following changes:
+
+	Eduardo Lima (Etrunko) (5):
+	      ci: Fix typo: celt501 -> celt051
+	      meson: Make options accessible through parent project
+	      meson: Fix checking for python
+	      Meson: Make use of dictionary type introduced in version 0.47
+	      Meson: Make use of 'feature' option type introduced in version 0.47
+
+	Frediano Ziglio (2):
+	      ci: Fix Meson feature option
+	      Fix flexible array buffer overflow
+
+	Lukáš Hrázký (1):
+	      spice*.proto: Replace tabs with the appropriate number of spaces
+
+	Acked-by: Eduardo Lima (Etrunko) <[e-mail]>
+
[phone]  Uri Lublin  <[e-mail]>
+
+	Remove unused structs QXLDrawArea and QXLDevInfo
+	The structure usage was removed from commit
+	  2ba69f9f8819daaa3d166c4c1c7e03b121b88a95
+	  ("libspice: add surface 0 support").
+
+	They were never used by Qemu.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Lukáš Hrázký  <[e-mail]>
+
+	test-stream-device: Expect the g_log warning about invalid message
+	Fixes test-stream-device after adding a log warning about an invalid
+	message received on the stream device, glib tests fail on unexpected
+	warning messages.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	build: Fix build from tarballs
+	Following commit fcaf8d1a1, build from tarballs/make distcheck is broken
+	as spice-server-enums.h is not regenerated when building from tarballs,
+	and we don't have a -I$(top_srcdir) in our build flags, just
+	-I$(srcdir). This commit changes #include <server/spice-server-enums.h>
+	to #include <spice-server-enums.h> which avoids the problem fixed by
+	commit fcaf8d1a1 without breaking make distcheck.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Lukáš Hrázký  <[e-mail]>
+
+	Log the invalid message from the stream device
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	build: Use <> rather than "" for including spice-server-enums.h
+	When using #include "spice-server-enums.h", it will be looked up first
+	in the directory containing the file being build, which is going to be
+	$srcdir when dcc.c includes it. However, spice-server-enums.h is a
+	generated file, so it will be in $builddir, not in $srcdir. This most of
+	the time won't be causing any problems, except when you happen to have
+	an invalid spice-server-enums.h in $srcdir and you are doing an
+	out-of-tree build.
+	Using #include <spice-server-enums.h> instead allows the correct
+	spice-server-enums.h file to be looked up.
+
+	Acked-by: Lukáš Hrázký <[e-mail]>
+
[phone]  Victor Toso  <[e-mail]>
+
+	README: Report bugs to gitlab issue tracker
+	Acked-by: Snir Sheriber <[e-mail]>
+
[phone]  Eduardo Lima (Etrunko)  <[e-mail]>
+
+	build: Move spice-common to subprojects/ directory
+	The reason for this commit is that Meson expects all submodules to be
+	placed in this subdirectory, and since autotools build is more flexible
+	in this case, we make some small adjustments to configure.ac and
+	Makefile.am files to accommodate for this change.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	dcc: Rework COMPRESS_DEBUG macro
+	Rather than using
+	 #ifdef COMPRESS_DEBUG
+	   spice_info(...);
+	 #endif
+
+	we can #define COMPRESS_DEBUG to spice_debug() or to do nothing for a
+	slight readability improvement. This opportunity is used to replace
+	these spice_debug() calls with g_debug(). The "do nothing" macro is a bit
+	convoluted to ensure that we will have a compile-time check for our
+	g_debug args.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	dcc: Fix QUIC fallback in get_compression_for_bitmap()
+	There was a small regression introduced in get_compression_for_bitmap()
+	by f401eb07f dcc: Rewrite dcc_image_compress.
+	If SPICE_IMAGE_COMPRESSION_AUTO_GLZ is specified, and the bitmap has a
+	stride which is bigger than its width (ie it has padding), then
+	get_compression_for_bitmap() will return SPICE_IMAGE_COMPRESSION_OFF
+	while in that case, we used to use QUIC for compression.
+
+	This happens because that function in the AUTO_GLZ case first checks if
+	QUIC should be used, if not, it decides to use GLZ, but then decides it
+	can't because of the stride, so falls back to OFF, while it used to
+	fall back to QUIC.
+
+	This commit only slightly reworks a preexisting if (!can_lz_compress())
+	check so that it's unconditional rather than depending on the previous
+	checks having been unsuccessful.
+
+	This issue could be observed by using a spice-html5 without support for
+	uncompressed bitmaps with end-of-line padding by simply starting a f28
+	VM and connecting to it/moving the mouse cursor in it.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	dcc: Improve can_lz_compress() comment
+	Both glz_encode and lz_encode error out if the bitmap stride does not
+	match the bitmap width.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	worker: Fix 'seemless' typo in comment
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	test-stream-device: Check data are sent together
+	Check that data sent to device are collapsed in a single message.
+	The StreamChannel object is mocked in the test.
+	This checks that commit dcc3f995d9f5575e319adcfe530c477a7c294ff3
+	("stream-device: handle_data: send whole message") is doing the
+	right thing.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	test-stream-device: Factor out a function to start the test
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	test-stream-device: Put common parts in setup/teardown functions
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	test-stream-device: Check server detect and signal huge data
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	red-stream-device: Fix and check empty data messages
+	If guest sent an empty data message this was not parsed correctly.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Lukáš Hrázký  <[e-mail]>
+
+	Rename SpiceHead::id to monitor_id in the protocol
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	Update spice-common submodule
+	This brings in the following changes:
+
+	Christophe Fergeau (20):
+	      build: Update git.mk to latest version
+	      build: Remove docs/.gitignore
+	      build: Add __pycache__/*.pyc to DISTCLEANFILES
+	      log: Only install glib log handler if SPICE_DEBUG_LEVEL is set
+	      test-logging: Improve debug level tests
+	      test-region: Use GTest API
+	      test-region: Replace direct printf with g_debug() calls
+	      test-region: Don't call region_dump() by default
+	      test-region: Remove unneeded printf
+	      test-region: Replace spice_assert() with g_assert_true()
+	      test-region: Add g_assert() checks
+	      snd: Replace spice_printerr() use with g_warning
+	      swcanvas: Remove canvas_create()
+	      meson: Remove '(default: xxx)' from option description
+	      log: Remove SPICE_DISABLE_ABORT
+	      common: Remove spice_abort()
+	      build: Remove spice_common.h
+	      pixman: Use g_error() rather than g_abort()
+	      build: Define GLIB_VERSION_MIN_REQUIRED/GLIB_VERSION_MAX_ALLOWED
+	      quic: Wrap declaration/call of quic method in macros
+
+	Christophe de Dinechin (1):
+	      Add SPICE_ATTR_NORETURN on prototype of error functions
+
+	Eduardo Lima (Etrunko) (5):
+	      Add .gitlab-ci.yml file
+	      meson: Enable '-std=c99' build flag
+	      meson: Cleanup optional dependency checks
+	      Update gitlab-ci to use meson
+	      test-region: Decrease loop count by a factor of 10
+
+	Frediano Ziglio (36):
+	      test-quic: Allows to specify multiple images to test
+	      canvas_base: Rework DUMP_JPEG debugging
+	      test-quic: Increase test timeout using Meson
+	      ssl_verify: Fix build for newer LibreSSL
+	      Revert "ssl_verify: Fix build for newer LibreSSL"
+	      ssl_verify: Fix build for newer LibreSSL
+	      test-region: Create proper test for region from source code
+	      marshaller: Fix a possible leak
+	      canvas_base: Make sure top_down is a boolean
+	      marshal: Fix a bug with zero attribute
+	      ptypes: Improve some attribute documentation
+	      build: Reuse TEST_MARSHALLERS macro
+	      build: Reindent macros
+	      log: Remove spice_printerr macro
+	      test-marshallers: Check for "zero" attribute
+	      quic: Call encode from golomb_coding
+	      canvas_base: Fix minor indentation issues
+	      canvas_base: Avoid misaligned access decoding LZ4 data
+	      meson: Remove -std=c99
+	      quic: Add UPDATE_MODEL_COMP macro to iterate over channels
+	      quic: Rework PIXEL_A/PIXEL_B macros
+	      quic: Add SAME_PIXEL macro
+	      quic: Make {UN, }COMPRESS_xx macros closer
+	      quic: Add missing #undef SET_a/GET_a
+	      quic: Call directly encode_state_run from templates.
+	      quic: Add CORRELATE*/DECORRELATE* macros
+	      quic: Add APPLY_ALL_COMP macro to iterate over channels
+	      quic: Move all golomb decoding macros in a single place
+	      quic: Add DECLARE_*_VARIABLES macros
+	      quic: Introduce COPY_PIXEL macro
+	      quic: Reorder macro declarations
+	      quic: Unify rgb/non-rgb macro declarations
+	      quic: Remove duplicate file
+	      canvas_base: Check for overflows decoding LZ4
+	      canvas_base: Change spice_warning to g_warning
+	      tests: Join test-overflow and test-marshallers
+
+	Snir Sheriber (1):
+	      protocol: Add support for h265 video codec
+
+	Acked-by: Lukáš Hrázký <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	red-stream-device: Fix leaks in dispose and finalize chaining parent
+	dispose and finalize methods have to call parent relative
+	cleanup method to avoid leaking resources.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	reds: Free device chain in spice_server_destroy to avoid leaks
+	Leak detectors did not manage to find leaks, possibly as double list
+	have all elements likely with a pointer to them.
+	The reference from the agent is necessary for inserting it into
+	the list.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	glz-encoder-dict: Remove a warning compiling with CentOS 7
+	CentOS 7 compiler generate this warning:
+
+	glz-encoder-dict.c: In function 'glz_dictionary_pre_encode':
+	glz-encoder-dict.c:516:30: error: 'prev_seg_id' may be used uninitialized in this function [-Werror=maybe-uninitialized]
+	             dict->window.segs[prev_seg_id].next = seg_id;
+	                              ^
+	glz-encoder-dict.c:492:22: note: 'prev_seg_id' was declared here
+	     uint32_t seg_id, prev_seg_id;
+	                      ^
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	ci: Run an additional make check using Centos
+	Make sure we can compile and run base tests using latest Centos.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	tests: Add G_PID_FORMAT to glib compat header
+	G_PID_FORMAT was only added in glib 2.50.
+
+	Acked-by: Eduardo Lima (Etrunko) <[e-mail]>
+
[phone]  Uri Lublin  <[e-mail]>
+
+	stream-device: handle_data: send whole message
+	SPICE expects to have each frame in a single message.
+	So far the stream-device did not do that.
+	That works fine for H264 streams but not for MJPEG.
+
+	The client handles by itself MJPEG streams, and not via
+	gstreamer, and is assuming that a message contains the
+	whole frame. Since it currently not, using spice-streaming-agent
+	with MJPEG plugin, confuses the client which burns CPU
+	till it fails and keeps complaining:
+	  "GSpice-CRITICAL **: 15:53:36.984: need more input data"
+
+	This patch fixes that, by reading the whole message from the
+	device (the streaming agent) and sending it over to the client.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	build: Remove unneeded spice_common.h includes
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	red-record-qxl: Change license header to LGPLv2+
+	It's currently using a GPLv2+ header, which was probably a mistake given
+	the project overall license. It was created by a Red Hat employee, and
+	only modified by Red Hat employees since then, so the (c) Red Hat is
+	correct, and there are no other copyright holders to contact.
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	red-parse-qxl: Avoid invalid flag usage
+	self_bitmap flag is used for some complex drawing not possible
+	by QXL_DRAW_COPY commands. Having this flag set causes
+	spice-server do draw part of the screen, copy that part on new
+	allocated image and reduce network optimisations with no visual
+	changes.
+	Some drivers (like Windows 10 DOD) set this flag by mistake for
+	this command so reset it.
+
+	More details follow.
+
+	The self_bitmap flag is used for some drawing command requiring to mix
+	the frame buffer with some other image. For this specific
+	QXL_DRAW_COPY command self_bitmap is used by spice-server code during
+	cachine/sending (the reason for the cache is to cache images sent to
+	client so the relationship between the two parts of the code).
+	However the self_bitmap_image (an image created in spice-server if
+	this flags is set) is used only if src_bitmap of SpiceCopy structure
+	(the structure used to store the QXL_DRAW_COPY command inside
+	spice-server) is NULL. But in red_get_copy_ptr (red-parse-qxl.c, the
+	function that parse the QXL_DRAW_COPY command form the QXL device)
+	not having a src_bitmap is considered an error so the
+	self_bitmap_image won't be used.
+
+	Why this flag affects network performance?
+	When spice-server see this flag it update the frame buffer according
+	to the pending commands (commands to be sent or still to be drawn on
+	frame buffer). spice-server maintain a tree of commands used to reduce
+	rendering and command to send. More or less if a command is covering
+	other commands (for instance filling the entire screen with a single
+	color) the pending commands can be removed from the queue and not sent
+	to the client. However when an update of the frame buffer is requested
+	spice-server update the frame buffer removing the commands from the
+	tree but not from the client queue.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	memslot: Remove error parameter from memslot_get_virt
+	Pointers to memory allocated in user space are never NULL.
+	The only exception can be if you explicitly map memory at zero.
+	There is however no reasons for such requirement and this practise
+	was also removed from Linux due to security reasons.
+	This API looks copied from a kernel environment where valid virtual
+	addresses can be NULL.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	reds: Fix one case parsing invalid codec string
+	In case we pass something like "spice:mjpeg$%*" the last part is
+	ignore making the string parse correctly.
+	A single pair should end by either string terminator or pair terminator.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	test-codecs-parsing: Add test case
+	Check if encoder contains an invalid character.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Jonathon Jongsma  <[e-mail]>
+
+	Rename parse_video_codecs() to parse_next_video_codec()
+	The new name describes the function more accurately. Also add
+	documentation for the function.
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	reds: Reuse strspn and strcspn functions
+	These functions are in the standard C library, not well known
+	but quite useful for parsing strings.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	test-agent-msg-filter: Adjust for recent logging changes
+	Now warnings are printed through g_warning which causes the test to
+	fail. We need to use g_test_expect_message() to prevent that failure.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	qxl: Remove red_channel_printerr()
+	It was only used twice, for what looks like adhoc debugging. This commit
+	removes it, similarly to what was done for some spice_printerr() calls.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	Replace remaining spice_printerr() with g_warning()
+	The remaining occurrences of spice_printerr() are warnings when
+	something unexpected happens, they can be replaced with g_warning() so
+	that users of spice-server can redirect them with
+	g_log_set_default_handler().
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	Replace spice_printerr() use with red_channel_{debug, warning}
+	Depending on the context, we want to output a warning or just a debug
+	log.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	Remove unneeded spice_printerr() calls
+	These calls seem to have been added for debugging for a very specific
+	purpose. At the very least, they should have been using g_debug() rather
+	than spice_printerr(). This commit removes these.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	glz: Inline GET_{r,g,b} macros
+	With last changes are just used once and are straight forward.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	glz: Optimize SAME_PIXEL for RGB16
+	Do not extract all components and compare one by one, can be easily
+	compared together.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	glz: Move some macros to a common place
+	The macros for both depth are the same, reuse the definition.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	sound: Don't mute recording when client reconnects
+	When a new record channel is added, the code relies on a snd_send() call
+	in record_channel_client_constructed() to send RECORD_START to the
+	client. However, at this point, snd_send() is non-functional because
+	the red_channel_client_pipe_add() call it makes is a no-op because
+	prepare_pipe_add() makes a connection check through
+	red_channel_client_is_connected() queueing the item. This connection
+	check returns FALSE at ::constructed() time as the channel client will
+	only become connected towards the end of
+	red_channel_client_initable_init() which runs after the object
+	instantiation is complete.
+
+	This causes a bug where starting recording and then
+	disconnecting/reconnecting the client does not successfully reenable
+	recording. This is a regression introduced by commit d8dc09
+	'sound: Convert SndChannelClient to RedChannelClient'
+
+	This commit solves this issue by making PlaybackChannelClient and
+	RecordChannelClient implement GInitable, and move the code interacting
+	with the client in their _initable_init() function, as at this point the
+	objects will be able to send data.
+
+	https://bugzilla.redhat.com/show_bug.cgi?id=1549132
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	memslot: Return void* from memslot_get_virt
+	The result of this function is always cast to a pointer, there
+	is no reason to return an integer.
+	This API looks copied from a kernel environment where virtual
+	addresses can have different sizes compare to pointers.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	jpeg-encoder: Remove JPEG_IMAGE_TYPE_RGB24
+	Never used.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	jpeg-encoder: Avoid useless conversions
+	Define JpegEncoderContext as an abstract structure.
+	This allows to reduce casts.
+	Also remove some alignment warnings on some architecture like mips.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	red-record-qxl: Remove potential leak
+	On some systems you need to call g_spawn_close_pid after
+	spawning a process to avoid leaks (currently Windows).
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	replay: Use GPid and G_PID_FORMAT for portability
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	Add possibly missing headers for pthread.h
+	In some environment pthread.h is not defined but its definitions
+	are used in some headers.
+	Actually happens using MingW.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	stat-file: Exit earlier to reduce indentation
+	Just style change. Invert the if to exit earlier.
+
+	Acked-by: Christophe de Dinechin <[e-mail]>
+
+	dispatcher: Define pollfd variable only if needed
+	Acked-by: Christophe de Dinechin <[e-mail]>
+
+	Do not use bzero
+	Not defined in MingW.
+
+	Acked-by: Christophe de Dinechin <[e-mail]>
+
+	Use PRIxPTR constant for string formatting
+	These constants are meant to be used in format string for size_t
+	types. Use them for portability.
+
+	Acked-by: Snir Sheriber <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	channel: Remove unused 3rd red_channel_register_client_cbs() arg
+	It was probably meant to be used as a "user_data" argument for the
+	various callbacks, but turns out not to be used.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	sound: Do not pass unused pointer
+	Client callbacks in sound channels do not use registered
+	data so don't pass a valid pointer making clear from
+	source that the parameter is not used.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	ssl: Allow to use ECDH ciphers with OpenSSL 1.0
+	Without an explicit call to SSL_CTX_set_ecdh_auto(reds->ctx, 1), OpenSSL
+	1.0 (still used by el7) would not use ECDH ciphers (this is now
+	automatic with OpenSSL 1.1.0). This commit adds this missing call. It's
+	based on a suggestion from David Jasa
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	https://bugzilla.redhat.com/show_bug.cgi?id=1566597
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	red-worker: Remove not used include
+	poll is not used anymore by this file.
+
+	Acked-by: Lukáš Hrázký <[e-mail]>
+
+	sound: Reduce conditional compilation
+	Acked-by: Lukáš Hrázký <[e-mail]>
+
[phone]  Uri Lublin  <[e-mail]>
+
+	spice-common submodule: update url (add .git at the end)
+	With the move to gitlab.freedesktop.org the spice-common submodule
+	url changed, and now ends with .git
+
+	Update .gitmodules to reflect that.
+
+	Without this patch git submodule update (and ./autogen.sh)
+	fails on RHEL-7 (git version 1.8.3).
+	On Fedora 28 (git version 2.17.1) it succeeds as it's successfully
+	redirecting to spice-common.git url.
+
+	With git version 1.8.3:
+	$ git submodule update
+	Cloning into 'spice-common'...
+	error: RPC failed; result=22, HTTP code = 404
+	fatal: The remote end hung up unexpectedly
+	Clone of 'https://gitlab.freedesktop.org/spice/spice-common' into submodule path 'spice-common' failed
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	build: Use SPICE_CHECK_CELT051 in configure.ac
+	spice-common provides a m4 macro to check for celt, but spice-server is
+	not using it. With the recent disabling of celt in spice-common, the
+	default in spice-server got out of sync. It's better to use the same check
+	everywhere, even though in spice-server its only use is to show
+	--enable-celt051 in --help output.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Snir Sheriber  <[e-mail]>
+
+	Support h265 in stream-channel
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	ci: Add make distcheck test
+	Acked-by: Snir Sheriber <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	build: Remove unsupported --enable-automated-tests option on make distcheck
+	--enable-automated-tests option was removed in commit 6517ea5cbb07b
+	("test-display-base: Always compile with AUTOMATED_TESTS enabled").
+
+	Acked-by: Christophe de Dinechin <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	Update spice-common submodule
+	This brings in the following changes:
+
+	Christophe Fergeau (21):
+	      quic: Remove configurable RLE_PRED
+	      quic: Remove configurable PRED
+	      quic: Get rid of QUIC_RGB #define
+	      quic: Get rid of RLE_STAT #define
+	      quic: Get rid of RLE #define
+	      quic: Factor common code
+	      quic: Introduce CommonState *state variable in templates
+	      quic: s/decorrelate_drow/correlate_row
+	      quic: Add macros to make quic_tmpl.c much closer to quic_rgb_tmpl.c
+	      quic: Remove unused argument in uncompress_row{0, }
+	      quic: Use channel->correlate_row in macros
+	      quic: Add test case for compression/decompression
+	      build: Ensure we link with -lm if needed
+	      build: Disable celt 0.5.1 by default
+	      build: By default, error out if Opus is missing
+	      build: Use AM_COND_IF
+	      build: Remove checks for functions which are never called
+	      build: Remove bitops.h
+	      build: Move client sources to libspice_common_client_la_SOURCES
+	      meson: Support auto/true/false for optional dependencies
+	      meson: Remove check for vfork
+
+	Eduardo Lima (Etrunko) (7):
+	      build: Remove FIXME_SERVER_SMARTCARD hack
+	      Fix demarshaller code generator
+	      Fix field names for Smartcard protocol structures
+	      Fix cast to spice_marshaller_item_free_func function
+	      Bump glib requirements to 2.38
+	      test-quic: Fix -Wsign-compare warning
+	      Add support for building with meson/ninja
+
+	Frediano Ziglio (19):
+	      codegen: Add some comments
+	      codegen: Removed unused get_type methods
+	      protocol: Use a typedef to specify stream_id type
+	      lz: Move ENCODE_PIXEL for RGB24 and RGB32 to a common place
+	      Fix integer overflows computing sizes
+	      Write a small test to test possible crash
+	      Avoid integer overflow computing image sizes
+	      Fix generation of Smartcard channel
+	      test-overflow: Remove a leak in the test
+	      marshaller: Remove initial underscore from static function
+	      codegen: Remove duplicate client and server code from ChannelType::resolve
+	      Check for messages with duplicate names inside a channel
+	      Check for messages with duplicate values inside a channel
+	      lz: Optimise SAME_PIXEL for RGB16
+	      lz: Inline GET_{r,g,b} macros
+	      quic: Remove 'no-inline' hack
+	      quic: Remove some too strict asserts in hot paths
+	      quic: Fix endianness encoding
+	      quic: Use __builtin_clz if available
+
+	Jonathon Jongsma (2):
+	      Remove extra self parameter from member function
+	      miLineArc(): initialize edge1, edge2
+
+	Victor Toso (1):
+	      messages: document limitation of id in StreamCreate
+
+	build: Explicitly disable celt051 when running make distcheck
+	With spice-common commit 72b0d603e12, SPICE_CHECK_CELT051 will error out
+	if celt051-devel is installed, but neither --enable-celt051 nor
+	--disable-celt051 are specified. This could be a problem when running
+	make distcheck, so this commit adds --disable-celt051 so that we never
+	hit that error.
+
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	Use "base" as pipe item base field name
+	Most of pipe items use this name for the base field.
+	This also allows to use SPICE_UPCAST macros instead of a long
+	SPICE_CONTAINEROF.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	reds: Remove possible alignment warning using Clang
+	Although capabilities inside link message are handled as arrays
+	of 4 bytes unsigned integers we don't need capabilities to be
+	aligned to 4 bytes just to call g_memdup so use a pointer to
+	uint8_t instead.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	red-channel-client: Do not allocate iovec array statically in the class
+	This array is just used locally in red_channel_client_handle_outgoing
+	so declare it there.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	ci: Pass --enable-celt051 to configure
+	It's now mandatory to explicitly enable/disable CELT at configure time
+	if celt051-devel is installed.
+
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Lukáš Hrázký  <[e-mail]>
+
+	Remove excessive logging of an area being drawn
+	Removes debug messages that are logged on every draw, spamming the log
+	excessively when debugging.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	ci: Add some needed Valgrind suppression rule
+	From Gitlab CI:
+
+	=17955== 16 bytes in 1 blocks are possibly lost in loss record 725 of 2,079
+	==17955==    at 0x4C2DBAB: malloc (vg_replace_malloc.c:299)
+	==17955==    by 0x4011D17: tls_get_addr_tail.isra.0 (in /usr/lib64/ld-2.27.so)
+	==17955==    by 0x4017997: __tls_get_addr (in /usr/lib64/ld-2.27.so)
+	==17955==    by 0xEE4534B: gnutls_rnd (in /usr/lib64/libgnutls.so.30.20.2)
+	==17955==    by 0xEE1F254: ??? (in /usr/lib64/libgnutls.so.30.20.2)
+	==17955==    by 0xEE1F947: ??? (in /usr/lib64/libgnutls.so.30.20.2)
+	==17955==    by 0xEE231B5: ??? (in /usr/lib64/libgnutls.so.30.20.2)
+	==17955==    by 0xEE24D67: gnutls_handshake (in /usr/lib64/libgnutls.so.30.20.2)
+	==17955==    by 0xEBD4FEA: ??? (in /usr/lib64/gio/modules/libgiognutls.so)
+	==17955==    by 0x7463936: g_task_thread_pool_thread (gtask.c:1331)
+	==17955==    by 0x7A3E932: g_thread_pool_thread_proxy (gthreadpool.c:307)
+	==17955==    by 0x7A3DF29: g_thread_proxy (gthread.c:784)
+	==17955==    by 0x8284563: start_thread (in /usr/lib64/libpthread-2.27.so)
+	==17955==    by 0x859631E: clone (in /usr/lib64/libc-2.27.so)
+	==17955==
+	==17955== 32 bytes in 1 blocks are possibly lost in loss record 1,234 of 2,079
+	==17955==    at 0x4C2DBAB: malloc (vg_replace_malloc.c:299)
+	==17955==    by 0x4011D17: tls_get_addr_tail.isra.0 (in /usr/lib64/ld-2.27.so)
+	==17955==    by 0x4017997: __tls_get_addr (in /usr/lib64/ld-2.27.so)
+	==17955==    by 0xCAA5173: __cxa_get_globals (in /usr/lib64/libstdc++.so.6.0.25)
+	==17955==    by 0xCAA6186: __cxa_throw (in /usr/lib64/libstdc++.so.6.0.25)
+	==17955==    by 0xC601457: ??? (in /usr/lib64/libproxy.so.1.0.0)
+	==17955==    by 0xC5F6BB6: ??? (in /usr/lib64/libproxy.so.1.0.0)
+	==17955==    by 0xC5F7089: ??? (in /usr/lib64/libproxy.so.1.0.0)
+	==17955==    by 0xC5F7470: px_proxy_factory_get_proxies (in /usr/lib64/libproxy.so.1.0.0)
+	==17955==    by 0xC3E64E3: ??? (in /usr/lib64/gio/modules/libgiolibproxy.so)
+	==17955==    by 0x7463936: g_task_thread_pool_thread (gtask.c:1331)
+	==17955==    by 0x7A3E932: g_thread_pool_thread_proxy (gthreadpool.c:307)
+	==17955==    by 0x7A3DF29: g_thread_proxy (gthread.c:784)
+	==17955==    by 0x8284563: start_thread (in /usr/lib64/libpthread-2.27.so)
+	==17955==    by 0x859631E: clone (in /usr/lib64/libc-2.27.so)
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	ci: Merge new Valgrind suppression rule from official glib.supp
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	glz-encoder: Avoid double byte swap sending image magic
+	encode_32 already deals with endian, don't swap twice.
+	Tested with a ppc64 server machine and a x64 client.
+
+	This looks the reverse of a previous patch (59c6c82) supposed to fix big
+	endian machine. encode_32 has been always:
+
+	static inline void encode_32(Encoder *encoder, unsigned int word)
+	{
+	    encode(encoder, (uint8_t)(word >> 24));
+	    encode(encoder, (uint8_t)(word >> 16) & 0x0000ff);
+	    encode(encoder, (uint8_t)(word >> 8) & 0x0000ff);
+	    encode(encoder, (uint8_t)(word & 0x0000ff));
+	}
+
+	while encode basically is similar to a putc on a FILE stream so is writing
+	numbers from host endian to big endian order.
+	The "main" endian (the one more tested since ever) is host/guest being
+	little endian. So if you call encode_32 with a 0x01020304 you get 4 bytes
+	in the order 1, 2, 3, 4.
+	Before and after 59c6c82 LZ_MAGIC was defined as:
+	  #define LZ_MAGIC (*(uint32_t *)"LZ  ")
+	so on little endian this was 0x4c, 0x5a, 0x20, 0x20 that is 0x20205a4c
+	which written through encode_32 become 0x20, 0x20, 0x5a, 0x4c so we can say
+	that at the end on the network we must have 0x20, 0x20, 0x5a, 0x4c.
+	On big endian however LZ_MAGIC got the value 0x4c5a2020 which written
+	through encode_32 get 0x4c, 0x5a, 0x20, 0x20 which is the opposite
+	expected. So patch 59c6c82 reverted the order having again 0x20, 0x20,
+	0x5a, 0x4c on the network.
+	However commit 5a7e587 (spice-common), in an attempt to avoid double
+	swapping on LZ, changed LZ_MAGIC to
+	  #define LZ_MAGIC 0x20205a4c
+	breaking endianness again for GLZ code.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	README: Update required spice protocol version
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	worker: Remove display_is_connected()
+	It's only called once, and when it's called, we will have dereferenced
+	worker->display_channel a few lines before in
+	display_channel_set_monitors_config_to_primary(), so this cannot be
+	NULL. The 'if (worker->display_channel)' check can thus be removed, so
+	display_is_connected() becomes just red_channel_is_connected().
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	worker: Use more local vars in dev_create_primary_surface
+	There's already a 'display' variable equal to worker->display_channel
+	which is not consistently used. This commit also adds a new 'channel'
+	local variable to limit the number of  upcasts to RedChannel.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	char-device: Avoid possible invalid function pointer cast
+	This is reported by GCC 8.0.1 (Fedora 28).
+	Instead of doing a possible invalid cast destroy and create the
+	queue again.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	red-channel: Avoid possible invalid function pointer type cast
+	Avoid casting function pointer with different argument providing
+	a proper utility instead.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	event-loop: Avoid possible compiler warning
+	With GCC 8.0.1 (Fedora 28), cast to different function pointer
+	can lead to warnings, like:
+
+	  event-loop.c: In function ‘watch_update_mask’:
+	  event-loop.c:146:42: error: cast between incompatible function types from ‘gboolean (*)(GIOChannel *, GIOCondition,  void *)’ {aka ‘int (*)(struct _GIOChannel *, enum <anonymous>,  void *)’} to ‘gboolean (*)(void *)’ {aka ‘int (*)(void *)’} [-Werror=cast-function-type]
+	       g_source_set_callback(watch->source, (GSourceFunc)watch_func, watch, NULL);
+	                                          ^
+	  cc1: all warnings being treated as errors
+
+	As g_source_set_callback expect a function pointer which type
+	changes based on the type of source (so is expected) silent
+	the possible warning.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
[phone]  Snir Sheriber  <[e-mail]>
+
+	docs: Update links in README and manual
+	Acked-by: Eduardo Lima (Etrunko) <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	glz-encoder: Do not discard top bits of lower part sending 64 bit ints
+	When GLZ code attempts to send a 64 bit integer the 8 top bit of
+	the lower (32 bits) part of the number are stripped due to a bug.
+
+	This was discovered by Zhongqiang Huang <[e-mail]>
+
+	Reported-by: Zhongqiang Huang <[e-mail]>
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	stream-channel: Implements monitors_config
+	Although not necessary for a single monitor DisplayChannel implementation
+	this make the DisplayChannels more coherent from the client
+	point of view.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
[phone]  Victor Toso  <[e-mail]>
+
+	tests: add test-listen executable to gitignore
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	qxl: Remove 'blackness' and 'invers' put/get methods
+	SpiceWhiteness/SpiceBlackness/SpiceInvers are 3 typedef for the same
+	type, no need to have 3 identical red_put_xxx/red_get_xxx methods.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	qxl: Remove red_put_blend()
+	SpiceBlend is a typedef to SpiceCopy, and red_put_blend() and
+	red_put_copy() are identical, so we can add a #define red_put_blend
+	red_put_copy similar to the one we already have for red_get_blend.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	common-graphics-channel: Use manual flushing on stream to decrease packet fragmentation
+	In order to use the new TCP_CORK feature, disable auto flush.
+
+	Depending on channel implementation and purpose of the channel enabling
+	blindly for all channels could cause performance issues, specifically if
+	flush is not done at the right time.
+	CommonGraphicsChannel channels were tested to make sure is not that case.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	red-stream: Implements flush using TCP_CORK
+	Cork is a system interface implemented by Linux and some *BSD systems to
+	tell the system that other data are expected to be written to a socket.
+	This allows the system to reduce network fragmentation waiting for network
+	packets to be complete.
+
+	Using some replay capture and some instrumentation resulted in a
+	bandwith reduction of 11% and a packet reduction of 56%.
+
+	The tests was done using replay utility so results could be a bit different
+	from real cases as:
+	- replay goes as fast as it can, for instance packets could
+	  be merged by the kernel decreasing packet numbers and a bit
+	  byte spent (this actually make the following improves worse);
+	- there are fewer channels (no much cursor, sound, etc).
+	The following tests shows count packet and total bytes from server to
+	client using a real network. I used a direct cable connection using 1gb
+	connection and 2 laptops.
+
+	cork: 537 1582240
+	cork: 681 1823754
+	cork: 524 1583287
+	cork: 538 1582350
+	no cork: 1329 1834630
+	no cork: 1290 1829094
+	no cork: 1289 1830164
+	no cork: 1317 1833589
+	no cork: 1320 1835705
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	red-stream: Define interface for manual flush
+	The writing to network was always immediate.
+	Every write in the stream causes a write to the OS.
+	This can have some penalty if you don't write large data as network
+	packets can be more fragmented or you encrypt data in smaller chunks
+	(when data are encrypted some padding is added then data is split in
+	multiple of encryption block which is usually the size of encryption
+	key and this is done for every write).
+	Define an interface to allow higher levels code to tell low level when
+	data should be sent to remote or when can wait more data.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	ci: Workaround bug in Valgrind detecting memcpy instead of memmove
+	Due to a bug in current packaged Valgrind in the CI (1:3.13.0-13.fc27)
+	check-valgrind is failing with:
+
+	==17986== Source and destination overlap in memcpy_chk(0x72c060, 0x72c068, 33)
+	==17986==    at 0x4C344F0: __memcpy_chk (vg_replace_strmem.c:1581)
+	==17986==    by 0x40E7E9: check_vmc_error_message (test-stream-device.c:166)
+	==17986==    by 0x40EFD4: test_stream_device_format_after_data (test-stream-device.c:349)
+	==17986==    by 0x7A012E9: test_case_run (gtestutils.c:2157)
+	==17986==    by 0x7A012E9: g_test_run_suite_internal (gtestutils.c:2241)
+	==17986==    by 0x7A0121A: g_test_run_suite_internal (gtestutils.c:2253)
+	==17986==    by 0x7A014C1: g_test_run_suite (gtestutils.c:2329)
+	==17986==    by 0x7A014E0: g_test_run (gtestutils.c:1594)
+	==17986==    by 0x40951A: main (test-stream-device.c:410)
+	==17986==
+
+	By default during CI build _FORTIFY_SOURCE is enabled, which turns memmove
+	into __memmove_chk, which is wrongly turned into __memcpy_chk when running
+	under Valgrind.
+	Setting _FORTIFY_SOURCE to 0 prevents the use of __memmove_chk, and avoids
+	triggering the Valgrind bug.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	Slight simplification of red_channel_client_push() logic
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	cursor: Rename cursor_marshall to red_marshall_cursor
+	The name is more consistent with red_marshall_cursor_init.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	cursor: Delay release of QXL guest cursor resources
+	There's an implicit API/ABI contract between QEMU and SPICE that SPICE
+	will keep the guest QXL resources alive as long as QEMU can hold a
+	pointer to them. This implicit contract was broken in 1c6e7cf7 "Release
+	cursor as soon as possible", causing crashes at migration time.
+	While the proper fix would be in QEMU so that spice-server does not need
+	to have that kind of knowledge regarding QEMU internal implementation,
+	this commit reverts to the pre-1c6e7cf7 behaviour to avoid a regression
+	while QEMU is being fixed.
+
+	This version of the fix is based on a suggestion from Frediano Ziglio.
+
+	https://bugzilla.redhat.com/show_bug.cgi?id=1540919
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	test-stream-device: Test we can read empty capabilities
+	Code can have problems reading empty messages, check we can
+	handle it.
+
+	Acked-by: Christophe de Dinechin <[e-mail]>
+
+	stream-device: Handle capabilities
+	Handle capabilities from guest device.
+	Send capability to the guest when device is opened.
+	Currently there's no capabilities set on the message sent.
+	On the tests we need to discard the capability message before
+	reading the error.
+
+	Acked-by: Christophe de Dinechin <[e-mail]>
+
+	stream-device: Factor out function to fill message headers
+	This function will be reused to initialise different message
+	headers.
+
+	Acked-by: Christophe de Dinechin <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	red-parse-qxl: Remove unused device_data field
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	cursor: Consistently use g_memdup() for cursor data
+	Currently, red-parse-qxl.c uses g_malloc+memcpy to duplicate the cursor
+	data when it could use g_memdup() instead. red-stream-device.c does the
+	same thing but uses spice_memdup(). This commit makes use of g_memdup()
+	in both cases so that this memory is consistently allocated through
+	glib.
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	syntax-check: Add missing contributors names to AUTHORS
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Lukáš Hrázký  <[e-mail]>
+
+	Rename the virtio port for streaming
+	The name 'com.redhat.stream.0' is too generic and in no way denotes it
+	belongs to SPICE. It is preferred to have the project's domain in the
+	name and Red Hat doesn't own the project. Rename it to
+	org.spice-space.stream.0.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	video-stream: Improve RedUpgradeItem documentation
+	Artifacts are due to lossy compression of streaming
+
+	Acked-by: Uri Lublin <[e-mail]>
+
+	Use --enable-extra-checks option provided by spice-common
+	Reuse option from common code.
+	Also reuse spice_extra_checks constant instead of using the preprocessor
+	macro directly.
+
+	Acked-by: Eduardo Lima (Etrunko) <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	valgrind: Ignore some library leaks
+	Ignore getaddrinfo and libproxy leaks.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	test-listen: Increase failure timeout
+	The timeout is too short when the test run under Valgrind
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	ci: Add glib-networking package
+	This is required by the new test-listen test to connect using
+	TLS.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	video-stream: Document the usage of RedUpgradeItem structure
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	test-listen: Fix some use after free
+	Do not dereference thread_data after has been freed.
+
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Eduardo Lima (Etrunko)  <[e-mail]>
+
+	Rename stream-device.[ch] to red-stream-device.[ch]
+	In order to avoid confusion with file named stream-device.h, from
+	spice-protocol.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	test-listen: Add Unix socket test
+
+	test-listen: Add TLS test
+
+	test-listen: Add event loop helpers
+	These factor a bit of common code, and more importantly, help with
+	freeing all event loop related data at the end of each test.
+
+	test-listen: Add test case for port/address configuration
+	This test case will be testing the external spice-server API to
+	configure the address/port it's listening on. For now it sets up a
+	listening server, spawns a thread which is going to connect to that
+	port, and check it gets the REDQ magic upon connection. It will be
+	extended to test for Unix sockets, TLS sockets, ...
+
+	tests: basic-event-loop: Silence debug message
+	There is currently a debug printf which is always shown when a mainloop
+	event is triggered. This is unlikely to be useful unless one is
+	debugging the event loop code.
+
+	build: Bump glib version
+	From spice-gtk b312ca08 commit:
+	"    At the moment:
+	    - Fedora 26 has 2.52
+	    - Fedora 25 has 2.50
+	    - Fedora 24 has 2.48
+	    - CentOS 7 has 2.46
+	    - Debian 9 has 2.50"
+
+	RHEL6 only have 2.28, but glib 2.32 is only used in a test case at the
+	moment.
+
+	reds: Close sockets when failing to watch them
+	Currently if we fail to set up the watch waiting for accept() to be
+	called on the socket, we still keep the network socket(s) open even if we
+	are not going to be able to use it. This commit makes sure it's closed a
+	set to -1 when such a failure occurs rather than having a half
+	initialized spice-server instance.
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	red-record-qxl: fix clang warning
+	Fix clang warning:
+
+	red-record-qxl.c:893:13: error: variable 'fd_in' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
+	        if (ret)
+
+	This is technically impossible but is not on a hot path.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	dcc: Remove unused channel parameter
+	Acked-by: Snir Sheriber <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	ci: Fix compiling of some functions
+	Address sanitizer use a larger stack than normal compiled programs
+	making the build fails. This causes this error on GitLab CI system:
+
+	stream-device.c: In function 'stream_device_partial_read':
+	stream-device.c:182:1: error: the frame size of 32992 bytes is larger than 20460 bytes [-Werror=frame-larger-than=]
+
+	Allow larger stack on "makecheck" to avoid this issue.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	stream-device: Create channels before first non-main channel connection
+	Due to ticket expiration, it is possible that the streaming channels for
+	the client are created after the ticket expires. Currently, streaming
+	channels are created dynamically when the guest starts streaming to the
+	server, which can happen at any time (for instance if you decide to start
+	the graphic server manually).
+	If the ticket has expired before the streaming channel is created,
+	authentication will fail and the client will not be able to connect.
+	To avoid this, create the channels when the first main channel connection
+	is made. This ensures that client will connect to all streaming channels.
+	This could be considered a temporary solution. There may be other
+	situations where it would be useful to connect new channels after the
+	ticket has expired, but enabling this behavior would require protocol
+	changes and a careful analysis of security implications.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	stream-device: Separate declaration in a separate header
+	Move public declaration (stream_device_connect) from char-device.h
+	to a new stream-device.h.
+	Add type declaration for StreamDevice.
+	This allows to use the type outside the implementation file and makes it
+	easier to extend the interface without changing char-device.h header.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Eduardo Lima (Etrunko)  <[e-mail]>
+
+	build: Rename spice-server-enums.tmpl.[ch] to spice-server-enums.[ch].tmpl
+	This is a preparation for meson build, which has built-in support for
+	generating enums, but requires the template files to be renamed. It uses
+	the basename of template files to generate the output, and in this case
+	it would be the same file for both '.c' and '.h'. Ideally meson would
+	let us specify the name of the output files, but this is not the case.
+
+	Without renaming, the following error happens:
+
+	Meson encountered an error in file server/meson.build, line 30, column 0:
+	Tried to create target "spice-server-enums.tmpl", but a target of that
+	name already exists.
+
+	Reference: http://mesonbuild.com/Gnome-module.html#gnomemkenums
+
+	Note that by the time of this commit, the documentation is not accurate
+	and does not mention the fact that output files will get the base name
+	of the template files if they are specified, I submitted a pull request
+	to meson fixing this detail in docs:
+
+	   https://github.com/mesonbuild/meson/pull/3191
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	test-stream-device: Check we don't read past data message
+	Test case for the issue fixed by previous commit.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	stream-device: Do not read past data message
+	If data message is followed by another message, it's theoretically
+	possible that device loses the sync with the guest.
+	The actual Qemu and streaming agent implementation avoids it, but better to
+	make sure this can't happen in the server code too.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	stream-device: Workaround Qemu bug closing device
+	Previous patch causes a bug in Qemu if the patch
+	46764fe09ca2e0f15c0981a672c166ed8cf57e72 ("virtio-serial: fix segfault
+	on disconnect") is not included in that version of Qemu (patch present in
+	version 2.10.0).
+	This crash happens when device is closed during a write operation.
+	For SPICE character device, spice_server_char_device_wakeup is called
+	to write data which handles both read and write pending operations.
+	As we want to close the device but we can't do it inside the handler
+	without causing a crash, this commit schedules a timer that will close the
+	guest device outside this callback.
+	The proper solution would be to patch Qemu but making sure of this is not
+	so easy, hence this workaround in spice-server.
+	Code is marked with some comments to remember to remove this
+	hack in a safe future.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	stream-device: Disable guest device on errors
+	Once the device is an error state, we don't want the guest to keep
+	reading/writing to it, especially as this could put the device in an
+	inconsistent state. This commit disables the device when an error occurs to
+	prevent further unintended use of the device by the guest.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	stream-device: Implement properly device reset on open/close
+	Due to the way Qemu handle the device, when an error occurs we must consume
+	all pending data inside the callback which reads data from the device.
+	If we don't flush this data, the next time spice-server tries to read from
+	the device (after the guest closes/reopens it), we'll be getting stale
+	data. This can happen because we cannot prevent the guest from writing to
+	the device even after it got in an error state.
+	This needs to be done within this callback, as QEMU returns 0 if you call
+	SpiceCharDeviceInterface::read() outside of it. QEMU invokes this callback
+	through a call to spice_server_char_device_wakeup.
+	On the test now we must test that we receive an error from the device.
+	Previously we checked that last part of the data was not read. Now
+	potentially all data are read, so we need another way to check the device
+	detected the error.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	build: Update spice-common submodule
+	This includes some rendering fixes.
+
+	Frediano Ziglio (19):
+	      proto: Add some documentation to stream_report message
+	      protocol: Allow to specify a surface will be streamed
+	      canvas-base: Fix width computation for palette images
+	      canvas: Simplify code using spice_memdup
+	      canvas: Remove possible leak on LZ decompression failure
+	      lz: Avoid temporary variable
+	      lz: Simplify code
+	      lz: Remove unused encode_level and only assigned io_start
+	      canvas: Move PixmanData to C file
+	      canvas: Remove mutex field from PixmanData
+	      canvas: Remove Windows bitmap allocation
+	      canvas: Remove unused dc parameter from surface_create
+	      canvas: Remove dc parameter from SwCanvas::put_image
+	      canvas: Remove dc fields from CanvasBase and LzDecodeUsrData
+	      canvas: Unify __surface_create_stride and surface_create_stride
+	      canvas: Remove unused include header
+	      canvas: Prevent some error compiling spice-gtk
+	      canvas: Fix some semi transparent drawing
+	      canvas: Use SPICE_UNALIGNED_CAST to avoid -Wcast-align warnings
+
+	Pavel Grunt (1):
+	      Remove GDI canvas
+
+	Paweł Pękala (1):
+	      Fix build with LibreSSL
+
+	Acked-by: Snir Sheriber <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	test-stream-device: Test batched multiple messages
+	Test all batched (send together) messages are handled correctly
+	and device is not stuck.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	test-stream-device: Better Qemu emulation for data reading
+	Qemu does not trigger a new data read if we don't read all data in
+	the buffer.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	stream-device: Implement mouse movement
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	stream-device: handle cursor from device
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	stream-device: Avoid device to get stuck if multiple messages are batched
+	If messages are sent together by the agent the device is reading
+	only part of the data. This cause Qemu to not poll for new data and
+	stream_device_read_msg_from_dev won't be called again.
+	This can cause a stall. To avoid this continue handling data
+	after a full message was processed.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	reds: Disable TLS 1.0
+	TLS 1.0 is considered now insecure.
+	TLS 1.1 was introduced in 2006.
+	Our SPICE clients uses OpenSSL to use TLS and the support for TLS 1.1
+	in OpenSSL was introduced in 2006 too so even in systems like
+	Windows XP which are not officially supporting TLS 1.0 will work
+	with SPICE and TLS 1.1.
+	This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1521053.
+
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Christophe de Dinechin  <[e-mail]>
+
+	Add mention of fall-through comments
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	Add mention of header guards
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	style: Update style to include some C++ element
+	This style is used by other SPICE projects like spice-streaming-agent.
+	See discussion "Coding style and naming conventions for C++" at
+	https://lists.freedesktop.org/archives/spice-devel/2018-January/041562.html.
+
+	Acked-by: Lukáš Hrázký <[e-mail]>
+
[phone]  Christophe de Dinechin  <[e-mail]>
+
+	Fix indentation in macro example
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	Fix grammatical error
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	Update copyright date
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	utils: Avoid possible unaligned access
+	Code in rgb32_data_has_alpha possibly generate this warning using
+	clang:
+
+	utils.c:35:16: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'uint32_t *' (aka 'unsigned int *') increases required alignment from 1 to 4 [-Werror,-Wcast-align]
+	        line = (uint32_t *)data;
+	               ^~~~~~~~~~~~~~~~
+
+	Although the images are expected to be all aligned in this respect
+	use byte access on the data instead. This, beside fixing the alignment
+	issue also avoid problem with big endian machines (images in SPICE are
+	expected to have the alpha channel as the forth byte).
+
+	Acked-by: Victor Toso <[e-mail]>
+
+	red-common: Avoid some not used warning using clang
+	clang reports lot of warnings like:
+
+	spicevmc.c:47:1: error: unused function 'RED_CHAR_DEVICE_SPICEVMC_CLASS' [-Werror,-Wunused-function]
+	SPICE_DECLARE_TYPE(RedCharDeviceSpiceVmc, red_char_device_spicevmc, CHAR_DEVICE_SPICEVMC);
+	^
+	./red-common.h:110:43: note: expanded from macro 'SPICE_DECLARE_TYPE'
+	    static inline ModuleObjName ## Class *G_PASTE(G_PASTE(RED_,OBJ_NAME),_CLASS)(void *klass) \
+	                                          ^
+
+	They are all static inline function and usually should not generate
+	warnings but for some reasons they do.
+
+	Acked-by: Victor Toso <[e-mail]>
+
+	sound: Avoid cast that could cause alignment problems
+	clang is reporting:
+
+	sound.c:292:16: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'uint32_t *' (aka 'unsigned int *') increases required alignment from 1 to 4 [-Werror,-Wcast-align]
+	        data = (uint32_t *)packet->data;
+	               ^~~~~~~~~~~~~~~~~~~~~~~~
+
+	however we are using memcpy to access "data" pointer so there's no
+	need to use uint32_t pointer. Also considering we don't do math with
+	that pointer.
+
+	Acked-by: Victor Toso <[e-mail]>
+
+	Avoid some alignment warnings using clang
+	clang reports may warnings like:
+
+	test-display-base.c:252:11: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'uint32_t *' (aka 'unsigned int *') increases required alignment from 1 to 4 [-Werror,-Wcast-align]
+	    dst = (uint32_t *)bitmap;
+	          ^~~~~~~~~~~~~~~~~~
+
+	Use SPICE_ALIGNED_CAST/SPICE_UNALIGNED_CAST macros in common/mem.h to
+	mark the cast safe or possibly unsafe.
+
+	Acked-by: Victor Toso <[e-mail]>
+
+	tests: Avoid some possible not initialized warning from Clang
+	Not really possible but clang raise these warnings:
+
+	test-sasl.c:555:13: error: variable 'is_ok' is uninitialized when used here [-Werror,-Wuninitialized]
+	        if (is_ok) {
+	            ^~~~~
+	test-sasl.c:553:22: note: initialize the variable 'is_ok' to silence this warning
+	        uint8_t is_ok;
+	                     ^
+	                      = '\0'
+
+	test-gst.c:792:18: error: variable 'height' is used uninitialized whenever '&&' condition is false [-Werror,-Wsometimes-uninitialized]
+	    spice_assert(gst_structure_get_int(s, "width", &width) &&
+	                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+	../../spice-common/common/log.h:91:17: note: expanded from macro 'spice_assert'
+	    if G_LIKELY(x) { } else {                           \
+	                ^
+	/usr/include/glib-2.0/glib/gmacros.h:376:60: note: expanded from macro 'G_LIKELY'
+	                                                           ^~~~
+	/usr/include/glib-2.0/glib/gmacros.h:370:8: note: expanded from macro '_G_BOOLEAN_EXPR'
+	   if (expr)                                    \
+	       ^~~~
+	test-gst.c:799:17: note: uninitialized use occurs here
+	    bitmap->y = height;
+	                ^~~~~~
+	test-gst.c:792:18: note: remove the '&&' if its condition is always true
+	    spice_assert(gst_structure_get_int(s, "width", &width) &&
+	                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+	../../spice-common/common/log.h:91:17: note: expanded from macro 'spice_assert'
+	    if G_LIKELY(x) { } else {                           \
+	                ^
+	/usr/include/glib-2.0/glib/gmacros.h:376:60: note: expanded from macro 'G_LIKELY'
+	                                                           ^
+	/usr/include/glib-2.0/glib/gmacros.h:370:8: note: expanded from macro '_G_BOOLEAN_EXPR'
+	   if (expr)                                    \
+	       ^
+	test-gst.c:791:23: note: initialize the variable 'height' to silence this warning
+	    gint width, height;
+	                      ^
+	                       = 0
+
+	Acked-by: Victor Toso <[e-mail]>
+
+	replay: Do not use obsolete set_mm_time callback
+	Marked as obsolete with clang and some options is detected as
+	error.
+
+	Acked-by: Victor Toso <[e-mail]>
+
+	char-device: Avoid to use unaligned memory
+	This causes some warnings with clang:
+
+	char-device.c:898:29: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'uint32_t *' (aka 'unsigned int *') increases required alignment from 1 to 4 [-Werror,-Wcast-align]
+	    write_to_dev_size_ptr = (uint32_t *)spice_marshaller_reserve_space(m, sizeof(uint32_t));
+	                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+	char-device.c:899:31: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'uint32_t *' (aka 'unsigned int *') increases required alignment from 1 to 4 [-Werror,-Wcast-align]
+	    write_to_dev_tokens_ptr = (uint32_t *)spice_marshaller_reserve_space(m, sizeof(uint32_t));
+	                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+	This also fixes some minor endianness issue (on big endian machine
+	integers were not properly encoded).
+
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	reds: Remove stream watch handling link in a single place
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	stream-channel: Tell client we are just streaming data
+	This give an hint to client which can optimise rendering.
+
+	Acked-by: Christophe de Dinechin <[e-mail]>
+
+	red-stream: Handle reading of 0 bytes in red_stream_async_read
+	Currently red_stream_async_read cannot handle read of 0 bytes.
+	This would cause a wrong assert in async_read_handler.
+	Fixing the assert would just make the code wrongly detect a
+	disconnection (usually a return of 0 from read is handled that
+	way but happens also if you try to read 0 bytes).
+	Current callers of these function does not pass 0 as size however
+	handling data protocols having data_length+data this can happen
+	and is handled manually in red_sasl_handle_auth_steplen.
+	Avoid needing manually to check for this condition.
+
+	Acked-by: Christophe de Dinechin <[e-mail]>
+
+	lz4-encoder: Remove useless header include
+	After 497b8042dcc135f4c5f6b77a971cc6aaa661c094
+	("lz4-encoder: Use GUINT32_TO_BE instead of htonl") patch this header
+	is not needed.
+
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	dcc-send: Avoid to use unaligned memory
+	This causes some warnings with clang:
+
+	dcc-send.c:1799:28: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'uint32_t *' (aka 'unsigned int *') increases required alignment from 1 to 4 [-Werror,-Wcast-align]
+	    num_surfaces_created = (uint32_t *)spice_marshaller_reserve_space(m2, sizeof(uint32_t));
+	                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+	This also fixes some endianness issue (on big endian machine integers
+	were not properly encoded).
+
+	Acked-by: Victor Toso <[e-mail]>
+
+	lz4-encoder: Use GUINT32_TO_BE instead of htonl
+	Just a style change, almost of the code use similar macros for such
+	tasks.
+
+	Acked-by: Victor Toso <[e-mail]>
+
+	utils: Use const for rgb32_data_has_alpha data argument
+	There's no reason to change data passed, the function just check
+	the alpha channel of the image.
+
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	tests: Remove test-just-sockets-no-ssl
+	This call sequence is included in test-display-base used in different
+	tests, no reason to have this test.
+	Also this test is not actually used for automated tests.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	red-stream: Remove AsyncRead::stream
+	AsyncRead is always included in RedStream and there are only
+	a possible operation pending on a RedStream.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	red-stream: Reuse red_stream_disable_writev function
+	The same function is used to reset writev field in SASL code.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	basic-event-loop: Document why code does not use default GLib context
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	Minor compatibility with FreeBSD system
+	Some additional header are needed to avoid undefined types.
+	SOL_TCP and IPPROTO_TCP have the same value in Linux but SOL_TCP
+	is not defined in FreeBSD.
+	Provide pthread_setname_np using pthread_set_name_np (same parameters).
+
+	Patch is based on a patch from Oleg Ginzburg <[e-mail]>
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	red-parse-qxl: Copy correctly brush position
+	This issue caused the glitches using the rectangular selection
+	tool in PaintShop 6.
+
+	The line was removed accidentally by "red_parse_qxl: fix throwing
+	away drawables that have masks" (812b65984d286414170c6243bd3323b73a405ec3)
+
+	Acked-by: Pavel Grunt <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	test-display-base: Do not use obsolete set_mm_time callback
+	Marked as obsolete with clang and some options is detected as
+	error.
+
+	Acked-by: Uri Lublin <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	red-stream: Encapsulate all authentication state in RedSASLAuth
+	Instead of having half state in RedSASL and half in RedSASLAuth
+	move everything in RedSASLAuth. This also reduces memory usage
+	when we are using SASL but we finish the authentication step.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	red-stream: Unify start and step passes
+	Most of these function are identical.
+	Only difference were basically debugging message but now
+	with a proper tests are less important.
+	The mechname field is used to differentiate between first step and
+	following ones.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	red-stream: Handle properly endianness in SASL code
+	All SPICE protocol is little endian, there's no agreement on other
+	endian and currently we support only little endian so make sure
+	this will work even possibly running on a big endian machine.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	Handle SASL initialisation mainly in red-stream.c
+	Asynchronous code jumping from a file to another is tedious to read
+	also having code handling the same stuff in two files does not look
+	a good design.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	test-sasl: Test how to server reports the failure
+	The server on failure can just disconnect the client or report the
+	error. The error report can be done using new protocol 2 or just
+	a number (like protocol 1).
+	Detect the failure report to make possible to check it.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	test-sasl: Add tests for different failures and cases
+	Use some flags to specify which behaviour to change and different test
+	cases to test them.
+	Some cases specify when client stop sending data at different steps of
+	the process.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	test-sasl: Add tests for different mechanism names
+	Try different connections with different tricky names.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	test-sasl: Base test, connect using SASL
+	Create a thread that emulates a client and starts SASL authentication
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	test-sasl: Add code to mocking functions to test state
+	Check some functions are called in a given sequence.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	test-sasl: Initial SASL test
+	Not currently working, is defining SASL functions used by the code.
+	As the symbols defined in the objects have more priority than the ones
+	defined by the libraries these function take precedence compared to
+	system library.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	tests: Avoid cast from integer of wrong size
+	These cast causes warnings if a 32 bit target is used.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	test-channel: Use correct endianness for ack message
+	Network fields should be encoded as little endian.
+	This was discovered using an emulated MIPS machine.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Victor Toso  <[e-mail]>
+
+	clang: remove double promotion
+	> test-display-resolution-changes.c:55:60: error: implicit conversion
+	> increases floating-point precision: 'float' to 'double'
+	>       command->create_primary.width = 800 + sin((float)count / 6) * 200;
+	>                                             ~~~ ~~~~~~~~~~~~~^~~
+	> test-display-resolution-changes.c:56:61: error: implicit conversion
+	> increases floating-point precision: 'float' to 'double'
+	>       command->create_primary.height = 600 + cos((float)count / 6) * 200;
+	>                                              ~~~ ~~~~~~~~~~~~~^~~
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	clang: Don't compute absolute value of unsigned
+	Clang's warning on absolute-value.
+
+	> red-record-qxl.c:297:39: error: taking the absolute value of unsigned
+	> type 'uint32_t' (aka 'unsigned int') has no effect
+	>     bitmap_size = qxl->bitmap.y * abs(qxl->bitmap.stride);
+	>                                   ^
+	> red-record-qxl.c:297:39: note: remove the call to 'abs' since unsigned
+	> values cannot be negative
+	>     bitmap_size = qxl->bitmap.y * abs(qxl->bitmap.stride);
+	>                                   ^~~
+
+	> red-replay-qxl.c:471:39: error: taking the absolute value of unsigned type
+	> 'uint32_t' (aka 'unsigned int') has no effect
+	>     bitmap_size = qxl->bitmap.y * abs(qxl->bitmap.stride);
+	>                                   ^
+	> red-replay-qxl.c:471:39: note: remove the call to 'abs' since unsigned
+	> values cannot be negative
+	>     bitmap_size = qxl->bitmap.y * abs(qxl->bitmap.stride);
+	>                                   ^~~
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	display-channel: Limit number of surfaces to 1024
+	Qemu never used more than this number and today surfaces are not
+	much used so there's no reason to keep this limit so high.
+	This reduces quite a lot some internal structure
+	(DisplayChannelPrivate and DisplayChannelClientPrivate).
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	red-stream: Avoid infinite loop on sasl_encode/decode failure
+	These functions do not set errno so it is possible that errno has a
+	stale value which happens to be EAGAIN.
+	This would cause an infinite loop in functions like red_stream_write_all
+	(or potentially using the event loop).
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	red-stream: Avoid to specify 2 mech names during SASL
+	Acked-by: Snir Sheriber <[e-mail]>
+
+	red-stream: Simplify mechname matching
+	Avoid over complicated matching using quoting and a simple strstr
+	operation.
+	The mech names are separated and quoted with the same chararacter (',')
+	making possible to search for ",MECHNAME," instead of manually check for
+	prefix and suffix after the search for "MECHNAME".
+
+	Acked-by: Snir Sheriber <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	main-channel-client: Do not call red_channel_client_begin_send_message if we are not sending a message
+	In case mcc->priv->initial_channels_list_sent is false we didn't
+	marshall any message so we should not call
+	red_channel_client_begin_send_message.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	red-stream: Use mechname for mechname
+	There's no reason to copy mechname into mechlist to use mechlist
+	instead of mechname.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	red-stream: Remove SASL "data" field leak
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	reds: Remove argument from reds_handle_link
+	RedLinkInfo stores reds in it no need to pass every time.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	inputs-channel: Move spice_server_kbd_leds to InputsChannel
+	This avoids to expose some detail about the channel.
+	Like other APIs implement it move close to the part that handle
+	it instead of have everything in reds.c.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	display-channel: Reuse GLIST_FOREACH macro in drawable_remove_from_pipes
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	red-pipe-item: Move typedef at the top to avoid a "struct RedPipeItem"
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	dcc: Remove obsolete comment
+	RedPipeItem does not contain a link anymore.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	stat-file: Protect flags field with atomic operation
+	Coverity complaint that this field should be protected by
+	a mutex as other accesses are with the mutex locked.
+	Use atomic operation. Not in an hot path in any case.
+
+	Acked-by: Uri Lublin <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	build-sys: Ignore generated test-channel and test-stream-device files
+	Acked-by: Uri Lublin <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	reds: Remove unused SASL_DATA_MAX_LEN define
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	reds: Remove possible leak during SASL authentication
+	We need to free the connection if the mechanism name is wrong
+
+	Acked-by: Uri Lublin <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	display-channel: Remove unused parameter from drawable_remove_dependencies
+	It's not used since its introduction at 4e8f24e3510ce8cb3fa6b.
+
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	Move RedUpgradeItem declaration in video-stream.h
+	This structure is used to send a message related to streams.
+	There are already other items defined in video-stream.h so
+	move the declaration.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	video-stream: Simplify update_client_playback_delay
+	Avoid one step to retrieve reds pointer.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	Simplify sending stream report activation message
+	Store information directly in the RedStreamActivateReportItem
+	making easier to marshall the message.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	video-stream: Reuse display variable
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	video-stream: Initialise VideoStreamClipItem directly
+	Instead of just allocating in video_stream_clip_item_new and
+	than have to setup properly in dcc_video_stream_agent_clip
+	do all in video_stream_clip_item_new which is more consistent
+	with other part of the code.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
[phone]  Uri Lublin  <[e-mail]>
+
+	sound: fix params order when calling snd_desired_audio_mode
+	Make sure client_can_celt is passed before client_can_opus
+
+	The bug was present since introduction of opus in ce9b714137a767b81f2
+
+	Found by Coverity.
+
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	reds: Fix typo in declaration
+	recs -> reds
+
+	build-sys: Remove useless definition
+	The default LDADD already include libserver.la.
+
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Uri Lublin  <[e-mail]>
+
+	test-stream: initialize msg.msg_flags
+	Coverity complains the field is not initialized.
+	That's true but man recvmsg specifies that this
+	field is set by recvmsg.
+
+	To make coverity happy, initialize this field.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	reds_init_socket: do not leak slisten on error
+	Found by Coverity.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	ssl: Drop support for older OpenSSL versions
+	SSL_OP_NO_COMPRESSION was introduced in OpenSSL_0_9_8k, which is no
+	longer supported. This commit raises the minimum OpenSSL version to
+	1.0.0, which is also out of support.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	worker: Remove unneeded include
+	Nothing seems to be using openssl in red-worker.c
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	build: Use $(srcdir) when it makes sense
+	There are a few places which use $(top_srcdir) when $(srcdir) would be
+	equally valid.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	build: Rebuild shared library when symbol file changes
+	At the moment, changing spice-server.syms to add/remove a new symbol to
+	be exported does not regenerate spice-server.so. This commit added the
+	needed dependency for this to work.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	Do not compute stream_id more that necessary
+	Reuse already computed value and avoid to compute in every
+	iterations.
+
+	Acked-by: Victor Toso <[e-mail]>
+
+	reds: Remove RedVDIReadBuf pooling code
+	Originally this pool was used to avoid allocation/deallocations.
+	However the introduction of GList cause the code to do dynamic
+	allocations in order to update the list making this pooling
+	something useless.
+	The buffers limitation is now implemented with a simple counter.
+
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	test-vdagent: Remove useless MIN definition
+	Already defined by GLib headers.
+
+	Maybe this check should just be removed?
+
+	Handle SPICE_MSGC_DISCONNECTING message in RedChannelClient
+	There's no reason to handle this message in a different
+	way in MainChannel and InputsChannel, the default handling
+	will return true in any case.
+
+	Maybe this check should just be removed?
+
+	reds: Fix wrong assert
+	RedVDIReadBuf::data is a static allocated buffer so checking for
+	NULL on it is useless. It would be NULL only if RedVDIReadBuf
+	pointer would be the opposite, in value, of the offset of
+	data field into it.
+
+	Acked-by: Victor Toso <[e-mail]>
+
+	main-channel: Put all migration message handling together
+	Acked-by: Victor Toso <[e-mail]>
+
+	main-channel: Remove brackets if not needed
+	Acked-by: Victor Toso <[e-mail]>
+
+	main-channel: Remove useless check
+	If there is a channel client there's surely a related channel.
+
+	Acked-by: Victor Toso <[e-mail]>
+
+	reds: Remove leak of agent_dev
+	This object was not freed.
+	Also free object buffers.
+
+	Acked-by: Victor Toso <[e-mail]>
+
+	reds: Use GLib memory functions for RedVDIReadBuf
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Jonathon Jongsma  <[e-mail]>
+
+	StreamDevice: assert preconditions in parsing functions
+	Be a bit more defensive about handling incoming messages from the stream
+	device. This also makes these functions consistent with
+	handle_msg_format(). These assertions are only enabled if
+	ENABLE_EXTRA_CHECKS is defined.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	inputs-channel: Prefer channel core over global core interface
+	Potentially a channel can run with a different core interface
+	than the global one attached to RedsState so instead of calling
+	reds_core_* functions use the code interface attached to the
+	channel.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	inputs-channel: Encapsulate SpiceTabletState
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	Use verify instead of G_STATIC_ASSERT
+	verify guarantee that the condition is always a compile
+	time constant.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	tests: Use GLib memory functions
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	Reduce dependencies from red-qxl.h
+	This header is mainly exporting functions to handle public
+	interface for the QXL devices.
+	Avoid spreading its inclusion including this header in other
+	headers.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	red-channel-client: Rename item_in_pipe to item_sent
+	The name is more consistent with the value of the flag and
+	the function red_channel_client_wait_pipe_item_sent where
+	the MarkerPipeItem structure is used.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	stream: Remove unused display parameter
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Jonathon Jongsma  <[e-mail]>
+
+	DisplayChannel: Use NSEC_PER_MILLISEC
+	Instead of using 1000*1000
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	Rename RedStreamClipItem to VideoStreamClipItem
+	Avoid confusion with RedStream which is a totally unrelated object.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	Rename StreamAgent to VideoStreamAgent
+	Just to avoid confusion between different uses of the word Stream (e.g.
+	RedStream) clarify that it's related to video streams
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	Rename Stream to VideoStream
+	To prevent confusion between Stream (a video stream) and RedStream (a
+	generic data stream between client and server), change the name to
+	VideoStream to be more explicit about what it is.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	red-channel-client: Simplify red_channel_client_wait_pipe_item_sent
+	Currently, red_channel_client_wait_pipe_item_sent() inserts a MarkerItem
+	which will sent after the item we want to wait for: the tail of the
+	queue is the first item to send, and the function uses
+	red_channel_client_pipe_add_after_pos(). Then, if the marker has been
+	successfully sent, the function calls
+	red_channel_client_wait_outgoing_item to wait for 'item' to be sent.
+
+	Instead of doing this, we can add the MarkerItem to the queue so that
+	it's sent after 'item' (ie, insert it _before_ 'item' in the queue).
+	This way, when the marker is marked as having been sent, we'll also know
+	that 'item' has been sent.
+
+	This avoids having to call red_channel_client_wait_outgoing_item and
+	possibly the case where the item was not queued and
+	red_channel_client_wait_outgoing_item returning TRUE even if the item
+	was not sent as required.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	red-channel-client: Simplify red_channel_client_wait_pipe_item_sent loop
+	Avoid repeating the same code twice.
+
+	red_channel_client_send sends the pending item (or a part of it). If
+	there are no item pending, the function does nothing (so checking for
+	blocked channel is useless). Also red_channel_client_send is already
+	called from red_channel_client_push which has a check for blocked
+	channels, so having calls to both red_channel_client_send() and
+	red_channel_client_push() is redundant.
+
+	The function on its overall tries to wait for a given item to be sent.
+	The call for red_channel_client_receive is mainly needed to support the
+	cases were to send data messages from the client should be processed
+	(like if "handle-acks" is requested).
+
+	Moving the loop iteration check inside the for loop instead allows to
+	avoid some duplication.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	red-channel-client: Avoid weird memory references using MarkerPipeItem
+	Instead of having MarkerPipeItem pointing to an external variable with
+	the possibility to forget to reset it and have a dangling pointer, this
+	commit takes a reference on the item to keep it alive after it was sent.
+	This item is placed into the queue to understand when it was sent. The
+	current implementation detects the unqueue when the item is destroyed so
+	we currently store a pointer to an external variable in the item, this
+	way we can use a variable which will still be alive after the item is
+	released/destroyed.
+	This change updates the variable (stored in the item) when we try to
+	send the item, rather than at destruction time. The destruction happened
+	at the end of red_channel_client_send_item(), so we don't mark
+	item_in_pipe much earlier than before.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	mjpeg-encoder: Fix some typos
+	unexected -> unexpected
+	esitimation -> estimation
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	ci: Detect if code compile with SASL disabled
+	Acked-by: Snir Sheriber <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	test-stream-device: Check incomplete reads of StreamMsgFormat
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
[phone]  Jonathon Jongsma  <[e-mail]>
+
+	StreamDevice: Handle incomplete reads of StreamMsgFormat
+	This is currently unlikely to happen since we communicate over a pipe
+	and the pipe buffer is sufficiently large to avoid splitting the
+	message. But for completeness, we should handle this scenario.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Uri Lublin  <[e-mail]>
+
+	red-stream: fix build without SASL
+	put red_stream_disable_writev in an #ifdef HAVE_SASL block.
+	red_stream_disable_writev is only called from functions
+	that are already in an #ifdef HAVE_SASL block.
+
+	Currently when building with SASL disabled, I get:
+	  CC       red-stream.lo
+	red-stream.c:441:13: error: 'red_stream_disable_writev'
+	           defined but not used [-Werror=unused-function]
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	inputs-channel: Remove reds argument from inputs_channel_set_tablet
+	All other inputs_channel_set_* functions do not have this
+	parameter and get it from the channel.
+
+	Acked-by: Uri Lublin <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	inputs-channels: Remove leak using tablet device
+	Current code does not free allocated tablet resources.
+	When a tablet is added some resources are allocated.
+	Resources should be released either removing the tablet or
+	freeing spice server object.
+	Added a test to check these conditions.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	reds: Do not get time if not needed
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	tests: Add a test for streaming devices
+	Currently create device, open it and pass some messages checking
+	they are handled.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	Reuse SPICE_DECLARE_TYPE macro
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	Remove common/mem.h includes
+	common/mem.h contains mainly memory allocation functions.
+	As we decided to move to Glib calls directly avoid to include
+	function declaration we should not use anymore.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	utils: Check we list all channel names
+	This prevent future problems supporting new channels.
+
+	Acked-by: Victor Toso <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	Use constant variables for image operations
+	This reduce the attack surface moving some data into read-only
+	sections.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	build: Update spice-common submodule
+	Frediano Ziglio (6):
+	      Make the compiler work out better way to write unaligned memory
+	      test-marshallers: Use unaligned structure
+	      test-marshallers: Test demarshalling
+	      ring: Remove __ring_remove function
+	      ring: Remove short living temporary variable
+	      canvas_base: Allow to specify constant operations
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	utils: Fill in all possible channel names
+	Missing some names cause some debugging messages to be
+	generated and some of our tests to fail.
+
+	This patch was written by Christophe Fergeau.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	ci: Install python3 packages to fix compile on new Fedora
+	Fedora 26 removed dependency from python-pyparsing/python-six
+	to python but we require the executable to run some scripts
+
+	Acked-by: Uri Lublin <[e-mail]>
+
[phone]  Jonathon Jongsma  <[e-mail]>
+
+	StreamDevice: Fix incomplete header reads
+	The code for reading a StreamDevice message from the streaming agent has
+	code to handle a situation where you only read a part of the header. If
+	we've read only a part of the header, we will try to read the remaining
+	n bytes of the header within a loop until the full header is read.
+	However, when we try to read the last n bytes, we store it at beginning
+	of the header struct, which will overwrite the first part of the header.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Jonathon Jongsma  <[e-mail]>
+
+	Make stream-channel.h self-contained
+	Include protocol header file defining StreamMsgFormat which is used in a
+	function signature in this header.
+
+	Acked-by: Victor Toso <[e-mail]>
+	Reviewed-by: Frediano Ziglio <[e-mail]>
+
[phone]  Christophe Fergeau  <[e-mail]>
+
+	channel: Introduce logging helpers
+	This commit adds red_channel_{debug,warning,printerr}() helpers which
+	will prepend the log message with "channel-name:id (%p)". It also
+	changes various locations which were doing this manually.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
+	utils: Introduce helpers to map channel types to names
+	spice_server_set_channel_security() is already mostly doing that. We can
+	make its code more generic, and introduce a red_channel_get_name()
+	method. This method will then be used to make debug messages more
+	readable by showing the actual channel name rather than its type as
+	an int.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Jonathon Jongsma  <[e-mail]>
+
+	Use standard "Red" namespace
+	The objects RedsStream and RedsSASL are currently using the namespace
+	"Reds" rather than the standard "Red" namespace used throughout the rest
+	of the project. Change these to be consistent. This also means changing
+	method names and some related enumeration types.
+
+	The files were also renamed to reflect the change:
+	  reds-stream.[ch] -> red-stream.[ch]
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Jonathon Jongsma  <[e-mail]>
+
+	RedsStream: make some functions static
+	These were not used outside of reds-stream.c, so make them static and
+	remove them from the header.
+
+	Acked-by: Frediano Ziglio <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	reds-stream: Remove useless debug
+	There are already other debugging code showing channel closure.
+	Not closed file descriptors can easily be detected with other
+	tools (like netstat or /proc file system).
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	reds-stream: Removed unused "username" field
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	red-qxl: Enforce boolean for QXLDevSurfaceCreate::mouse_mode
+	In some cases mouse_mode is a bit field.
+	However for this structure is used always as a boolean
+	value.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	red-qxl: Remove surface_create field
+	This field was used just to store a value and retrieve again
+	while we can just pass it instead.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	stream-channel: Activate streaming report from client
+	Setting the capability is not enough, each stream must be enabled
+	so do so if client support them.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	stream-device: Limit sending queue from guest to server
+	Do not allow the guest to fill host memory.
+	Also having a huge queue mainly cause to have a higher video
+	latency.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	stream-device: Create channel when needed
+	This allows a better id allocation as devices are created after
+	fixed ones.
+	Also will allow to support more easily multiple monitor.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	stream-device: Start supporting resetting device when close/open on guest
+	When guest close the device the host device has to be reset too.
+	This make easier to restart the guest device which can happen in case
+	of reboot, agent issues or if we want to update the agent.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	char-device: Do not stop and clear interface on reset
+	Currently, red_char_device_reset() stops the device, clears all pending
+	messages, and clears its device instance. After this function is called,
+	the char device will not work again until it is assigned a new device
+	instance and restarted. This is fine for the vdagent char device, which
+	is currently the only user of this function. But for the stream device,
+	we want to be able to reset the char device to a working state (e.g.
+	clear all pending messages, etc) without stopping or disabling the char
+	device. So this function will now only reset the char device to a clean
+	working state, and the _stop() and _reset_dev_instance() calls will be
+	moved up to the caller.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	stream-channel: Do not show an empty blank screen on start
+	Start showing something when we have a surface and stream
+	instead of showing a blank screen which is now not useful.
+	Was useful for debugging purposes to understand that the
+	new channel was sending messages correctly to client and
+	client could handle them.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	stream-channel: Support client connection/disconnection
+	When a new client is connected we must restart the stream so new
+	clients can receive correct data without having to wait for the
+	next full screen (which on idle screen could take ages).
+	On disconnection we should tell the guest to stop streaming
+	not wasting resources to stream not needed data.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	stream-channel: Allows to register callback to get new stream request
+	The channel needs to communicate when it receive a new
+	stream request from the guest.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	stream-channel: Allows not fixed size
+	Remove the fixed size stream and support any display size.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	stream-device: Handle streaming data from device to channel
+	Handle stream data from device sending to the channel.
+	The StreamChannel will forward the data to the clients using standard
+	DisplayChannel messages, and will create and destroy streams as
+	necessary.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	stream-device: Create channel for stream device
+	So can be used by the device to communicate with the clients.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	stream-channel: Start implementing DisplayChannel properly
+	Handle messages from clients.
+	Send some messages to clients.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	stream-channel: Write a base channel to implement the streaming
+	Currently only compile, not used and not much sense
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	stream-device: Start parsing new protocol from guest
+	Parse the data sent from the guest to the streaming device.
+	At the moment, the data is simply discarded after it is parsed.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	stream-device: Add device to handle streaming
+	Add a stub device in guest.
+	The aim of this device is to make it possible for the guest to send a
+	stream through a DisplayChannel (in the sense of protocol channel).
+	This stub allows the guest to send some data and you can see some debug
+	lines of data arrived on host logs.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	Notify client of the creation of new channels dynamically
+	This allows the server to add channels after the client is connected.
+
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	tests: Check leaks registering migration interface
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	reds: Remove leak allocating migration state
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	red-channel: Remove red_channel_init_outgoing_messages_window
+	This function does not make much sense anymore.
+	Is called by RedVmcChannel which doesn't use RedChannelClient ACKs
+	so the variable changed are not used.
+	Moreover, at red_vmc_channel_constructed() time, there will be no
+	clients yet, so red_channel_init_outgoing_messages() will be a no-op.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
+	inputs-channel: Check message size handling migration data
+	Prevent possible buffer reading overflow.
+	Note that message pointer must be valid and data are checked
+	value by value so even on overflow you just get an error.
+
+	Acked-by: Christophe Fergeau <[e-mail]>
+
[phone]  Frediano Ziglio  <[e-mail]>
+
+	red-pipe-item: Use GLib memory functions
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	parse-qxl: Use GLib memory functions
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	pixmap-cache: Use GLib memory functions
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	image-cache: Use GLib memory functions
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	inputs-channel: Use GLib memory functions
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	tree: Use GLib memory functions
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	worker: Use GLib memory functions
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	replay-qxl: Use GLib memory functions
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	display-channel: Use GLib memory functions
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	dcc: Use GLib memory functions
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	reds: Use GLib memory functions for ChannelSecurityOptions
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	reds: Use GLib memory functions for link message
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	Use GLib memory functions for SpiceChannelEventInfo
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	dispatcher: Use GLib memory functions
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	event-loop: Use GLib memory functions
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	char-device: Use GLib memory functions
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	gstreamer-encoder: Use GLib memory functions
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	spicevmc: Use GLib memory functions
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	stream: Use GLib memory functions
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	smartcard: Use GLib memory functions
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	reds-stream: Use GLib memory functions
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	mjpeg: Use GLib memory functions
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
+	lz4-encoder: Use GLib memory functions
+	Acked-by: Jonathon Jongsma <[e-mail]>
+
 2017-10-11  Christophe Fergeau  <[e-mail]>
 
 	spice-server 0.14.0 release
@@ -2400,6 +6303,8 @@
 
 	Acked-by: Christophe Fergeau <[e-mail]>
 
[phone]  Frediano Ziglio  <[e-mail]>
+
 	display-channel: Clean more stuff on finalize
 	Release surfaces, cache and monitor configurations.
 
@@ -2410,8 +6315,6 @@
 
 	Acked-by: Jonathon Jongsma <[e-mail]>
 
-2017-02-28  Frediano Ziglio  <[e-mail]>
-
 	reds: Check that we do not free the wrong agent device
 	Do not assume the device passed as an argument to
 	spice_server_char_device_remove_interface() is the same as the current
@@ -3658,7 +7561,7 @@
 
 	Acked-by: Jonathon Jongsma <[e-mail]>
 
-2016-12-06  Frediano Ziglio  <[e-mail]>
[phone]  Frediano Ziglio  <[e-mail]>
 
 	Support QXL remove on spice_server_remove_interface
 	Allow to dynamically remove QXL interfaces. This could be used to
@@ -6134,7 +10037,7 @@
 
 	Acked-by: Christophe Fergeau <[e-mail]>
 
-2016-06-16  Frediano Ziglio  <[e-mail]>
[phone]  Frediano Ziglio  <[e-mail]>
 
 	Remove message_buf from EncoderData
 	This buffer was just written and then used, no reason to store into
@@ -6142,7 +10045,7 @@
 
 	Acked-by: Jonathon Jongsma <[e-mail]>
 
-2016-06-16  Eduardo Lima (Etrunko)  <[e-mail]>
[phone]  Eduardo Lima (Etrunko)  <[e-mail]>
 
 	configure: Better wording hasn't -> has not
 	Acked-by: Jonathon Jongsma <[e-mail]>
@@ -6380,7 +10283,7 @@
 	Add a structure to hold ImageEncoders shared data
 	Acked-by: Jonathon Jongsma <[e-mail]>
 
-2016-06-14  snir sheriber  <[e-mail]>
[phone]  snir sheriber  <[e-mail]>
 
 	LZ4 compression is now available at the Spicevmc channel
 	Compressed message type is CompressedData which contains compression
@@ -6509,6 +10412,8 @@
 
 	Acked-by: Christophe Fergeau <[e-mail]>
 
[phone]  Frediano Ziglio  <[e-mail]>
+
 	Move dcc glz field initialization into dcc_new
 	There is no reason to initialize these fields in two different places.
 	Note that an usage between dcc_new and the function where these
@@ -6516,8 +10421,6 @@
 
 	Acked-by: Jonathon Jongsma <[e-mail]>
 
-2016-06-07  Frediano Ziglio  <[e-mail]>
-
 	record: Make red_record_cursor_cmd static
 	This function is never used outside this compile unit.
 
@@ -7098,6 +11001,8 @@
 	Extend it's usage.
 	This for instance leads to the removal of release_item callback.
 
[phone]  Frediano Ziglio  <[e-mail]>
+
 	Use reference counting for RedPipeItem
 	Acked-by: Jonathon Jongsma <[e-mail]>
 
@@ -7190,8 +11095,6 @@
 	Remove unused refs field
 	Acked-by: Jonathon Jongsma <[e-mail]>
 
-2016-05-17  Frediano Ziglio  <[e-mail]>
-
 	remove only written num_mig_target_clients field in RedsState
 	Acked-by: Christophe Fergeau <[e-mail]>
 
@@ -8652,6 +12555,8 @@
 
 	Acked-by: Jonathon Jongsma <[e-mail]>
 
[phone]  Frediano Ziglio  <[e-mail]>
+
 	CommonChannel: hold a reference to QXLInstance instead of RedWorker
 	CommonChannel does not need to know about RedWorker.
 	This reduce a bit dependencies between objects.
@@ -8807,8 +12712,6 @@
 
 	Acked-by: Jonathon Jongsma <jjongsma at redhat.com>
 
-2016-02-11  Frediano Ziglio  <[e-mail]>
-
 	dispatcher: remove unused async_commands ring
 	The only usage of this ring was to have a message when there was no
 	commands on the list.
@@ -9477,6 +13380,8 @@
 
 	Acked-by: Jonathon Jongsma <[e-mail]>
 
[phone]  Frediano Ziglio  <[e-mail]>
+
 	tests: test removed triggered timers are not called
 	This could happen for instance if a given timer remove all clients
 	which have associated timers.
@@ -10220,7 +14125,7 @@
 	Acked-by: Jonathon Jongsma <[e-mail]>
 	Acked-by: Fabiano Fidêncio <[e-mail]>
 
-2015-12-04  Frediano Ziglio  <[e-mail]>
[phone]  Frediano Ziglio  <[e-mail]>
 
 	server: rename files
 	Acked-by: Jonathon Jongsma <[e-mail]>
@@ -11830,7 +15735,7 @@
 	Acked-by: Frediano Ziglio <[e-mail]>
 	Acked-by: Jonathon Jongsma <[e-mail]>
 
-2015-08-28  Frediano Ziglio  <[e-mail]>
[phone]  Frediano Ziglio  <[e-mail]>
 
 	Simplify set_surface_release_info
 	Acked-by: Christophe Fergeau <[e-mail]>
@@ -13861,12 +17766,12 @@
 
 	Release 0.12.4
 
[phone]  Uri Lublin  <[e-mail]>
+
 	Update spice-common submodule (get spice-protocol 0.12.6)
 
 	syntax-check: trailing whitespaces -- ignore binary files
 
-2013-07-16  Uri Lublin  <[e-mail]>
-
 	syntax-check: remove trailing whitespaces
 	Only whitespace changes in this commit.
 
@@ -17090,7 +20995,7 @@
 	Also fixup the header of server/red_parse_qxl.c, which still contained
 	some GPL (program rather then library) text in its header.
 
-2011-12-14  Marc-André Lureau  <[e-mail]>
[phone]  Marc-André Lureau  <[e-mail]>
 
 	spelling: s/cupture/capture
 
@@ -22475,14 +26380,14 @@
 
 	Still some room to improvment but later...
 
[phone]  Izik Eidus  <[e-mail]>
+
 	spice server: remove surface_id and surfaces_dest[3] from guest mem
 	Validate the surface_ids just once and keep them in safe
 	memory area
 
 	Make things simpler
 
-2010-04-05  Izik Eidus  <[e-mail]>
-
 	spice: common: gdi_canvas fix gdi objects leak
 	BitmapMask was used by the draw_text function as well
 	therefore we need to mark from_surface = 0 if we want
diff --git a/INSTALL b/INSTALL
index 2099840..8865734 100644
--- a/INSTALL
+++ b/INSTALL
@@ -1,8 +1,8 @@
 Installation Instructions
 *************************
 
-Copyright (C) 1994-1996, 1999-2002, 2004-2013 Free Software Foundation,
-Inc.
+   Copyright (C) 1994-1996, 1999-2002, 2004-2016 Free Software
+Foundation, Inc.
 
    Copying and distribution of this file, with or without modification,
 are permitted in any medium without royalty provided the copyright
@@ -12,97 +12,96 @@ without warranty of any kind.
 Basic Installation
 ==================
 
-   Briefly, the shell command `./configure && make && make install'
+   Briefly, the shell command './configure && make && make install'
 should configure, build, and install this package.  The following
-more-detailed instructions are generic; see the `README' file for
+more-detailed instructions are generic; see the 'README' file for
 instructions specific to this package.  Some packages provide this
-`INSTALL' file but do not implement all of the features documented
+'INSTALL' file but do not implement all of the features documented
 below.  The lack of an optional feature in a given package is not
 necessarily a bug.  More recommendations for GNU packages can be found
 in *note Makefile Conventions: (standards)Makefile Conventions.
 
-   The `configure' shell script attempts to guess correct values for
+   The 'configure' shell script attempts to guess correct values for
 various system-dependent variables used during compilation.  It uses
-those values to create a `Makefile' in each directory of the package.
-It may also create one or more `.h' files containing system-dependent
-definitions.  Finally, it creates a shell script `config.status' that
+those values to create a 'Makefile' in each directory of the package.
+It may also create one or more '.h' files containing system-dependent
+definitions.  Finally, it creates a shell script 'config.status' that
 you can run in the future to recreate the current configuration, and a
-file `config.log' containing compiler output (useful mainly for
-debugging `configure').
+file 'config.log' containing compiler output (useful mainly for
+debugging 'configure').
 
-   It can also use an optional file (typically called `config.cache'
-and enabled with `--cache-file=config.cache' or simply `-C') that saves
-the results of its tests to speed up reconfiguring.  Caching is
-disabled by default to prevent problems with accidental use of stale
-cache files.
+   It can also use an optional file (typically called 'config.cache' and
+enabled with '--cache-file=config.cache' or simply '-C') that saves the
+results of its tests to speed up reconfiguring.  Caching is disabled by
+default to prevent problems with accidental use of stale cache files.
 
    If you need to do unusual things to compile the package, please try
-to figure out how `configure' could check whether to do them, and mail
-diffs or instructions to the address given in the `README' so they can
+to figure out how 'configure' could check whether to do them, and mail
+diffs or instructions to the address given in the 'README' so they can
 be considered for the next release.  If you are using the cache, and at
-some point `config.cache' contains results you don't want to keep, you
+some point 'config.cache' contains results you don't want to keep, you
 may remove or edit it.
 
-   The file `configure.ac' (or `configure.in') is used to create
-`configure' by a program called `autoconf'.  You need `configure.ac' if
-you want to change it or regenerate `configure' using a newer version
-of `autoconf'.
+   The file 'configure.ac' (or 'configure.in') is used to create
+'configure' by a program called 'autoconf'.  You need 'configure.ac' if
+you want to change it or regenerate 'configure' using a newer version of
+'autoconf'.
 
    The simplest way to compile this package is:
 
-  1. `cd' to the directory containing the package's source code and type
-     `./configure' to configure the package for your system.
+  1. 'cd' to the directory containing the package's source code and type
+     './configure' to configure the package for your system.
 
-     Running `configure' might take a while.  While running, it prints
+     Running 'configure' might take a while.  While running, it prints
      some messages telling which features it is checking for.
 
-  2. Type `make' to compile the package.
+  2. Type 'make' to compile the package.
 
-  3. Optionally, type `make check' to run any self-tests that come with
+  3. Optionally, type 'make check' to run any self-tests that come with
      the package, generally using the just-built uninstalled binaries.
 
-  4. Type `make install' to install the programs and any data files and
+  4. Type 'make install' to install the programs and any data files and
      documentation.  When installing into a prefix owned by root, it is
      recommended that the package be configured and built as a regular
-     user, and only the `make install' phase executed with root
+     user, and only the 'make install' phase executed with root
      privileges.
 
-  5. Optionally, type `make installcheck' to repeat any self-tests, but
+  5. Optionally, type 'make installcheck' to repeat any self-tests, but
      this time using the binaries in their final installed location.
      This target does not install anything.  Running this target as a
-     regular user, particularly if the prior `make install' required
+     regular user, particularly if the prior 'make install' required
      root privileges, verifies that the installation completed
      correctly.
 
   6. You can remove the program binaries and object files from the
-     source code directory by typing `make clean'.  To also remove the
-     files that `configure' created (so you can compile the package for
-     a different kind of computer), type `make distclean'.  There is
-     also a `make maintainer-clean' target, but that is intended mainly
+     source code directory by typing 'make clean'.  To also remove the
+     files that 'configure' created (so you can compile the package for
+     a different kind of computer), type 'make distclean'.  There is
+     also a 'make maintainer-clean' target, but that is intended mainly
      for the package's developers.  If you use it, you may have to get
      all sorts of other programs in order to regenerate files that came
      with the distribution.
 
-  7. Often, you can also type `make uninstall' to remove the installed
+  7. Often, you can also type 'make uninstall' to remove the installed
      files again.  In practice, not all packages have tested that
      uninstallation works correctly, even though it is required by the
      GNU Coding Standards.
 
-  8. Some packages, particularly those that use Automake, provide `make
+  8. Some packages, particularly those that use Automake, provide 'make
      distcheck', which can by used by developers to test that all other
-     targets like `make install' and `make uninstall' work correctly.
+     targets like 'make install' and 'make uninstall' work correctly.
      This target is generally not run by end users.
 
 Compilers and Options
 =====================
 
    Some systems require unusual options for compilation or linking that
-the `configure' script does not know about.  Run `./configure --help'
+the 'configure' script does not know about.  Run './configure --help'
 for details on some of the pertinent environment variables.
 
-   You can give `configure' initial values for configuration parameters
-by setting variables in the command line or in the environment.  Here
-is an example:
+   You can give 'configure' initial values for configuration parameters
+by setting variables in the command line or in the environment.  Here is
+an example:
 
      ./configure CC=c99 CFLAGS=-g LIBS=-lposix
 
@@ -113,21 +112,21 @@ Compiling For Multiple Architectures
 
    You can compile the package for more than one kind of computer at the
 same time, by placing the object files for each architecture in their
-own directory.  To do this, you can use GNU `make'.  `cd' to the
+own directory.  To do this, you can use GNU 'make'.  'cd' to the
 directory where you want the object files and executables to go and run
-the `configure' script.  `configure' automatically checks for the
-source code in the directory that `configure' is in and in `..'.  This
-is known as a "VPATH" build.
+the 'configure' script.  'configure' automatically checks for the source
+code in the directory that 'configure' is in and in '..'.  This is known
+as a "VPATH" build.
 
-   With a non-GNU `make', it is safer to compile the package for one
+   With a non-GNU 'make', it is safer to compile the package for one
 architecture at a time in the source code directory.  After you have
-installed the package for one architecture, use `make distclean' before
+installed the package for one architecture, use 'make distclean' before
 reconfiguring for another architecture.
 
    On MacOS X 10.5 and later systems, you can create libraries and
 executables that work on multiple system types--known as "fat" or
-"universal" binaries--by specifying multiple `-arch' options to the
-compiler but only a single `-arch' option to the preprocessor.  Like
+"universal" binaries--by specifying multiple '-arch' options to the
+compiler but only a single '-arch' option to the preprocessor.  Like
 this:
 
      ./configure CC="gcc -arch i386 -arch x86_64 -arch ppc -arch ppc64" \
@@ -136,105 +135,104 @@ this:
 
    This is not guaranteed to produce working output in all cases, you
 may have to build one architecture at a time and combine the results
-using the `lipo' tool if you have problems.
+using the 'lipo' tool if you have problems.
 
 Installation Names
 ==================
 
-   By default, `make install' installs the package's commands under
-`/usr/local/bin', include files under `/usr/local/include', etc.  You
-can specify an installation prefix other than `/usr/local' by giving
-`configure' the option `--prefix=PREFIX', where PREFIX must be an
+   By default, 'make install' installs the package's commands under
+'/usr/local/bin', include files under '/usr/local/include', etc.  You
+can specify an installation prefix other than '/usr/local' by giving
+'configure' the option '--prefix=PREFIX', where PREFIX must be an
 absolute file name.
 
    You can specify separate installation prefixes for
 architecture-specific files and architecture-independent files.  If you
-pass the option `--exec-prefix=PREFIX' to `configure', the package uses
+pass the option '--exec-prefix=PREFIX' to 'configure', the package uses
 PREFIX as the prefix for installing programs and libraries.
 Documentation and other data files still use the regular prefix.
 
    In addition, if you use an unusual directory layout you can give
-options like `--bindir=DIR' to specify different values for particular
-kinds of files.  Run `configure --help' for a list of the directories
-you can set and what kinds of files go in them.  In general, the
-default for these options is expressed in terms of `${prefix}', so that
-specifying just `--prefix' will affect all of the other directory
+options like '--bindir=DIR' to specify different values for particular
+kinds of files.  Run 'configure --help' for a list of the directories
+you can set and what kinds of files go in them.  In general, the default
+for these options is expressed in terms of '${prefix}', so that
+specifying just '--prefix' will affect all of the other directory
 specifications that were not explicitly provided.
 
    The most portable way to affect installation locations is to pass the
-correct locations to `configure'; however, many packages provide one or
+correct locations to 'configure'; however, many packages provide one or
 both of the following shortcuts of passing variable assignments to the
-`make install' command line to change installation locations without
+'make install' command line to change installation locations without
 having to reconfigure or recompile.
 
    The first method involves providing an override variable for each
-affected directory.  For example, `make install
+affected directory.  For example, 'make install
 prefix=/alternate/directory' will choose an alternate location for all
 directory configuration variables that were expressed in terms of
-`${prefix}'.  Any directories that were specified during `configure',
-but not in terms of `${prefix}', must each be overridden at install
-time for the entire installation to be relocated.  The approach of
-makefile variable overrides for each directory variable is required by
-the GNU Coding Standards, and ideally causes no recompilation.
-However, some platforms have known limitations with the semantics of
-shared libraries that end up requiring recompilation when using this
-method, particularly noticeable in packages that use GNU Libtool.
-
-   The second method involves providing the `DESTDIR' variable.  For
-example, `make install DESTDIR=/alternate/directory' will prepend
-`/alternate/directory' before all installation names.  The approach of
-`DESTDIR' overrides is not required by the GNU Coding Standards, and
+'${prefix}'.  Any directories that were specified during 'configure',
+but not in terms of '${prefix}', must each be overridden at install time
+for the entire installation to be relocated.  The approach of makefile
+variable overrides for each directory variable is required by the GNU
+Coding Standards, and ideally causes no recompilation.  However, some
+platforms have known limitations with the semantics of shared libraries
+that end up requiring recompilation when using this method, particularly
+noticeable in packages that use GNU Libtool.
+
+   The second method involves providing the 'DESTDIR' variable.  For
+example, 'make install DESTDIR=/alternate/directory' will prepend
+'/alternate/directory' before all installation names.  The approach of
+'DESTDIR' overrides is not required by the GNU Coding Standards, and
 does not work on platforms that have drive letters.  On the other hand,
 it does better at avoiding recompilation issues, and works well even
-when some directory options were not specified in terms of `${prefix}'
-at `configure' time.
+when some directory options were not specified in terms of '${prefix}'
+at 'configure' time.
 
 Optional Features
 =================
 
    If the package supports it, you can cause programs to be installed
-with an extra prefix or suffix on their names by giving `configure' the
-option `--program-prefix=PREFIX' or `--program-suffix=SUFFIX'.
-
-   Some packages pay attention to `--enable-FEATURE' options to
-`configure', where FEATURE indicates an optional part of the package.
-They may also pay attention to `--with-PACKAGE' options, where PACKAGE
-is something like `gnu-as' or `x' (for the X Window System).  The
-`README' should mention any `--enable-' and `--with-' options that the
+with an extra prefix or suffix on their names by giving 'configure' the
+option '--program-prefix=PREFIX' or '--program-suffix=SUFFIX'.
+
+   Some packages pay attention to '--enable-FEATURE' options to
+'configure', where FEATURE indicates an optional part of the package.
+They may also pay attention to '--with-PACKAGE' options, where PACKAGE
+is something like 'gnu-as' or 'x' (for the X Window System).  The
+'README' should mention any '--enable-' and '--with-' options that the
 package recognizes.
 
-   For packages that use the X Window System, `configure' can usually
+   For packages that use the X Window System, 'configure' can usually
 find the X include and library files automatically, but if it doesn't,
-you can use the `configure' options `--x-includes=DIR' and
-`--x-libraries=DIR' to specify their locations.
+you can use the 'configure' options '--x-includes=DIR' and
+'--x-libraries=DIR' to specify their locations.
 
    Some packages offer the ability to configure how verbose the
-execution of `make' will be.  For these packages, running `./configure
+execution of 'make' will be.  For these packages, running './configure
 --enable-silent-rules' sets the default to minimal output, which can be
-overridden with `make V=1'; while running `./configure
+overridden with 'make V=1'; while running './configure
 --disable-silent-rules' sets the default to verbose, which can be
-overridden with `make V=0'.
+overridden with 'make V=0'.
 
 Particular systems
 ==================
 
-   On HP-UX, the default C compiler is not ANSI C compatible.  If GNU
-CC is not installed, it is recommended to use the following options in
+   On HP-UX, the default C compiler is not ANSI C compatible.  If GNU CC
+is not installed, it is recommended to use the following options in
 order to use an ANSI C compiler:
 
      ./configure CC="cc -Ae -D_XOPEN_SOURCE=500"
 
 and if that doesn't work, install pre-built binaries of GCC for HP-UX.
 
-   HP-UX `make' updates targets which have the same time stamps as
-their prerequisites, which makes it generally unusable when shipped
-generated files such as `configure' are involved.  Use GNU `make'
-instead.
+   HP-UX 'make' updates targets which have the same time stamps as their
+prerequisites, which makes it generally unusable when shipped generated
+files such as 'configure' are involved.  Use GNU 'make' instead.
 
    On OSF/1 a.k.a. Tru64, some versions of the default C compiler cannot
-parse its `<wchar.h>' header file.  The option `-nodtk' can be used as
-a workaround.  If GNU CC is not installed, it is therefore recommended
-to try
+parse its '<wchar.h>' header file.  The option '-nodtk' can be used as a
+workaround.  If GNU CC is not installed, it is therefore recommended to
+try
 
      ./configure CC="cc"
 
@@ -242,26 +240,26 @@ and if that doesn't work, try
 
      ./configure CC="cc -nodtk"
 
-   On Solaris, don't put `/usr/ucb' early in your `PATH'.  This
+   On Solaris, don't put '/usr/ucb' early in your 'PATH'.  This
 directory contains several dysfunctional programs; working variants of
-these programs are available in `/usr/bin'.  So, if you need `/usr/ucb'
-in your `PATH', put it _after_ `/usr/bin'.
+these programs are available in '/usr/bin'.  So, if you need '/usr/ucb'
+in your 'PATH', put it _after_ '/usr/bin'.
 
-   On Haiku, software installed for all users goes in `/boot/common',
-not `/usr/local'.  It is recommended to use the following options:
+   On Haiku, software installed for all users goes in '/boot/common',
+not '/usr/local'.  It is recommended to use the following options:
 
      ./configure --prefix=/boot/common
 
 Specifying the System Type
 ==========================
 
-   There may be some features `configure' cannot figure out
+   There may be some features 'configure' cannot figure out
 automatically, but needs to determine by the type of machine the package
 will run on.  Usually, assuming the package is built to be run on the
-_same_ architectures, `configure' can figure that out, but if it prints
+_same_ architectures, 'configure' can figure that out, but if it prints
 a message saying it cannot guess the machine type, give it the
-`--build=TYPE' option.  TYPE can either be a short name for the system
-type, such as `sun4', or a canonical name which has the form:
+'--build=TYPE' option.  TYPE can either be a short name for the system
+type, such as 'sun4', or a canonical name which has the form:
 
      CPU-COMPANY-SYSTEM
 
@@ -270,101 +268,101 @@ where SYSTEM can have one of these forms:
      OS
      KERNEL-OS
 
-   See the file `config.sub' for the possible values of each field.  If
-`config.sub' isn't included in this package, then this package doesn't
+   See the file 'config.sub' for the possible values of each field.  If
+'config.sub' isn't included in this package, then this package doesn't
 need to know the machine type.
 
    If you are _building_ compiler tools for cross-compiling, you should
-use the option `--target=TYPE' to select the type of system they will
+use the option '--target=TYPE' to select the type of system they will
 produce code for.
 
    If you want to _use_ a cross compiler, that generates code for a
 platform different from the build platform, you should specify the
 "host" platform (i.e., that on which the generated programs will
-eventually be run) with `--host=TYPE'.
+eventually be run) with '--host=TYPE'.
 
 Sharing Defaults
 ================
 
-   If you want to set default values for `configure' scripts to share,
-you can create a site shell script called `config.site' that gives
-default values for variables like `CC', `cache_file', and `prefix'.
-`configure' looks for `PREFIX/share/config.site' if it exists, then
-`PREFIX/etc/config.site' if it exists.  Or, you can set the
-`CONFIG_SITE' environment variable to the location of the site script.
-A warning: not all `configure' scripts look for a site script.
+   If you want to set default values for 'configure' scripts to share,
+you can create a site shell script called 'config.site' that gives
+default values for variables like 'CC', 'cache_file', and 'prefix'.
+'configure' looks for 'PREFIX/share/config.site' if it exists, then
+'PREFIX/etc/config.site' if it exists.  Or, you can set the
+'CONFIG_SITE' environment variable to the location of the site script.
+A warning: not all 'configure' scripts look for a site script.
 
 Defining Variables
 ==================
 
    Variables not defined in a site shell script can be set in the
-environment passed to `configure'.  However, some packages may run
+environment passed to 'configure'.  However, some packages may run
 configure again during the build, and the customized values of these
 variables may be lost.  In order to avoid this problem, you should set
-them in the `configure' command line, using `VAR=value'.  For example:
+them in the 'configure' command line, using 'VAR=value'.  For example:
 
      ./configure CC=/usr/local2/bin/gcc
 
-causes the specified `gcc' to be used as the C compiler (unless it is
+causes the specified 'gcc' to be used as the C compiler (unless it is
 overridden in the site shell script).
 
-Unfortunately, this technique does not work for `CONFIG_SHELL' due to
-an Autoconf limitation.  Until the limitation is lifted, you can use
-this workaround:
+Unfortunately, this technique does not work for 'CONFIG_SHELL' due to an
+Autoconf limitation.  Until the limitation is lifted, you can use this
+workaround:
 
      CONFIG_SHELL=/bin/bash ./configure CONFIG_SHELL=/bin/bash
 
-`configure' Invocation
+'configure' Invocation
 ======================
 
-   `configure' recognizes the following options to control how it
+   'configure' recognizes the following options to control how it
 operates.
 
-`--help'
-`-h'
-     Print a summary of all of the options to `configure', and exit.
+'--help'
+'-h'
+     Print a summary of all of the options to 'configure', and exit.
 
-`--help=short'
-`--help=recursive'
+'--help=short'
+'--help=recursive'
      Print a summary of the options unique to this package's
-     `configure', and exit.  The `short' variant lists options used
-     only in the top level, while the `recursive' variant lists options
-     also present in any nested packages.
+     'configure', and exit.  The 'short' variant lists options used only
+     in the top level, while the 'recursive' variant lists options also
+     present in any nested packages.
 
-`--version'
-`-V'
-     Print the version of Autoconf used to generate the `configure'
+'--version'
+'-V'
+     Print the version of Autoconf used to generate the 'configure'
      script, and exit.
 
-`--cache-file=FILE'
+'--cache-file=FILE'
      Enable the cache: use and save the results of the tests in FILE,
-     traditionally `config.cache'.  FILE defaults to `/dev/null' to
+     traditionally 'config.cache'.  FILE defaults to '/dev/null' to
      disable caching.
 
-`--config-cache'
-`-C'
-     Alias for `--cache-file=config.cache'.
+'--config-cache'
+'-C'
+     Alias for '--cache-file=config.cache'.
 
-`--quiet'
-`--silent'
-`-q'
+'--quiet'
+'--silent'
+'-q'
      Do not print messages saying which checks are being made.  To
-     suppress all normal output, redirect it to `/dev/null' (any error
+     suppress all normal output, redirect it to '/dev/null' (any error
      messages will still be shown).
 
-`--srcdir=DIR'
+'--srcdir=DIR'
      Look for the package's source code in directory DIR.  Usually
-     `configure' can determine that directory automatically.
+     'configure' can determine that directory automatically.
 
-`--prefix=DIR'
-     Use DIR as the installation prefix.  *note Installation Names::
-     for more details, including other options available for fine-tuning
-     the installation locations.
+'--prefix=DIR'
+     Use DIR as the installation prefix.  *note Installation Names:: for
+     more details, including other options available for fine-tuning the
+     installation locations.
 
-`--no-create'
-`-n'
+'--no-create'
+'-n'
      Run the configure checks, but stop before creating any output
      files.
 
-`configure' also accepts some other, not widely useful, options.  Run
-`configure --help' for more details.
+'configure' also accepts some other, not widely useful, options.  Run
+'configure --help' for more details.
diff --git a/Makefile.am b/Makefile.am
index 9a073a1..7106e8d 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,7 +1,7 @@
 NULL =
 ACLOCAL_AMFLAGS = -I m4
 
-SUBDIRS = spice-common server docs tools
+SUBDIRS = subprojects/spice-common server docs tools
 
 check-valgrind:
 	$(MAKE) -C server check-valgrind
@@ -10,14 +10,17 @@ pkgconfigdir = $(libdir)/pkgconfig
 pkgconfig_DATA = spice-server.pc
 
 DISTCHECK_CONFIGURE_FLAGS =			\
-	--enable-automated-tests		\
+	--disable-celt051			\
 	--enable-smartcard			\
 	--with-sasl				\
 	--enable-manual				\
 	$(NULL)
 
 EXTRA_DIST =					\
+	meson.build				\
+	meson_options.txt			\
 	build-aux/git-version-gen		\
+	build-aux/meson/check-spice-common	\
 	.version				\
 	$(NULL)
 
diff --git a/Makefile.in b/Makefile.in
index 6a56634..4378449 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -1,7 +1,7 @@
-# Makefile.in generated by automake 1.15 from Makefile.am.
+# Makefile.in generated by automake 1.16.1 from Makefile.am.
 # @configure_input@
 
-# Copyright (C) 1994-2014 Free Software Foundation, Inc.
+# Copyright (C) 1994-2018 Free Software Foundation, Inc.
 
 # This Makefile.in is free software; the Free Software Foundation
 # gives unlimited permission to copy and/or distribute it,
@@ -99,7 +99,7 @@ am__aclocal_m4_deps = $(top_srcdir)/m4/ax_valgrind_check.m4 \
 	$(top_srcdir)/m4/virt-linker-no-indirect.m4 \
 	$(top_srcdir)/m4/virt-linker-relro.m4 \
 	$(top_srcdir)/m4/warnings.m4 \
-	$(top_srcdir)/spice-common/m4/spice-deps.m4 \
+	$(top_srcdir)/subprojects/spice-common/m4/spice-deps.m4 \
 	$(top_srcdir)/configure.ac
 am__configure_deps = $(am__aclocal_m4_deps) $(CONFIGURE_DEPENDENCIES) \
 	$(ACLOCAL_M4)
@@ -174,7 +174,7 @@ am__recursive_targets = \
   $(RECURSIVE_CLEAN_TARGETS) \
   $(am__extra_recursive_targets)
 AM_RECURSIVE_TARGETS = $(am__recursive_targets:-recursive=) TAGS CTAGS \
-	cscope distdir dist dist-all distcheck
+	cscope distdir distdir-am dist dist-all distcheck
 am__tagged_files = $(HEADERS) $(SOURCES) $(TAGS_FILES) \
 	$(LISP)config.h.in
 # Read a list of newline-separated strings from the standard input,
@@ -199,7 +199,7 @@ CSCOPE = cscope
 DIST_SUBDIRS = $(SUBDIRS)
 am__DIST_COMMON = $(srcdir)/Makefile.in $(srcdir)/config.h.in \
 	$(srcdir)/spice-server.pc.in AUTHORS COPYING ChangeLog INSTALL \
-	NEWS README compile config.guess config.sub install-sh \
+	NEWS README compile config.guess config.sub depcomp install-sh \
 	ltmain.sh missing
 DISTFILES = $(DIST_COMMON) $(DIST_SOURCES) $(TEXINFOS) $(EXTRA_DIST)
 distdir = $(PACKAGE)-$(VERSION)
@@ -278,6 +278,8 @@ ENABLE_VALGRIND_memcheck = @ENABLE_VALGRIND_memcheck@
 ENABLE_VALGRIND_sgcheck = @ENABLE_VALGRIND_sgcheck@
 EXEEXT = @EXEEXT@
 FGREP = @FGREP@
+GIO_UNIX_CFLAGS = @GIO_UNIX_CFLAGS@
+GIO_UNIX_LIBS = @GIO_UNIX_LIBS@
 GLIB2_CFLAGS = @GLIB2_CFLAGS@
 GLIB2_LIBS = @GLIB2_LIBS@
 GOBJECT2_CFLAGS = @GOBJECT2_CFLAGS@
@@ -343,6 +345,7 @@ SET_MAKE = @SET_MAKE@
 SHELL = @SHELL@
 SMARTCARD_CFLAGS = @SMARTCARD_CFLAGS@
 SMARTCARD_LIBS = @SMARTCARD_LIBS@
+SPICE_COMMON_DIR = @SPICE_COMMON_DIR@
 SPICE_LT_VERSION = @SPICE_LT_VERSION@
 SPICE_NONPKGCONFIG_CFLAGS = @SPICE_NONPKGCONFIG_CFLAGS@
 SPICE_NONPKGCONFIG_LIBS = @SPICE_NONPKGCONFIG_LIBS@
@@ -419,18 +422,21 @@ valgrind_enabled_tools = @valgrind_enabled_tools@
 valgrind_tools = @valgrind_tools@
 NULL = 
 ACLOCAL_AMFLAGS = -I m4
-SUBDIRS = spice-common server docs tools
+SUBDIRS = subprojects/spice-common server docs tools
 pkgconfigdir = $(libdir)/pkgconfig
 pkgconfig_DATA = spice-server.pc
 DISTCHECK_CONFIGURE_FLAGS = \
-	--enable-automated-tests		\
+	--disable-celt051			\
 	--enable-smartcard			\
 	--with-sasl				\
 	--enable-manual				\
 	$(NULL)
 
 EXTRA_DIST = \
+	meson.build				\
+	meson_options.txt			\
 	build-aux/git-version-gen		\
+	build-aux/meson/check-spice-common	\
 	.version				\
 	$(NULL)
 
@@ -460,8 +466,8 @@ Makefile: $(srcdir)/Makefile.in $(top_builddir)/config.status
 	    echo ' $(SHELL) ./config.status'; \
 	    $(SHELL) ./config.status;; \
 	  *) \
-	    echo ' cd $(top_builddir) && $(SHELL) ./config.status $@ $(am__depfiles_maybe)'; \
-	    cd $(top_builddir) && $(SHELL) ./config.status $@ $(am__depfiles_maybe);; \
+	    echo ' cd $(top_builddir) && $(SHELL) ./config.status $@ $(am__maybe_remake_depfiles)'; \
+	    cd $(top_builddir) && $(SHELL) ./config.status $@ $(am__maybe_remake_depfiles);; \
 	esac;
 
 $(top_builddir)/config.status: $(top_srcdir)/configure $(CONFIG_STATUS_DEPENDENCIES)
@@ -626,7 +632,10 @@ distclean-tags:
 	-rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
 	-rm -f cscope.out cscope.in.out cscope.po.out cscope.files
 
-distdir: $(DISTFILES)
+distdir: $(BUILT_SOURCES)
+	$(MAKE) $(AM_MAKEFLAGS) distdir-am
+
+distdir-am: $(DISTFILES)
 	$(am__remove_distdir)
 	test -d "$(distdir)" || mkdir "$(distdir)"
 	@srcdirstrip=`echo "$(srcdir)" | sed 's/[].[^$$\\*]/\\\\&/g'`; \
diff --git a/NEWS b/NEWS
index 51bb4a2..168e20d 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,56 @@
+Major Changes in 0.14.2:
+========================
+
+Main changes are support for Meson build and graphic device info
+messages allowing to better support multi-monitor configurations.
+
+* CVE-2019-3813: fix off-by-one error in group/slot boundary check
+* support H265 in stream-channel
+* add support for building with meson/ninja
+* minor tests fixes improving CI
+* set char device state for smartcard, allowing Qemu optimization
+* improve red-parse-qxl.c interface making it more consistent
+* add some instrumentation for streaming device
+* QXL interface: add a function to identify monitors in the guest
+  (spice_qxl_set_device_info)
+* add support for GraphicsDeviceInfo messages
+* video-stream: prevent crash on stream reattach
+* make channel client callbacks virtual functions
+* bumped minimum required glib version to 2.38
+* attempt to have a reliable led state for keyboard modifiers
+
+Major Changes in 0.14.1:
+========================
+
+The main change in this release is the addition of a new protocol extension
+in order to support streaming the remote display as a video stream rather than
+going through the QXL protocol. Together with spice-streaming-agent, and/or with
+more work on the qemu/spice-server side, this should allow streaming of 3D
+accelerated VMs in the future. At this point, this part of spice-server is
+still a work in progress (multi-monitor support and various features are
+missing).
+
+* add new org.spice-space.stream.0 channel used for passing an encoded video
+  stream from the guest to the client
+* add support for TCP_CORK to reduce the amount of packets that we send
+* fix CVE-2018-10873
+* fix cursor related migration crash
+* fix regression causing sound recording to be muted after
+  client disconnection/reconnection (introduced in 0.13.90)
+* fix regression in corner cases where images could be sent uncompressed
+  when they used to be compressed with QUIC
+* disable TLS 1.0 support
+* CELT 0.5.1 support is now disabled by default. If celt051-devel is installed
+  at build-time, --enable-celt051/--disable-celt051 must be explicitly specified
+* drop support for unsupported OpenSSL version. OpenSSL 1.0.0 or newer is now
+  required
+* bumped minimum required glib version to 2.32
+* endianness fixes
+* (small) leak fixes
+* usual round of code cleanups
+* not directly related to this release, but the upstream git repository is now
+  hosted on gitlab.freedesktop.org
+
 Major Changes in 0.14.0:
 ========================
 
diff --git a/README b/README
index 4aaf6a7..59d2367 100644
--- a/README
+++ b/README
@@ -27,7 +27,7 @@ Or to install into a private user specific location
 The following mandatory dependencies are required in order to
 build SPICE
 
-    Spice protocol >= 0.12.13
+    Spice protocol >= 0.14.0
     Pixman         >= 0.17.7
     OpenSSL
     libjpeg
@@ -37,7 +37,7 @@ The following optional dependencies increase the available
 functionality
 
     Cyrus-SASL
-    libcacard      >= 0.1.2             (Smartcard support)
+    libcacard      >= 2.5.1             (Smartcard support)
     Opus           >= 1.0.0             (Opus audio encoding support)
     LZ4                                 (LZ4 compression support)
     GStreamer      >= 1.0.0
@@ -56,14 +56,14 @@ There is also a mailing list for new release announcements:
 
 To view known bugs, or report new bugs, in SPICE visit
 
-   https://bugs.freedesktop.org/describecomponents.cgi?product=Spice
+   https://gitlab.freedesktop.org/spice/spice/issues/new?
 
 Bugs found when using an OS distribution's binary packages should
 be reported to the OS vendors' own bug tracker first.
 
 The latest SPICE code can be found in GIT at:
 
-   https://cgit.freedesktop.org/spice/
+   https://gitlab.freedesktop.org/spice/
 
 Licensing
 ---------
diff --git a/aclocal.m4 b/aclocal.m4
index 6462a22..9a3219a 100644
--- a/aclocal.m4
+++ b/aclocal.m4
@@ -1,6 +1,6 @@
-# generated automatically by aclocal 1.15 -*- Autoconf -*-
+# generated automatically by aclocal 1.16.1 -*- Autoconf -*-
 
-# Copyright (C) 1996-2014 Free Software Foundation, Inc.
+# Copyright (C) 1996-2018 Free Software Foundation, Inc.
 
 # This file is free software; the Free Software Foundation
 # gives unlimited permission to copy and/or distribute it,
@@ -364,7 +364,7 @@ AS_IF([test "$AS_TR_SH([with_]m4_tolower([$1]))" = "yes"],
         [AC_DEFINE([HAVE_][$1], 1, [Enable ]m4_tolower([$1])[ support])])
 ])dnl PKG_HAVE_DEFINE_WITH_MODULES
 
-# Copyright (C) 2002-2014 Free Software Foundation, Inc.
+# Copyright (C) 2002-2018 Free Software Foundation, Inc.
 #
 # This file is free software; the Free Software Foundation
 # gives unlimited permission to copy and/or distribute it,
@@ -376,10 +376,10 @@ AS_IF([test "$AS_TR_SH([with_]m4_tolower([$1]))" = "yes"],
 # generated from the m4 files accompanying Automake X.Y.
 # (This private macro should not be called outside this file.)
 AC_DEFUN([AM_AUTOMAKE_VERSION],
-[am__api_version='1.15'
+[am__api_version='1.16'
 dnl Some users find AM_AUTOMAKE_VERSION and mistake it for a way to
 dnl require some minimum version.  Point them to the right macro.
-m4_if([$1], [1.15], [],
+m4_if([$1], [1.16.1], [],
       [AC_FATAL([Do not call $0, use AM_INIT_AUTOMAKE([$1]).])])dnl
 ])
 
@@ -395,14 +395,14 @@ m4_define([_AM_AUTOCONF_VERSION], [])
 # Call AM_AUTOMAKE_VERSION and AM_AUTOMAKE_VERSION so they can be traced.
 # This function is AC_REQUIREd by AM_INIT_AUTOMAKE.
 AC_DEFUN([AM_SET_CURRENT_AUTOMAKE_VERSION],
-[AM_AUTOMAKE_VERSION([1.15])dnl
+[AM_AUTOMAKE_VERSION([1.16.1])dnl
 m4_ifndef([AC_AUTOCONF_VERSION],
   [m4_copy([m4_PACKAGE_VERSION], [AC_AUTOCONF_VERSION])])dnl
 _AM_AUTOCONF_VERSION(m4_defn([AC_AUTOCONF_VERSION]))])
 
 # AM_AUX_DIR_EXPAND                                         -*- Autoconf -*-
 
-# Copyright (C) 2001-2014 Free Software Foundation, Inc.
+# Copyright (C) 2001-2018 Free Software Foundation, Inc.
 #
 # This file is free software; the Free Software Foundation
 # gives unlimited permission to copy and/or distribute it,
@@ -452,9 +452,46 @@ AC_DEFUN([AM_AUX_DIR_EXPAND],
 am_aux_dir=`cd "$ac_aux_dir" && pwd`
 ])
 
+# AM_COND_IF                                            -*- Autoconf -*-
+
+# Copyright (C) 2008-2018 Free Software Foundation, Inc.
+#
+# This file is free software; the Free Software Foundation
+# gives unlimited permission to copy and/or distribute it,
+# with or without modifications, as long as this notice is preserved.
+
+# _AM_COND_IF
+# _AM_COND_ELSE
+# _AM_COND_ENDIF
+# --------------
+# These macros are only used for tracing.
+m4_define([_AM_COND_IF])
+m4_define([_AM_COND_ELSE])
+m4_define([_AM_COND_ENDIF])
+
+# AM_COND_IF(COND, [IF-TRUE], [IF-FALSE])
+# ---------------------------------------
+# If the shell condition COND is true, execute IF-TRUE, otherwise execute
+# IF-FALSE.  Allow automake to learn about conditional instantiating macros
+# (the AC_CONFIG_FOOS).
+AC_DEFUN([AM_COND_IF],
+[m4_ifndef([_AM_COND_VALUE_$1],
+	   [m4_fatal([$0: no such condition "$1"])])dnl
+_AM_COND_IF([$1])dnl
+if test -z "$$1_TRUE"; then :
+  m4_n([$2])[]dnl
+m4_ifval([$3],
+[_AM_COND_ELSE([$1])dnl
+else
+  $3
+])dnl
+_AM_COND_ENDIF([$1])dnl
+fi[]dnl
+])
+
 # AM_CONDITIONAL                                            -*- Autoconf -*-
 
-# Copyright (C) 1997-2014 Free Software Foundation, Inc.
+# Copyright (C) 1997-2018 Free Software Foundation, Inc.
 #
 # This file is free software; the Free Software Foundation
 # gives unlimited permission to copy and/or distribute it,
@@ -485,7 +522,7 @@ AC_CONFIG_COMMANDS_PRE(
 Usually this means the macro was only invoked conditionally.]])
 fi])])
 
-# Copyright (C) 1999-2014 Free Software Foundation, Inc.