Code review comment for ~paelzer/ubuntu/+source/qemu:bug-1847361-miss-old-so-on-upgrade-SRU-BIONIC

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

# checklist for fixes
----------------------------
 [.] changelog entry correct:
 [.] targeted to correct codename
 [.] version number is correct
 [.] update-maintainer has been run before
 ----
 [.] changes forwarded upstream/debian (if appropriate)
 [.] patches match what was proposed upstream
 ----
 [.] patches correctly included in debian/patches/series?
 [.] patches have correct DEP3 metadata
 ----
 [-] relying on PPA only for build check ?
 [-] if relying on PPA, did it install correctly ?
 ----
 [-] building it locally ?
 [-] if building locally, was source build good ?
 [-] if building locally, was binary build good ?
 ----
 [-] was autopkgtest tested ?
 [.] relying on committer tests ?
 ----
 [.] is this a SRU ?
 [.] if a SRU, does the public bug have a template ?
 [-] is this a bundle of fixes ?
 [.] is this a single fix ?
 ----
 [-] if single fix, was testcase provided ?
 [-] if single fix, and testcase provided, could I reproduce it ?
 [-] if single fix, and testcase provided, did it work ?
 [.] relying on committer verification ?
----------------------------
 [.] = ok
 [x] = not ok
 [?] = question
 [!] = note
 [-] = n/a
----------------------------
# files touched:

 /debian/patches/ubuntu/lp-1847361-modules-load-upgrade.patch | 125 (trunc)
 b/debian/changelog | 11 ++++++
 b/debian/patches/series | 1
 b/debian/patches/ubuntu/lp-1847361-modules-load-upgrade.patch | 7 +++-
 b/debian/qemu-block-extra.postrm.in | 43 +++++++++
 b/debian/qemu-block-extra.prerm.in | 45 +++++++++
 b/debian/rules | 1
 debian/patches/ubuntu/lp-1847361-modules-load-upgrade.patch | 49 (trunc)
 debian/rules | 10 +++++
 ui/keycodemapdb/..git | 1
 10 files changed, 268 insertions(+), 25 deletions(-)
----------------------------
# files check:

ubuntu/lp-1847361-modules-load-upgrade.patch -> ok
debian/qemu-block-extra.postrm.in -> already changed brrr
debian/qemu-block-extra.prerm.in -> ok
debian/rules -> ok
debian/patches/ubuntu/lp-1847361-modules-load-upgrade.patch -> ok

----------------------------
# comments:

all good -> +1.
----------------------------
# commits:

49352e8f93c fixup: remove mismatch between gt and src tarball
3dcbbb29a6a changelog: allow qemu to load old modules post upgrade (LP: #184736
c099ef1838f d/p/ubuntu/lp-1847361-modules-load-upgrade.patch: adapt context for
e5b66304e41 d/rules: enable --enable-module-upgrades where --enable-modules is
ce7e5322c27 d/rules: generate maintainer scripts matching package version
c8bdada6f54 d/qemu-block-extra.*.in: save shared objects on upgrade
ce8fcf051c7 d/p/ubuntu/lp-1847361-modules-load-upgrade.patch: allow qemu to loa
----------------------------

review: Approve

« Back to merge proposal