Merge ~paelzer/ubuntu/+source/network-manager:fix-lp-1894619-changed-dnsmasq-behavior into ubuntu/+source/network-manager:ubuntu/impish-devel
Proposed by
Christian Ehrhardt
Status: | Merged |
---|---|
Approved by: | Christian Ehrhardt |
Approved revision: | 7896e0e2a4c1aafce6bdad53479a4bae7a06cf5d |
Merge reported by: | Christian Ehrhardt |
Merged at revision: | 7896e0e2a4c1aafce6bdad53479a4bae7a06cf5d |
Proposed branch: | ~paelzer/ubuntu/+source/network-manager:fix-lp-1894619-changed-dnsmasq-behavior |
Merge into: | ubuntu/+source/network-manager:ubuntu/impish-devel |
Diff against target: |
27 lines (+7/-1) 2 files modified
debian/changelog (+6/-0) debian/tests/nm.py (+1/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Iain Lane (community) | Approve | ||
Desktop Packages | Pending | ||
Canonical Server | Pending | ||
Canonical Server packageset reviewers | Pending | ||
git-ubuntu developers | Pending | ||
Review via email: mp+405081@code.launchpad.net |
To post a comment you must log in.
Thanks Christian. Assuming you've tested this it looks fine to merge, but two things
- I'm not sure we shouldn't drop 'dynamic' if that's not expected any more (and bump the required version of dnsmasq then). I could go either way on this - what do you think? /code.launchpad .net/~network- manager/ network- manager/ +git/ubuntu/ +ref/ubuntu/ master
- Please do the change in https:/
Feel free to make the change, or not, merge and upload - thanks!