Code review comment for ~paelzer/ubuntu/+source/network-manager:fix-lp-1894619-changed-dnsmasq-behavior

Revision history for this message
Iain Lane (laney) wrote :

Thanks Christian. Assuming you've tested this it looks fine to merge, but two things

  - I'm not sure we shouldn't drop 'dynamic' if that's not expected any more (and bump the required version of dnsmasq then). I could go either way on this - what do you think?
  - Please do the change in https://code.launchpad.net/~network-manager/network-manager/+git/ubuntu/+ref/ubuntu/master

Feel free to make the change, or not, merge and upload - thanks!

review: Approve

« Back to merge proposal