Merge ~paelzer/ubuntu/+source/irqbalance:lp-2046470-fix-log-spam-NOBLE into ubuntu/+source/irqbalance:ubuntu/noble-devel

[Christian Ehrhardt ]

[Christian Ehrhardt  (paelzer)]

PPA: https://launchpad.net/~paelzer/+archive/ubuntu/lp-2046470-fix-log-spam-noble

[Athos Ribeiro (athos-ribeiro)]

Thanks, Christian!

This looks reasonable to me (+1).

The only comment I have here is regarding the "Origin" DEP3 header. Since upstream did not merge (or comment) the patch yet, it seems that the PR or commit URL should go in the "Forwarded" field. From the "Origin" field definition, removing the "upstream, " part of it should be enough to comply to the definition as well.

The reason I am pointing to this header is that it could lead to another person touching the package to overlook that patch in case it is rejected or changed by upstream.

I will not block this on that header though. Once you fix it or disagree with the assessment, go ahead and upload this one :)

review: Approve

[git-ubuntu bot (git-ubuntu-bot)]

Approvers: paelzer, athos-ribeiro
Uploaders: paelzer, athos-ribeiro
MP auto-approved

review: Approve

[Christian Ehrhardt  (paelzer)]

Thanks, uploaded

diff --git a/debian/changelog b/debian/changelog
index c192dd9..6cd1abd 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+irqbalance (1.9.3-2ubuntu1) noble; urgency=medium
+
+  * d/p/lp-2046470-Stop-log-spam-due-to-debug-message-from-scan.patch:
+    reduce log spam by debug message (LP: #2046470)
+
+ -- Christian Ehrhardt <[e-mail]>  Fri, 05 Jan 2024 14:30:02 +0100
+
 irqbalance (1.9.3-2) unstable; urgency=medium
 
   * d/p/filter-console-only-output-when-using-journal-mode.debpatch:
diff --git a/debian/control b/debian/control
index 8524c3d..38ebba3 100644
--- a/debian/control
+++ b/debian/control
@@ -1,7 +1,8 @@
 Source: irqbalance
 Section: utils
 Priority: optional
-Maintainer: Paride Legovini <[e-mail]>
+Maintainer: Ubuntu Developers <[e-mail]>
+XSBC-Original-Maintainer: Paride Legovini <[e-mail]>
 Build-Depends:
  debhelper-compat (= 13),
  dh-exec,
diff --git a/debian/patches/lp-2046470-Stop-log-spam-due-to-debug-message-from-scan.patch b/debian/patches/lp-2046470-Stop-log-spam-due-to-debug-message-from-scan.patch
 new file mode 100644
index 0000000..4466e53
--- /dev/null
+++ b/debian/patches/lp-2046470-Stop-log-spam-due-to-debug-message-from-scan.patch
@@ -0,0 +1,44 @@
+From a27df6e7a29fad744494a5a1432bb3ed6799cb7d Mon Sep 17 00:00:00 2001
+From: Christian Ehrhardt <[e-mail]>
+Date: Fri, 5 Jan 2024 14:11:49 +0100
+Subject: [PATCH] Stop log spam due to debug message from scan
+
+Currently systems encounter log spam every 10 seconds due to a
+message meant for debugging now being forwarded to journald.
+Users get three empty lines followed by 78 "-" without any further
+info what this is about.
+
+Due to its original debug-only purpose the message also grabs
+a lot of screen-estate. So while touching it anyway let us also make
+it a bit less agressive (no three lead line breaks, less width),
+now it is like:
+  ----- Enter: scan -----
+
+Fixes: #292
+
+Signed-off-by: Christian Ehrhardt <[e-mail]>
+
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/irqbalance/+bug/2046470
+Origin: upstream, https://github.com/Irqbalance/irqbalance/pull/293/commits/a27df6e7a29fad744494a5a1432bb3ed6799cb7d
+Last-Update: 2024-01-05
+
+---
+ irqbalance.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/irqbalance.c b/irqbalance.c
+index f5f2c51..d38c153 100644
+--- a/irqbalance.c
++++ b/irqbalance.c
+@@ -289,7 +289,7 @@ gboolean force_rescan(gpointer data __attribute__((unused)))
+ 
+ gboolean scan(gpointer data __attribute__((unused)))
+ {
+-	log(TO_CONSOLE, LOG_INFO, "\n\n\n-----------------------------------------------------------------------------\n");
++	log(TO_CONSOLE, LOG_DEBUG, "----- Enter: %s -----\n", __func__);
+ 	clear_work_stats();
+ 	parse_proc_interrupts();
+ 
+-- 
+2.34.1
+
diff --git a/debian/patches/series b/debian/patches/series
index 41e93c6..27b1cf5 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
 filter-console-only-output-when-using-journal-mode.debpatch
+lp-2046470-Stop-log-spam-due-to-debug-message-from-scan.patch