Ubuntu
irqbalance package

Code review comment for ~paelzer/ubuntu/+source/irqbalance:lp-2046470-fix-log-spam-NOBLE

  1. Git
  2. lp:~paelzer/ubuntu/+source/irqbalance
  3. lp-2046470-fix-log-spam-NOBLE
  4. Merge into ubuntu/noble-devel
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Thanks, Christian!

This looks reasonable to me (+1).

The only comment I have here is regarding the "Origin" DEP3 header. Since upstream did not merge (or comment) the patch yet, it seems that the PR or commit URL should go in the "Forwarded" field. From the "Origin" field definition, removing the "upstream, " part of it should be enough to comply to the definition as well.

The reason I am pointing to this header is that it could lead to another person touching the package to overlook that patch in case it is rejected or changed by upstream.

I will not block this on that header though. Once you fix it or disagree with the assessment, go ahead and upload this one :)

review: Approve

« Back to merge proposal