Code review comment for ~paelzer/ubuntu/+source/gpsd:gpsd-fixed-apr-2020-focal

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

* Changelog:
  - [-] old content and logical tag match as expected
  - [√] changelog entry correct version and targeted codename
  - [√] changelog entries correct
  - [x] update-maintainer has been run

* Actual changes:
  - [√] no upstream changes to consider
  - [-] no further upstream version to consider
  - [√] debian changes look safe

* Old Delta:
  - [-] dropped changes are ok to be dropped
  - [-] nothing else to drop
  - [-] changes forwarded upstream/debian (if appropriate)

* New Delta:
  - [√] no new patches added
  - [√] patches match what was proposed upstream
  - [-] patches correctly included in debian/patches/series
  - [-] patches have correct DEP3 metadata

I think the only thing missing is to run the update-maintainer script. After fixing it you are good to go.

review: Needs Fixing

« Back to merge proposal