Code review comment for lp:~paelzer/serverguide/serverguide-ntp-clarification

Revision history for this message
Doug Smythies (dsmythies) wrote :

This all looks good. However...

The non-ascii character check fails:

$ scripts/ascii_checker.py --only-matching --encoding ascii serverguide/C/*.xml
  1111: ��� systemd-timesyncd.service - Network Time Synchronization

  1114: ������disable-with-time-daemon.conf

  1123: ������12379 /lib/systemd/systemd-timesyncd

--------------------------------------------------------------------------------
2018 lines in 'serverguide/C/network-config.xml', thereof 3 lines with non-ASCII characters.

and, the PDF compile has issues:

[INFO] FOUserAgent - Rendered page #53.
[INFO] FOUserAgent - Rendered page #54.
[WARN] FOUserAgent - Glyph "●" (0x25cf, H18533) not available in font "Courier".
[WARN] FOUserAgent - Glyph "└" (0x2514, SF020000) not available in font "Courier".
[WARN] FOUserAgent - Glyph "─" (0x2500, SF100000) not available in font "Courier".
[INFO] FOUserAgent - Rendered page #55.
[INFO] FOUserAgent - Rendered page #56.

I will change those characters to ASCII to try to achieve a similar look to the original output.

See also:
https://wiki.ubuntu.com/DocumentationTeam/SystemDocumentation/Repository/Members-Serverguide#ASCII_Policy

review: Approve

« Back to merge proposal