Code review comment for lp:~osomon/ubuntu-calendar-app/fix-ap-test-assumption
Revision history for this message
| Olivier Tilloy (osomon) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
As pointed out by Riccardo, deleting the db before running the tests ensures that the test will always pass.
Assuming that the db is clean is not safe though (unless we modify the test runner to clear the db before each run).
I would advise to merge this change as is. It won’t make the test pass all the time (because of bug #1219930), but it should still make the situation better.