Merge lp:~osomon/ubuntu-calendar-app/fix-ap-test-assumption into lp:ubuntu-calendar-app

[Olivier Tilloy]

Do not assume there will always be a label with the given text.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:99
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/33/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests/138
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-ci/33
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-ci/33
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/33
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/33

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/33/rebuild

review: Needs Fixing (continuous-integration)

[Kunal Parmar (pkunal-parmar)]

But if test runs multiple times then it will have more than one label with same text, as currently we are using hard coded time.

review: Needs Information

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:100
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/34/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests/139
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-ci/34
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-ci/34
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/34
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/34

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/34/rebuild

review: Approve (continuous-integration)

[Kunal Parmar (pkunal-parmar)]

> But if test runs multiple times then it will have more than one label with
> same text, as currently we are using hard coded time.

Sorry, i misinterpreted the code. Just ignore the comment

[Riccardo Padovani (rpadovani)]

I tried to do the tests without a clean enviroment, and it doesn't passed: http://paste.ubuntu.com/6055487/

After this, I delete the database from ~/.locale and it passed.

[Kunal Parmar (pkunal-parmar)]

So reason for the fail was due to multiple labels, I thought there is some timing issue ?

[Olivier Tilloy (osomon)]

I just spent quite some time investigating why the test sometimes passed, and sometimes failed.
It turns out the logic in TimeLineBase.qml is rather broken: it creates an event map that associates one event to each hour of the day. That means that there cannot be more than one event for a given slot of one hour. Obviously this doesn’t work. I filed bug #1219930 to track the issue.

[Olivier Tilloy (osomon)]

As pointed out by Riccardo, deleting the db before running the tests ensures that the test will always pass.
Assuming that the db is clean is not safe though (unless we modify the test runner to clear the db before each run).

I would advise to merge this change as is. It won’t make the test pass all the time (because of bug #1219930), but it should still make the situation better.

[Kunal Parmar (pkunal-parmar)]

I agree, I will work on bug you mentioned.

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/8/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests/157
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-autolanding/8
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-autolanding/8
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-autolanding/8
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-autolanding/8

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/13/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests/171
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-autolanding/13
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-autolanding/13
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-autolanding/13
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-autolanding/13

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/14/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests/172
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-autolanding/14
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-autolanding/14
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-autolanding/14
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-autolanding/14

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

review: Approve (continuous-integration)

=== modified file 'tests/autopilot/calendar_app/emulators/main_view.py'
--- tests/autopilot/calendar_app/emulators/main_view.py	2013-08-27 14:41:12 +0000
+++ tests/autopilot/calendar_app/emulators/main_view.py	2013-09-02 14:45:40 +0000
@@ -26,7 +26,11 @@
         return self.select_single("DayView")
 
     def get_title_label(self, title):
-        return self.select_many("Label", text=title)[0]
+        labels = self.select_many("Label", text=title)
+        if (len(labels) > 0):
+            return labels[0]
+        else:
+            return None
 
     def get_new_event(self):
         return self.select_single("NewEvent")