Merge lp:~osomon/software-center/one_database_per_language into lp:software-center
Status: | Rejected |
---|---|
Rejected by: | dobey |
Proposed branch: | lp:~osomon/software-center/one_database_per_language |
Merge into: | lp:software-center |
Diff against target: |
498 lines (+95/-65) 19 files modified
.bzrignore (+1/-14) debian/software-center.postinst (+5/-0) softwarecenter/app.py (+2/-3) softwarecenter/db/database.py (+56/-0) softwarecenter/view/appview.py (+2/-5) softwarecenter/view/availablepane.py (+2/-3) softwarecenter/view/channelpane.py (+2/-3) softwarecenter/view/historypane.py (+2/-4) softwarecenter/view/installedpane.py (+2/-3) softwarecenter/view/viewswitcher.py (+2/-4) test/test_appview.py (+2/-5) utils/bench.py (+2/-2) utils/installedapps.py (+2/-2) utils/query.py (+2/-2) utils/search_query.py (+2/-3) utils/stats.py (+2/-2) utils/topapps.py (+2/-2) utils/update-software-center (+3/-6) utils/wildcard_query_parser.py (+2/-2) |
To merge this branch: | bzr merge lp:~osomon/software-center/one_database_per_language |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Vogt | Needs Fixing | ||
Review via email: mp+23870@code.launchpad.net |
Description of the change
This branch intends to fix bug #434601 by implementing the solution proposed by mpt in comment #1: store one database per language code, since the contents of the database is localized. Where the database was previously stored in a "xapian" directory on disk, it is now stored in "xapian.
Comments on this approach are welcome.
Unmerged revisions
- 751. By Olivier Tilloy
-
When the database path for the current locale doesn't exist
or cannot be created, try to fall back gracefully to an existing database. - 750. By Olivier Tilloy
-
Merged Michael's changes to the post-installation script.
- 749. By Olivier Tilloy
-
Merged from trunk.
- 748. By Olivier Tilloy
-
Use get_database_path everywhere to instantiate the DB.
- 747. By Olivier Tilloy
-
Merged from trunk.
- 746. By Olivier Tilloy
-
Separate function to compute the database path on disk, depending on the current locale.
- 745. By Olivier Tilloy
-
Merged from trunk.
- 744. By Olivier Tilloy
-
Handle nicely broken locales: fall back to C.
- 743. By Olivier Tilloy
-
Store one database per language code.
Thanks for the patch. It will need similar logic in utils/update- sofware- center when it rebuilds the database. Best is probably to consolidate the name with language added in one place.