Merge lp:~osomon/chromium-browser/bionic-stable-osk-a11y-lp1697641 into lp:~chromium-team/chromium-browser/bionic-stable

Proposed by Olivier Tilloy on 2018-06-05
Status: Needs review
Proposed branch: lp:~osomon/chromium-browser/bionic-stable-osk-a11y-lp1697641
Merge into: lp:~chromium-team/chromium-browser/bionic-stable
Diff against target: 33 lines (+15/-0)
2 files modified
debian/changelog (+7/-0)
debian/chromium-browser.sh.in (+8/-0)
To merge this branch: bzr merge lp:~osomon/chromium-browser/bionic-stable-osk-a11y-lp1697641
Reviewer Review Type Date Requested Status
Chromium team 2018-06-05 Pending
Review via email: mp+347441@code.launchpad.net

Commit message

* debian/chromium-browser.sh.in: conditionally enable accessibility for the on-screen keyboard to pop-up when a text field is focused (LP: #1697641)

To post a comment you must log in.
Mikhail Novosyolov (mikhailnov) wrote :

readonly osk_enabled=$(gsettings get org.gnome.desktop.a11y.applications screen-keyboard-enabled)

it would be better to use
readonly osk_enabled="$(gsettings get org.gnome.desktop.a11y.applications screen-keyboard-enabled)"

shellcheck can explain why very well

Olivier Tilloy (osomon) wrote :

shellcheck 0.5.0 doesn't complain about that particular line (it does issue a bunch of warnings/suggestions for other things in that script though).

Unmerged revisions

1423. By Olivier Tilloy on 2018-06-05

* debian/chromium-browser.sh.in: conditionally enable accessibility for the on-screen keyboard to pop-up when a text field is focused (LP: #1697641)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2018-06-05 11:36:39 +0000
+++ debian/changelog 2018-06-05 12:12:13 +0000
@@ -1,3 +1,10 @@
1chromium-browser (67.0.3396.62-0ubuntu0.18.04.2) UNRELEASED; urgency=medium
2
3 * debian/chromium-browser.sh.in: conditionally enable accessibility for the
4 on-screen keyboard to pop-up when a text field is focused (LP: #1697641)
5
6 -- Olivier Tilloy <olivier.tilloy@canonical.com> Tue, 05 Jun 2018 13:57:49 +0200
7
1chromium-browser (67.0.3396.62-0ubuntu0.18.04.1) bionic; urgency=medium8chromium-browser (67.0.3396.62-0ubuntu0.18.04.1) bionic; urgency=medium
29
3 * Upstream release: 67.0.3396.6210 * Upstream release: 67.0.3396.62
411
=== modified file 'debian/chromium-browser.sh.in'
--- debian/chromium-browser.sh.in 2017-09-25 21:38:35 +0000
+++ debian/chromium-browser.sh.in 2018-06-05 12:12:13 +0000
@@ -144,6 +144,14 @@
144 export CHROME_VERSION_EXTRA="Built on $BUILD_DIST, running on $DIST $RELEASE"144 export CHROME_VERSION_EXTRA="Built on $BUILD_DIST, running on $DIST $RELEASE"
145fi145fi
146146
147# Conditionally enable accessibility for the on-screen keyboard to pop-up when
148# a text field is focused (LP: #1697641).
149readonly osk_enabled=$(gsettings get org.gnome.desktop.a11y.applications screen-keyboard-enabled)
150if [ "$osk_enabled" = "true" ] ; then
151 export ACCESSIBILITY_ENABLED=1
152 CHROMIUM_FLAGS="$CHROMIUM_FLAGS --force-renderer-accessibility"
153fi
154
147want_touch_pinch=1155want_touch_pinch=1
148want_debug=0156want_debug=0
149want_temp_profile=0157want_temp_profile=0

Subscribers

People subscribed via source and target branches

to all changes: