Chromium Browser

Code review comment for lp:~osomon/chromium-browser/bionic-stable-osk-a11y-lp1697641

  1. bionic-stable-osk-a11y-lp1697641
  2. Merge into bionic-stable
Revision history for this message
Mikhail Novosyolov (mikhailnov) wrote :

readonly osk_enabled=$(gsettings get org.gnome.desktop.a11y.applications screen-keyboard-enabled)

it would be better to use
readonly osk_enabled="$(gsettings get org.gnome.desktop.a11y.applications screen-keyboard-enabled)"

shellcheck can explain why very well

Reply

« Back to merge proposal