Code review comment for lp:~optimisme/pantheon-files/1067061

Revision history for this message
Victor Martinez (victored) wrote :

Looks good Albert!

Generally, we prefer:

> if (condition_a
> || condition_b
> || condition_c)
> {
> // do something
> }

Over:

> if (condition_a) {
> // do something
> }
>
> if (condition_b) {
> // do something
> }
>
> if (condition_c) {
> // do something
> }

so that the code in "do something" is not repeated

We also encourage:

> if (condition_a && condition_b)
> // do something

instead of:

> if (condition_a)
> if (condition_b)
> // do something

« Back to merge proposal