Merge lp:~optimisme/pantheon-files/1067061 into lp:~elementary-apps/pantheon-files/trunk
Proposed by
Albert
Status: | Merged |
---|---|
Merged at revision: | 1178 |
Proposed branch: | lp:~optimisme/pantheon-files/1067061 |
Merge into: | lp:~elementary-apps/pantheon-files/trunk |
Diff against target: |
48 lines (+13/-11) 2 files modified
libcore/gof-file.c (+10/-9) src/marlin-thumbnailer.c (+3/-2) |
To merge this branch: | bzr merge lp:~optimisme/pantheon-files/1067061 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Cody Garver (community) | Approve | ||
Review via email: mp+164572@code.launchpad.net |
Description of the change
Check if a file is remote before asking for a thumbnail, and improved/modified remote scheme test
To post a comment you must log in.
Looks good Albert!
Generally, we prefer:
> if (condition_a
> || condition_b
> || condition_c)
> {
> // do something
> }
Over:
> if (condition_a) {
> // do something
> }
>
> if (condition_b) {
> // do something
> }
>
> if (condition_c) {
> // do something
> }
so that the code in "do something" is not repeated
We also encourage:
> if (condition_a && condition_b)
> // do something
instead of:
> if (condition_a)
> if (condition_b)
> // do something