Merge lp:~openerp/openobject-client-web/callto_widget into lp:openobject-client-web/5.0

[Husen Daudi]

Added widget for callto: protocol.

[Xavier (Open ERP) (xmo-deactivatedaccount)]

After discussions with noz, we're rejecting for merge into 5.0:

* It's a new feature, and 5.0 is in maintenance
* For trunk, we would prefer a more general URI widget which could take full URIs or an arbitrary URI scheme (maybe with pre-created list of schemes) and an arbitrary path, so we can use the same widget (or inherit from it for specific widgets) for ``callto`` but also ``tel`` or ``dav`` or ``geo`` or ``nntp`` or ``sip``. And then for arbitrary schemes used by mobile platforms (iOS, Android) for requests and data transfers between applications.

[Husen Daudi (husendaudi)]

Hello Xavier,

In 5.0 GTK client email, callto, SIP protocol widgets are already working.
So its better if you add it in 5.0 web client too as it is not a new feature.
We can say that web team forget to add this in 5.0 development.

[Xavier (Open ERP) (xmo-deactivatedaccount)]

> In 5.0 GTK client email, callto, SIP protocol widgets are already working.
I see no sip support in your proposal. Furthermore, as I said above, I won't merge new custom-uri-scheme-only-widgets. Especially if they're just copy/paste of the URL widget with two keywords changed. If you want to get it merged create a URI widget, and then derive it to Callto or Sip if you want to (as well as URL itself).

> So its better if you add it in 5.0 web client too as it is not a new feature.
It is for the web client.

[Xavier (Open ERP) (xmo-deactivatedaccount)]

> We can say that web team forget to add this in 5.0 development.
We can, but I still won't merge the callto widget in that state.

Unmerged revisions

2911. By husen <husen@husen-laptop> on 2010-08-12

Added callto widget

=== modified file 'openerp/controllers/viewed.py'
--- openerp/controllers/viewed.py	2010-05-19 06:19:37 +0000
+++ openerp/controllers/viewed.py	2010-08-12 13:43:44 +0000
@@ -790,6 +790,7 @@
     'many2many': [],
     'many2one': [],
     'email' : [],
+    'callto' : [],
     'url' : [],
     'image' : ['name', 'string', 'width', 'height', 'required', 'readonly',
                'domain', 'context', 'nolabel', 'colspan', 'widget', 'eval',
 
=== modified file 'openerp/widgets/form.py'
--- openerp/widgets/form.py	2010-06-23 11:32:39 +0000
+++ openerp/widgets/form.py	2010-08-12 13:43:44 +0000
@@ -355,6 +355,15 @@
         if value:
             self.default = value
 
+class Callto(TinyInputWidget):
+    template = "templates/callto.mako"
+
+    def __init__(self, **attrs):
+        super(Callto, self).__init__(**attrs)
+
+    def set_value(self, value):
+        if value:
+            self.default = value
 
 class Text(TinyInputWidget):
     template = "templates/text.mako"
@@ -937,6 +946,7 @@
     'url' : URL,
     'image' : Image,
     'progressbar' : ProgressBar,
+    'callto': Callto,
 }
 
 # vim: ts=4 sts=4 sw=4 si et
 
=== added file 'openerp/widgets/templates/callto.mako'
--- openerp/widgets/templates/callto.mako	1970-01-01 00:00:00 +0000
+++ openerp/widgets/templates/callto.mako	2010-08-12 13:43:44 +0000
@@ -0,0 +1,22 @@
+% if editable:
+    <table width="100%" border="0" cellpadding="0" cellspacing="0">
+        <tr>
+            <td>
+                <input type="text" id="${name}" name="${name}" class="${css_class}"
+                    ${py.attrs(attrs, kind=kind, value=value)}/>
+            </td>
+            <td width="16" style="padding-left: 2px">
+                <img width="16" height="16" alt="${_('Go!')}" 
+                     src="/static/images/stock/gtk-jump-to.png" 
+                     style="cursor: pointer;" 
+                     onclick="window.open('callto:' + $('${name}').value).close();"/>
+            </td>
+        </tr>
+    </table>
+    % if error:
+    <span class="fielderror">${error}</span>
+    % endif
+% else:
+    <a href="callto: ${value}">${value}</a>
+% endif
+
 
=== modified file 'openerp/widgets_search/search.py'
--- openerp/widgets_search/search.py	2009-12-31 05:36:21 +0000
+++ openerp/widgets_search/search.py	2010-08-12 13:43:44 +0000
@@ -234,6 +234,7 @@
     'many2many': Char,
     'many2one': Char,
     'email' : Char,
+    'callto' : Char,
     'url' : Char,
 }