Odoo Web Client

Code review comment for lp:~openerp/openobject-client-web/callto_widget

  1. callto_widget
  2. Merge into 5.0
Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

> In 5.0 GTK client email, callto, SIP protocol widgets are already working.
I see no sip support in your proposal. Furthermore, as I said above, I won't merge new custom-uri-scheme-only-widgets. Especially if they're just copy/paste of the URL widget with two keywords changed. If you want to get it merged create a URI widget, and then derive it to Callto or Sip if you want to (as well as URL itself).

> So its better if you add it in 5.0 web client too as it is not a new feature.
It is for the web client.

« Back to merge proposal